From: Imre Deak Subject: Re: [PATCH v2 2/2] drm/i915/ICL: Add pre_pll_enable hook for ICL and set DFLEXDPMLE in this hook Date: Wed, 31 Oct 2018 20:40:21 +0200 Message-ID: <20181031184021.GE16496@ideak-desk.fi.intel.com> References: <20181023191248.26418-1-manasi.d.navare@intel.com> <20181023191248.26418-2-manasi.d.navare@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1B95D6E379 for ; Wed, 31 Oct 2018 18:40:24 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181023191248.26418-2-manasi.d.navare@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Manasi Navare Cc: intel-gfx@lists.freedesktop.org, Lucas De Marchi , Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMjMsIDIwMTggYXQgMTI6MTI6NDhQTSAtMDcwMCwgTWFuYXNpIE5hdmFyZSB3 cm90ZToKPiBJbiBjYXNlIG9mIExlZ2FjeSBEUCBjb25uZWN0b3Igb24gVHlwZUMgcG9ydCwgdGhl Cj4gZmxleCBJTyBEUE1MRSByZWdpc3RlciBpcyBzZXQgdG8gbnVtYmVyIG9mIGxhbmVzIGNvbmZp Z3VyZWQKPiBieSB0aGUgZGlzcGxheSBkcml2ZXIgd2hpY2ggd2lsbCBiZSBwcm9ncmFtbWVkIGlu dG8gRERJX0JVRl9DVEwKPiBQT1JUX1dJRFRIX1NFTEVDVElPTi4KPiBUaGlzIG5lZWRzIHRvIGJl IHByb2dyYW1tZWQgYmVmb3JlIGVuYWJsaW5nIHRoZSBzaGFyZWQgUExMcyBoZW5jZQo+IGFkZCBh IHByZV9wbGxfZW5hYmxlIGhvb2sgZm9yIElDTCBhbmQgYWRkIHRoaXMgcHJvZ3JhbW1pbmcgaW4g dGhhdCBob29rLgo+IAo+IHYyOgo+ICogUmVtb3ZlIHRoZSBjaGVjayBmb3IgY29tYm9waHkgcG9y dCAoSm9zZSkKPiAqIFNpbXBsaWZ5IHRoZSBwb3J0IHJldmVyc2FsIGNoZWNrIGxvZ2ljIChKb3Nl KQo+IAo+IENjOiBMdWNhcyBEZSBNYXJjaGkgPGx1Y2FzLmRlbWFyY2hpQGludGVsLmNvbT4KPiBD YzogSm9zZSBSb2JlcnRvIGRlIFNvdXphIDxqb3NlLnNvdXphQGludGVsLmNvbT4KPiBDYzogQW5p bWVzaCBNYW5uYSA8YW5pbWVzaC5tYW5uYUBpbnRlbC5jb20+Cj4gQ2M6IFBhdWxvIFphbm9uaSA8 cGF1bG8uci56YW5vbmlAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IE1hbmFzaSBOYXZhcmUg PG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+Cj4gUmV2aWV3ZWQtYnk6IEpvc8OpIFJvYmVydG8g ZGUgU291emEgPGpvc2Uuc291emFAaW50ZWwuY29tPgoKTG9va3Mgb2s6CkFja2VkLWJ5OiBJbXJl IERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+CgpNYW5hc2ksIGFyZSB5b3UgZ29pbmcgdG8gbWVy Z2UgdGhpcz8gSSBjb3VsZCByZWJhc2UgbXkgcGF0Y2hzZXQgYWZ0ZXIKdGhhdC4KCj4gLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIHwgNDkgKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDQ5IGluc2VydGlvbnMoKykKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+IGluZGV4IDZiOTc0MmJhYTVmMi4uMjQ2NDI0NjA1NzY4 IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiBAQCAtMzMxMSw2ICszMzExLDUzIEBA IHN0YXRpYyB2b2lkIGJ4dF9kZGlfcHJlX3BsbF9lbmFibGUoc3RydWN0IGludGVsX2VuY29kZXIg KmVuY29kZXIsCj4gIAlieHRfZGRpX3BoeV9zZXRfbGFuZV9vcHRpbV9tYXNrKGVuY29kZXIsIG1h c2spOwo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZCBpbnRlbF9kZGlfc2V0X2ZpYV9sYW5lX2NvdW50 KHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICsJCQkJCSBjb25zdCBzdHJ1Y3QgaW50 ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcsCj4gKwkJCQkJIGVudW0gcG9ydCBwb3J0KQo+ICt7 Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGVuY29kZXIt PmJhc2UuZGV2KTsKPiArCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0ID0gZW5j X3RvX2RpZ19wb3J0KCZlbmNvZGVyLT5iYXNlKTsKPiArCWVudW0gdGNfcG9ydCB0Y19wb3J0ID0g aW50ZWxfcG9ydF90b190YyhkZXZfcHJpdiwgcG9ydCk7Cj4gKwl1MzIgdmFsID0gSTkxNV9SRUFE KFBPUlRfVFhfREZMRVhEUE1MRTEpOwo+ICsJYm9vbCBsYW5lX3JldmVyc2FsID0gZGlnX3BvcnQt PnNhdmVkX3BvcnRfYml0cyAmIERESV9CVUZfUE9SVF9SRVZFUlNBTDsKPiArCj4gKwl2YWwgJj0g fkRGTEVYRFBNTEUxX0RQTUxFVENfTUFTSyh0Y19wb3J0KTsKPiArCXN3aXRjaCAocGlwZV9jb25m aWctPmxhbmVfY291bnQpIHsKPiArCWNhc2UgMToKPiArCQl2YWwgfD0gKGxhbmVfcmV2ZXJzYWwp ID8gREZMRVhEUE1MRTFfRFBNTEVUQ19NTDModGNfcG9ydCkgOgo+ICsJCURGTEVYRFBNTEUxX0RQ TUxFVENfTUwwKHRjX3BvcnQpOwo+ICsJCWJyZWFrOwo+ICsJY2FzZSAyOgo+ICsJCXZhbCB8PSAo bGFuZV9yZXZlcnNhbCkgPyBERkxFWERQTUxFMV9EUE1MRVRDX01MM18yKHRjX3BvcnQpIDoKPiAr CQlERkxFWERQTUxFMV9EUE1MRVRDX01MMV8wKHRjX3BvcnQpOwo+ICsJCWJyZWFrOwo+ICsJY2Fz ZSA0Ogo+ICsJCXZhbCB8PSBERkxFWERQTUxFMV9EUE1MRVRDX01MM18wKHRjX3BvcnQpOwo+ICsJ CWJyZWFrOwo+ICsJZGVmYXVsdDoKPiArCQlNSVNTSU5HX0NBU0UocGlwZV9jb25maWctPmxhbmVf Y291bnQpOwo+ICsJfQo+ICsJSTkxNV9XUklURShQT1JUX1RYX0RGTEVYRFBNTEUxLCB2YWwpOwo+ ICt9Cj4gKwo+ICtzdGF0aWMgdm9pZCBpY2xfZGRpX3ByZV9wbGxfZW5hYmxlKHN0cnVjdCBpbnRl bF9lbmNvZGVyICplbmNvZGVyLAo+ICsJCQkJICAgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3Rh dGUgKnBpcGVfY29uZmlnLAo+ICsJCQkJICAgY29uc3Qgc3RydWN0IGRybV9jb25uZWN0b3Jfc3Rh dGUgKmNvbm5fc3RhdGUpCj4gK3sKPiArCWVudW0gcG9ydCBwb3J0ID0gZW5jb2Rlci0+cG9ydDsK PiArCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0ID0gZW5jX3RvX2RpZ19wb3J0 KCZlbmNvZGVyLT5iYXNlKTsKPiArCj4gKwkvKgo+ICsJICogUHJvZ3JhbSB0aGUgbGFuZSBjb3Vu dCBmb3Igc3RhdGljL2R5bmFtaWMgY29ubmVjdGlvbnMgb24gVHlwZS1DIHBvcnRzLgo+ICsJICog U2tpcCB0aGlzIHN0ZXAgZm9yIFRCVC4KPiArCSAqLwo+ICsJaWYgKGRpZ19wb3J0LT50Y190eXBl ID09IFRDX1BPUlRfVU5LTk9XTiB8fAo+ICsJICAgIGRpZ19wb3J0LT50Y190eXBlID09IFRDX1BP UlRfVEJUKQo+ICsJCXJldHVybjsKPiArCj4gKwlpbnRlbF9kZGlfc2V0X2ZpYV9sYW5lX2NvdW50 KGVuY29kZXIsIHBpcGVfY29uZmlnLCBwb3J0KTsKPiArfQo+ICsKPiAgdm9pZCBpbnRlbF9kZGlf cHJlcGFyZV9saW5rX3JldHJhaW4oc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAgewo+ICAJ c3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQgPSBkcF90b19kaWdfcG9y dChpbnRlbF9kcCk7Cj4gQEAgLTM4MjgsNiArMzg3NSw4IEBAIHZvaWQgaW50ZWxfZGRpX2luaXQo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBlbnVtIHBvcnQgcG9ydCkKPiAgCWlu dGVsX2VuY29kZXItPmVuYWJsZSA9IGludGVsX2VuYWJsZV9kZGk7Cj4gIAlpZiAoSVNfR0VOOV9M UChkZXZfcHJpdikpCj4gIAkJaW50ZWxfZW5jb2Rlci0+cHJlX3BsbF9lbmFibGUgPSBieHRfZGRp X3ByZV9wbGxfZW5hYmxlOwo+ICsJaWYgKElTX0lDRUxBS0UoZGV2X3ByaXYpKQo+ICsJCWludGVs X2VuY29kZXItPnByZV9wbGxfZW5hYmxlID0gaWNsX2RkaV9wcmVfcGxsX2VuYWJsZTsKPiAgCWlu dGVsX2VuY29kZXItPnByZV9lbmFibGUgPSBpbnRlbF9kZGlfcHJlX2VuYWJsZTsKPiAgCWludGVs X2VuY29kZXItPmRpc2FibGUgPSBpbnRlbF9kaXNhYmxlX2RkaTsKPiAgCWludGVsX2VuY29kZXIt PnBvc3RfZGlzYWJsZSA9IGludGVsX2RkaV9wb3N0X2Rpc2FibGU7Cj4gLS0gCj4gMi4xOC4wCj4g Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRl bC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=