Received-SPF: pass (google.com: domain of code@wizofe.uk designates 185.20.209.243 as permitted sender) client-ip=185.20.209.243;
Date: Wed, 31 Oct 2018 20:56:36 +0000
From: Ioannis Valasakis <code@wizofe.uk>
To: outreachy-kernel@googlegroups.com
Cc: gregkh@linuxfoundation.org, sasha.levin@microsoft.com
Subject: [PATH v3] staging: gasket: Create a memory allocation error handling
 path
Message-ID: <20181031205636.GA13583@kvasir.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.10.1 (2018-07-13)

Create an error handling path for memory allocation. It avoids repeating
the same assignments and returns the respective ENOMEM.

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
Changes in v3:
	- Modified the label names so they free the right memory 

 drivers/staging/gasket/gasket_interrupt.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/gasket/gasket_interrupt.c b/drivers/staging/gasket/gasket_interrupt.c
index 23232ea8f4d9..b1ee9a70bdd8 100644
--- a/drivers/staging/gasket/gasket_interrupt.c
+++ b/drivers/staging/gasket/gasket_interrupt.c
@@ -362,7 +362,7 @@ int gasket_interrupt_init(struct gasket_dev *gasket_dev, const char *name,
 						   sizeof(ulong),
 						   GFP_KERNEL);
 	if (!interrupt_data->interrupt_counts) {
-		goto err_free_data;
+		goto err_free_all;
 	}
 
 	switch (interrupt_data->type) {
@@ -397,11 +397,11 @@ int gasket_interrupt_init(struct gasket_dev *gasket_dev, const char *name,
 
 	return 0;
 
-err_free_msix:
+err_free_all:
 	kfree(interrupt_data->eventfd_ctxs);
 err_free_eventfd:
 	kfree(interrupt_data->msix_entries);
-err_free_data:
+err_free_msix:
 	kfree(interrupt_data);
 	return -ENOMEM;
 }
-- 
2.19.1