From: Imre Deak Subject: Re: [PATCH v3 2/4] drm/i915/icl: Implement Display WA_1405510057 Date: Fri, 2 Nov 2018 01:52:20 +0200 Message-ID: <20181101235220.GA23885@ideak-desk.fi.intel.com> References: <20181030084504.21537-1-radhakrishna.sripada@intel.com> <20181030084504.21537-2-radhakrishna.sripada@intel.com> <20181030222735.GH2164@intel.com> <20181101193304.GG2092@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id CA9DE6E4E7 for ; Thu, 1 Nov 2018 23:52:23 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181101193304.GG2092@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBOb3YgMDEsIDIwMTggYXQgMTI6MzM6MDRQTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IE9uIFR1ZSwgT2N0IDMwLCAyMDE4IGF0IDAzOjI3OjM1UE0gLTA3MDAsIFJvZHJpZ28g Vml2aSB3cm90ZToKPiA+IE9uIFR1ZSwgT2N0IDMwLCAyMDE4IGF0IDAxOjQ1OjAyQU0gLTA3MDAs IFJhZGhha3Jpc2huYSBTcmlwYWRhIHdyb3RlOgo+ID4gPiBEaXNwbGF5IFdBXzE0MDU1MTAwNTcg YXNrcyB0byBub3QgZW5hYmxlIFlVViA0MjAgSERNSQo+ID4gPiAxMGJwYyB3aGVuIGhvcml6b250 YWwgYmxhbmsgc2l6ZSBtb2QgOCByZW1pbmRlciBpcyAyLgo+ID4gPiAKPiA+ID4gVjI6IFJlYmFz ZShyLWI6IEFudXNoYSkKPiA+ID4gVjM6IGNydGNfc3RhdGUtPnMveWNiY3I0MjAvb3V0cHV0X2Zv cm1hdC8KPiA+ID4gCj4gPiA+IENjOiBBbnVzaGEgU3JpdmF0c2EgPGFudXNoYS5zcml2YXRzYUBp bnRlbC5jb20+Cj4gPiA+IENjOiBQYXVsbyBaYW5vbmkgPHBhdWxvLnIuemFub25pQGludGVsLmNv bT4KPiA+ID4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiA+ID4g Q2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiA+ IFNpZ25lZC1vZmYtYnk6IFJhZGhha3Jpc2huYSBTcmlwYWRhIDxyYWRoYWtyaXNobmEuc3JpcGFk YUBpbnRlbC5jb20+Cj4gPiAKPiA+IFJldmlld2VkLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28u dml2aUBpbnRlbC5jb20+Cj4gCj4gcHVzaGVkIHRvIGRpbnEuIHRoYW5rcyBmb3IgcGF0Y2hlcyBh bmQgcmV2aWV3cy4KCkkgdGhpbmsgdGhlcmUgd2FzIGEgd3JvbmcgY29uZmxpY3QgcmVzb2x1dGlv biBpbiB0aGlzIHB1c2g6Cgpjb21taXQgMDk5MmU3ODFkN2NlNzA3ODg5ZDgxZjhlMzQ5Y2UxNTYx MzkyNDkzZgpNZXJnZTogMTBjZjRmZDYzZWVkIGY1N2Y5MzcxZTI4NQpBdXRob3I6IFJvZHJpZ28g Vml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KRGF0ZTogICBUaHUgTm92IDEgMTI6NDM6MjUg MjAxOCAtMDcwMAoKICAgIE1lcmdlIHJlbW90ZS10cmFja2luZyBicmFuY2ggJ2RybS1pbnRlbC9k cm0taW50ZWwtbmV4dC1xdWV1ZWQnIGludG8gZHJtLXRpcAogICAgCiAgICAjIENvbmZsaWN0czoK ICAgICMgICAgICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKICAgICMgICAg ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwogICAgIyAgICAgICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9jc3IuYwogICAgIyAgICAgICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMKICAgICMgICAgICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAu YwogICAgIyAgICAgICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9tc3QuYwogICAgIyAg ICAgICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAoKZGlmZiAtLWNjIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwppbmRleCA5NzQxY2M0MTllMWIsMzYxOGQzYWZm Yzg5Li41MzIxNzg3NjNmYTEKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwpAQEAgLTE1NzAx LDE0IC0xNTQxNCwxOCArMTU0MTQsMjUgQEBAIHN0YXRpYyB2b2lkIHJlYWRvdXRfcGxhbmVfc3Rh dGUoc3RydWN0IAogIAkJY3J0Y19zdGF0ZSA9IHRvX2ludGVsX2NydGNfc3RhdGUoY3J0Yy0+YmFz ZS5zdGF0ZSk7CiAgCiAgCQlpbnRlbF9zZXRfcGxhbmVfdmlzaWJsZShjcnRjX3N0YXRlLCBwbGFu ZV9zdGF0ZSwgdmlzaWJsZSk7CisgCisgCQlEUk1fREVCVUdfS01TKCJbUExBTkU6JWQ6JXNdIGh3 IHN0YXRlIHJlYWRvdXQ6ICVzLCBwaXBlICVjXG4iLAorIAkJCSAgICAgIHBsYW5lLT5iYXNlLmJh c2UuaWQsIHBsYW5lLT5iYXNlLm5hbWUsCisgCQkJICAgICAgZW5hYmxlZGRpc2FibGVkKHZpc2li bGUpLCBwaXBlX25hbWUocGlwZSkpOworIAl9CisgCisgCWZvcl9lYWNoX2ludGVsX2NydGMoJmRl dl9wcml2LT5kcm0sIGNydGMpIHsKKyAJCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0 YXRlID0KKyAJCQl0b19pbnRlbF9jcnRjX3N0YXRlKGNydGMtPmJhc2Uuc3RhdGUpOworIAorIAkJ Zml4dXBfYWN0aXZlX3BsYW5lcyhjcnRjX3N0YXRlKTsKICAJfQogKwogKwlmb3JfZWFjaF9pbnRl bF9jcnRjKCZkZXZfcHJpdi0+ZHJtLCBjcnRjKSB7CiArCQlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0 ZSAqY3J0Y19zdGF0ZSA9CiArCQkJdG9faW50ZWxfY3J0Y19zdGF0ZShjcnRjLT5iYXNlLnN0YXRl KTsKICsKICsJCWZpeHVwX2FjdGl2ZV9wbGFuZXMoY3J0Y19zdGF0ZSk7CiArCX0KICB9CiAgCiAg c3RhdGljIHZvaWQgaW50ZWxfbW9kZXNldF9yZWFkb3V0X2h3X3N0YXRlKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYpCgpJJ20gcmVzb2x2aW5nIGl0IHdpdGgga2VlcGluZyBvbmx5IG9uZSBvZiB0aGUg Zm9yX2VhY2hfaW50ZWxfY3J0YygpCmxvb3AuCgo+IAo+ID4gCj4gPiA+IC0tLQo+ID4gPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaGRtaS5jIHwgMTEgKysrKysrKysrKy0KPiA+ID4gIDEg ZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gPiA+IAo+ID4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaGRtaS5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfaGRtaS5jCj4gPiA+IGluZGV4IDEyOWI4ODBiY2U2NC4uNmM2 YzRkZDEyZmQ1IDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9o ZG1pLmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaGRtaS5jCj4gPiA+ IEBAIC0xNTk1LDYgKzE1OTUsOCBAQCBzdGF0aWMgYm9vbCBoZG1pX2RlZXBfY29sb3JfcG9zc2li bGUoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gPiA+ICAJc3Ry dWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlID0gY3J0Y19zdGF0ZS0+YmFzZS5zdGF0ZTsKPiA+ ID4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqY29ubmVjdG9yX3N0YXRlOwo+ID4gPiAg CXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3I7Cj4gPiA+ICsJY29uc3Qgc3RydWN0IGRy bV9kaXNwbGF5X21vZGUgKmFkanVzdGVkX21vZGUgPQo+ID4gPiArCQkmY3J0Y19zdGF0ZS0+YmFz ZS5hZGp1c3RlZF9tb2RlOwo+ID4gPiAgCWludCBpOwo+ID4gPiAgCj4gPiA+ICAJaWYgKEhBU19H TUNIX0RJU1BMQVkoZGV2X3ByaXYpKQo+ID4gPiBAQCAtMTY0Myw3ICsxNjQ1LDE0IEBAIHN0YXRp YyBib29sIGhkbWlfZGVlcF9jb2xvcl9wb3NzaWJsZShjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19z dGF0ZSAqY3J0Y19zdGF0ZSwKPiA+ID4gIAo+ID4gPiAgCS8qIERpc3BsYXkgV0EgIzExMzk6IGds ayAqLwo+ID4gPiAgCWlmIChicGMgPT0gMTIgJiYgSVNfR0xLX1JFVklEKGRldl9wcml2LCAwLCBH TEtfUkVWSURfQTEpICYmCj4gPiA+IC0JICAgIGNydGNfc3RhdGUtPmJhc2UuYWRqdXN0ZWRfbW9k ZS5odG90YWwgPiA1NDYwKQo+ID4gPiArCSAgICBhZGp1c3RlZF9tb2RlLT5odG90YWwgPiA1NDYw KQo+ID4gPiArCQlyZXR1cm4gZmFsc2U7Cj4gPiA+ICsKPiA+ID4gKwkvKiBEaXNwbGF5IFdhXzE0 MDU1MTAwNTc6aWNsICovCj4gPiA+ICsJaWYgKGNydGNfc3RhdGUtPm91dHB1dF9mb3JtYXQgPT0g SU5URUxfT1VUUFVUX0ZPUk1BVF9ZQ0JDUjQyMCAmJgo+ID4gPiArCSAgICBicGMgPT0gMTAgJiYg SVNfSUNFTEFLRShkZXZfcHJpdikgJiYKPiA+ID4gKwkgICAgKGFkanVzdGVkX21vZGUtPmNydGNf aGJsYW5rX2VuZCAtCj4gPiA+ICsJICAgICBhZGp1c3RlZF9tb2RlLT5jcnRjX2hibGFua19zdGFy dCkgJSA4ID09IDIpCj4gPiA+ICAJCXJldHVybiBmYWxzZTsKPiA+ID4gIAo+ID4gPiAgCXJldHVy biB0cnVlOwo+ID4gPiAtLSAKPiA+ID4gMi45LjMKPiA+ID4gCj4gPiBfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKPiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxp c3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==