DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BDF12081B
From:   Qu Wenruo <wqu@suse.com>
To:     linux-btrfs@vger.kernel.org
Cc:     dsterba@suse.cz, josef@toxicpanda.com
Subject: [PATCH v5 0/4] btrfs: Refactor find_free_extent()
Date:   Fri,  2 Nov 2018 09:39:46 +0800
Message-Id: <20181102013950.30293-1-wqu@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-btrfs-owner@vger.kernel.org
Precedence: bulk

Can be fetched from github:
https://github.com/adam900710/linux/tree/refactor_find_free_extent

Which is based on david's misc-4.20 branch.
The base head is:

commit 9084cb6a24bf5838a665af92ded1af8363f9e563 (david/misc-4.20)
Author: Filipe Manana <fdmanana@suse.com>
Date:   Mon Oct 22 10:43:06 2018 +0100

    Btrfs: fix use-after-free when dumping free space


extent-tree.c::find_free_extent() could be one of the most
ill-structured functions, it has at least 6 non-exit tags and jumps
between them.

Refactor it into 4 parts:

1) find_free_extent()
   The main entrance, does the main work of block group iteration and
   block group selection.
   Now this function doesn't care nor handles free extent search by
   itself.

2) find_free_extent_clustered()
   Do clustered free extent search.
   May try to build/re-fill cluster.

3) find_free_extent_unclustered()
   Do unclustered free extent search.
   May try to fill free space cache.

4) find_free_extent_update_loop()
   Do the loop based black magic.
   May allocate new chunk.

With this patch, at least we should make find_free_extent() a little
easier to read, and provides the basis for later work on this function.

Current refactor is trying not to touch the original functionality, thus
the helper structure find_free_extent_ctl still contains a lot of
unrelated members.
But it should not change how find_free_extent() works at all.

changelog:
v2:
  Split into 4 patches.
  Minor comment newline change.
v3:
  Mostly cosmetic update.
  Rebased to v4.19-rc1
  Rename find_free_extent_ctrl to find_free_extent_ctl to keep the
  naming scheme the same.
  Fix some comment spelling error.
  Enhance comment for find_free_extent_unclustered().
  Add reviewed-by tag.
v4:
  Move the (ins->objectid) check to proper location of the last patch,
  so all (!ins->objectid) branches are in the same code block.
  Add reviewed-by tags from Josef.
v5:
  Fix all warning reported by checkpatch.pl
  Rebase to misc-4.20.
  Solve conflicts with fb5c39d7a887 ("btrfs: don't use ctl->free_space for max_extent_size").
  This results:
  * New member find_free_extent_ctl::total_free_space
  * New comment for find_free_extent_ctl::total_free_space
  * New comment for falling back to total_free_space if we can't find
    valid find_free_extent_ctl::max_extent_size.

Qu Wenruo (4):
  btrfs: Introduce find_free_extent_ctl structure for later rework
  btrfs: Refactor clustered extent allocation into
    find_free_extent_clustered()
  btrfs: Refactor unclustered extent allocation into
    find_free_extent_unclustered()
  btrfs: Refactor find_free_extent() loops update into
    find_free_extent_update_loop()

 fs/btrfs/extent-tree.c | 715 ++++++++++++++++++++++++-----------------
 1 file changed, 414 insertions(+), 301 deletions(-)

-- 
2.19.1