Received-SPF: pass (google.com: domain of sashal@kernel.org designates 198.145.29.99 as permitted sender) client-ip=198.145.29.99;
Date: Fri, 2 Nov 2018 10:26:57 -0400
From: Sasha Levin <sashal@kernel.org>
To: Ioannis Valasakis <code@wizofe.uk>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org
Subject: Re: [Outreachy kernel] [PATCH v2 1/5] staging: greybus Align
 parameters to parentheses
Message-ID: <20181102142657.GF194472@sasha-vm>
References: <cover.1541162672.git.code@wizofe.uk>
 <537e6bd9f572df1cce6fc8624471a9c7c2714c35.1541162672.git.code@wizofe.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <537e6bd9f572df1cce6fc8624471a9c7c2714c35.1541162672.git.code@wizofe.uk>
User-Agent: Mutt/1.9.4 (2018-02-28)

On Fri, Nov 02, 2018 at 12:48:01PM +0000, Ioannis Valasakis wrote:
>Align parameters to the right side of the left parentheses
>Reported by checkpatch.
>
>Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
>---
> drivers/staging/greybus/core.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/staging/greybus/core.c b/drivers/staging/greybus/core.c
>index dafa430d176e..d28773e06838 100644
>--- a/drivers/staging/greybus/core.c
>+++ b/drivers/staging/greybus/core.c
>@@ -28,7 +28,7 @@ int greybus_disabled(void)
> EXPORT_SYMBOL_GPL(greybus_disabled);
>
> static bool greybus_match_one_id(struct gb_bundle *bundle,
>-				     const struct greybus_bundle_id *id)
>+				 const struct greybus_bundle_id *id)
> {
> 	if ((id->match_flags & GREYBUS_ID_MATCH_VENDOR) &&
> 	    (id->vendor != bundle->intf->vendor_id))
>@@ -48,7 +48,7 @@ static bool greybus_match_one_id(struct gb_bundle *bundle,
> static const struct greybus_bundle_id *
> greybus_match_id(struct gb_bundle *bundle, const struct greybus_bundle_id *id)
> {
>-	if (id == NULL)
>+	if (!id == NULL)
> 		return NULL;

This change doesn't look right. It also doesn't do what the commit log
says this commit does.

--
Thanks,
Sasha