From: Andy Shevchenko Subject: Re: [alsa-devel] [PATCH] ASoC: skl: always select SND_SOC_HDAC_HDA Date: Tue, 6 Nov 2018 12:10:58 +0200 Message-ID: <20181106101058.GQ10650@smile.fi.intel.com> References: <20181102112456.780127-1-arnd@arndb.de> <943d10e2-299c-4393-f2f5-4ac8bbe400c3@linux.intel.com> <20181105133545.GF10650@smile.fi.intel.com> <5c21e5d9-6a14-ff4f-04f2-9dbfc8665250@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: Pierre-Louis Bossart , Takashi Iwai , ALSA Development Mailing List , guneshwor.o.singh@intel.com, naveen.m@intel.com, pankaj.laxminarayan.bharadiya@intel.com, rakesh.a.ughreja@intel.com, sanyog.r.kale@intel.com, sriramx.periyasamy@intel.com, Mark Brown , Vinod Koul , liam.r.girdwood@linux.intel.com, yang.jie@linux.intel.com, Linux Kernel Mailing List List-Id: alsa-devel@alsa-project.org On Mon, Nov 05, 2018 at 10:19:02PM +0100, Arnd Bergmann wrote: > On 11/5/18, Andy Shevchenko wrote: > > On Mon, Nov 5, 2018 at 7:19 PM Pierre-Louis Bossart > > wrote: > >> >> config SND_SOC_HDAC_HDA_FORCE > >> >> tristate > > > >> >> depends on SND_SOC_ALL_CODECS != n > > > > Forgot to mention that AFAIU above line is no-op in symbols which are > > hidden. > > > > It's not. In this case, it will prevent SND_SOC_HDAC_HDA_FORCE > from being turned on by the 'default ...' line. In other cases, it can > generate a warning if you have a hidden symbol that is selected > by some other symbol while the dependency is missing. Something new to learn. Thanks, Arnd, for describing this case. -- With Best Regards, Andy Shevchenko