From: Sean Paul Subject: Re: [Intel-gfx] [PATCH 1/2] drm: Add CRTC background color property Date: Wed, 7 Nov 2018 11:14:31 -0500 Message-ID: <20181107161431.GA154160@art_vandelay> References: <20181010235051.16693-1-matthew.d.roper@intel.com> <20181010235051.16693-2-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20181010235051.16693-2-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Matt Roper Cc: wei.c.li@intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, harish.krupo.kps@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBPY3QgMTAsIDIwMTggYXQgMDQ6NTA6NTBQTSAtMDcwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBTb21lIGRpc3BsYXkgY29udHJvbGxlcnMgY2FuIGJlIHByb2dyYW1tZWQgdG8gcHJlc2Vu dCBub24tYmxhY2sgY29sb3JzCj4gZm9yIHBpeGVscyBub3QgY292ZXJlZCBieSBhbnkgcGxhbmUg KG9yIHBpeGVscyBjb3ZlcmVkIGJ5IHRoZQo+IHRyYW5zcGFyZW50IHJlZ2lvbnMgb2YgaGlnaGVy IHBsYW5lcykuICBDb21wb3NpdG9ycyB0aGF0IHdhbnQgYSBVSSB3aXRoCj4gYSBzb2xpZCBjb2xv ciBiYWNrZ3JvdW5kIGNhbiBwb3RlbnRpYWxseSBzYXZlIG1lbW9yeSBiYW5kd2lkdGggYnkKPiBz ZXR0aW5nIHRoZSBDUlRDIGJhY2tncm91bmQgcHJvcGVydHkgYW5kIHVzaW5nIHNtYWxsZXIgcGxh bmVzIHRvIGRpc3BsYXkKPiB0aGUgcmVzdCBvZiB0aGUgY29udGVudC4KPiAKPiBUbyBhdm9pZCBj b25mdXNpb24gYmV0d2VlbiBkaWZmZXJlbnQgd2F5cyBvZiBlbmNvZGluZyBSR0IgZGF0YSwgd2UK PiBkZWZpbmUgYSBzdGFuZGFyZCA2NC1iaXQgZm9ybWF0IHRoYXQgc2hvdWxkIGJlIHVzZWQgZm9y IHRoaXMgcHJvcGVydHkncwo+IHZhbHVlLiAgSGVscGVyIGZ1bmN0aW9ucyBhbmQgbWFjcm9zIGFy ZSBwcm92aWRlZCB0byBnZW5lcmF0ZSBhbmQgZGlzc2VjdAo+IHZhbHVlcyBpbiB0aGlzIHN0YW5k YXJkIGZvcm1hdCB3aXRoIHZhcnlpbmcgY29tcG9uZW50IHByZWNpc2lvbiB2YWx1ZXMuCj4gCj4g Q2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBDYzogd2VpLmMubGlAaW50ZWwu Y29tCj4gQ2M6IGhhcmlzaC5rcnVwby5rcHNAaW50ZWwuY29tCj4gU2lnbmVkLW9mZi1ieTogTWF0 dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2RybV9hdG9taWNfc3RhdGVfaGVscGVyLmMgfCAgMSArCj4gIGRyaXZlcnMvZ3B1L2RybS9k cm1fYXRvbWljX3VhcGkuYyAgICAgICAgIHwgIDUgKysrKysKPiAgZHJpdmVycy9ncHUvZHJtL2Ry bV9tb2RlX2NvbmZpZy5jICAgICAgICAgfCAgNiArKysrKysKPiAgaW5jbHVkZS9kcm0vZHJtX2Ny dGMuaCAgICAgICAgICAgICAgICAgICAgfCAxNyArKysrKysrKysrKysrKysrKwo+ICBpbmNsdWRl L2RybS9kcm1fbW9kZV9jb25maWcuaCAgICAgICAgICAgICB8ICA1ICsrKysrCj4gIGluY2x1ZGUv dWFwaS9kcm0vZHJtX21vZGUuaCAgICAgICAgICAgICAgIHwgMjYgKysrKysrKysrKysrKysrKysr KysrKysrKysKPiAgNiBmaWxlcyBjaGFuZ2VkLCA2MCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX3N0YXRlX2hlbHBlci5jIGIvZHJpdmVy cy9ncHUvZHJtL2RybV9hdG9taWNfc3RhdGVfaGVscGVyLmMKPiBpbmRleCAzYmE5OTYwNjlkNjku LjJmOGM1NTY2ODA4OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19z dGF0ZV9oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX3N0YXRlX2hl bHBlci5jCj4gQEAgLTEwMSw2ICsxMDEsNyBAQCB2b2lkIF9fZHJtX2F0b21pY19oZWxwZXJfY3J0 Y19kdXBsaWNhdGVfc3RhdGUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJc3RhdGUtPnBsYW5l c19jaGFuZ2VkID0gZmFsc2U7Cj4gIAlzdGF0ZS0+Y29ubmVjdG9yc19jaGFuZ2VkID0gZmFsc2U7 Cj4gIAlzdGF0ZS0+Y29sb3JfbWdtdF9jaGFuZ2VkID0gZmFsc2U7Cj4gKwlzdGF0ZS0+Ymdjb2xv cl9jaGFuZ2VkID0gZmFsc2U7Cj4gIAlzdGF0ZS0+enBvc19jaGFuZ2VkID0gZmFsc2U7Cj4gIAlz dGF0ZS0+Y29tbWl0ID0gTlVMTDsKPiAgCXN0YXRlLT5ldmVudCA9IE5VTEw7Cj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX3VhcGkuYyBiL2RyaXZlcnMvZ3B1L2RybS9k cm1fYXRvbWljX3VhcGkuYwo+IGluZGV4IGQ1YjdmMzE1MDk4Yy4uMzk5ZjBlYWQ1MzcwIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX3VhcGkuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fYXRvbWljX3VhcGkuYwo+IEBAIC00NjcsNiArNDY3LDkgQEAgc3RhdGlj IGludCBkcm1fYXRvbWljX2NydGNfc2V0X3Byb3BlcnR5KHN0cnVjdCBkcm1fY3J0YyAqY3J0YywK PiAgCQkJcmV0dXJuIC1FRkFVTFQ7Cj4gIAo+ICAJCXNldF9vdXRfZmVuY2VfZm9yX2NydGMoc3Rh dGUtPnN0YXRlLCBjcnRjLCBmZW5jZV9wdHIpOwo+ICsJfSBlbHNlIGlmIChwcm9wZXJ0eSA9PSBj b25maWctPmJnY29sb3JfcHJvcGVydHkpIHsKPiArCQlzdGF0ZS0+YmFja2dyb3VuZF9jb2xvciA9 IHZhbDsKPiArCQlzdGF0ZS0+Ymdjb2xvcl9jaGFuZ2VkID0gdHJ1ZTsKPiAgCX0gZWxzZSBpZiAo Y3J0Yy0+ZnVuY3MtPmF0b21pY19zZXRfcHJvcGVydHkpIHsKPiAgCQlyZXR1cm4gY3J0Yy0+ZnVu Y3MtPmF0b21pY19zZXRfcHJvcGVydHkoY3J0Yywgc3RhdGUsIHByb3BlcnR5LCB2YWwpOwo+ICAJ fSBlbHNlIHsKPiBAQCAtNDk5LDYgKzUwMiw4IEBAIGRybV9hdG9taWNfY3J0Y19nZXRfcHJvcGVy dHkoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJCSp2YWwgPSAoc3RhdGUtPmdhbW1hX2x1dCkg PyBzdGF0ZS0+Z2FtbWFfbHV0LT5iYXNlLmlkIDogMDsKPiAgCWVsc2UgaWYgKHByb3BlcnR5ID09 IGNvbmZpZy0+cHJvcF9vdXRfZmVuY2VfcHRyKQo+ICAJCSp2YWwgPSAwOwo+ICsJZWxzZSBpZiAo cHJvcGVydHkgPT0gY29uZmlnLT5iZ2NvbG9yX3Byb3BlcnR5KQo+ICsJCSp2YWwgPSBzdGF0ZS0+ YmFja2dyb3VuZF9jb2xvcjsKPiAgCWVsc2UgaWYgKGNydGMtPmZ1bmNzLT5hdG9taWNfZ2V0X3By b3BlcnR5KQo+ICAJCXJldHVybiBjcnRjLT5mdW5jcy0+YXRvbWljX2dldF9wcm9wZXJ0eShjcnRj LCBzdGF0ZSwgcHJvcGVydHksIHZhbCk7Cj4gIAllbHNlCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9kcm1fbW9kZV9jb25maWcuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fbW9kZV9jb25m aWcuYwo+IGluZGV4IGVlODA3ODhmMmM0MC4uNzVlMzc2NzU1MTc2IDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9kcm1fbW9kZV9jb25maWcuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9k cm1fbW9kZV9jb25maWcuYwo+IEBAIC0zNTIsNiArMzUyLDEyIEBAIHN0YXRpYyBpbnQgZHJtX21v ZGVfY3JlYXRlX3N0YW5kYXJkX3Byb3BlcnRpZXMoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAg CQlyZXR1cm4gLUVOT01FTTsKPiAgCWRldi0+bW9kZV9jb25maWcubW9kaWZpZXJzX3Byb3BlcnR5 ID0gcHJvcDsKPiAgCj4gKwlwcm9wID0gZHJtX3Byb3BlcnR5X2NyZWF0ZV9yYW5nZShkZXYsIDAs ICJCQUNLR1JPVU5EX0NPTE9SIiwKClRoaXMgcHJvcGVydHkgc2hvdWxkIGJlIGRvY3VtZW50ZWQg c29tZXdoZXJlPyBNYXliZSB1bmRlciAiQ29sb3IgTWFuYWdlbWVudApQcm9wZXJ0aWVzIiwgc2lu Y2UgdGhleSBhcHBseSB0byBjcnRjPwoKCj4gKwkJCQkJIDAsIEdFTk1BU0tfVUxMKDYzLCAwKSk7 Cj4gKwlpZiAoIXByb3ApCj4gKwkJcmV0dXJuIC1FTk9NRU07Cj4gKwlkZXYtPm1vZGVfY29uZmln LmJnY29sb3JfcHJvcGVydHkgPSBwcm9wOwo+ICsKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+IGRp ZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1fY3J0Yy5oIGIvaW5jbHVkZS9kcm0vZHJtX2NydGMu aAo+IGluZGV4IGIyMTQzN2JjOTViZi4uZGRmZGFkOWNjZWNiIDEwMDY0NAo+IC0tLSBhL2luY2x1 ZGUvZHJtL2RybV9jcnRjLmgKPiArKysgYi9pbmNsdWRlL2RybS9kcm1fY3J0Yy5oCj4gQEAgLTE2 OCw2ICsxNjgsMTEgQEAgc3RydWN0IGRybV9jcnRjX3N0YXRlIHsKPiAgCSAqIGRyaXZlcnMgdG8g c3RlZXIgdGhlIGF0b21pYyBjb21taXQgY29udHJvbCBmbG93Lgo+ICAJICovCj4gIAlib29sIGNv bG9yX21nbXRfY2hhbmdlZCA6IDE7Cj4gKwkvKioKPiArCSAqIEBiZ2NvbG9yX2NoYW5nZWQ6IEJh Y2tncm91bmQgY29sb3IgdmFsdWUgaGFzIGNoYW5nZWQuICBVc2VkIGJ5Cj4gKwkgKiBkcml2ZXJz IHRvIHN0ZWVyIHRoZSBhdG9taWMgY29tbWl0IGNvbnRyb2wgZmxvdy4KPiArCSAqLwo+ICsJYm9v bCBiZ2NvbG9yX2NoYW5nZWQgOiAxOwo+ICAKPiAgCS8qKgo+ICAJICogQG5vX3ZibGFuazoKPiBA QCAtMjc0LDYgKzI3OSwxOCBAQCBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgewo+ICAJICovCj4gIAlz dHJ1Y3QgZHJtX3Byb3BlcnR5X2Jsb2IgKmdhbW1hX2x1dDsKPiAgCj4gKwkvKioKPiArCSAqIEBi YWNrZ3JvdW5kX2NvbG9yOgo+ICsJICoKPiArCSAqIFJHQiB2YWx1ZSByZXByZXNlbnRpbmcgdGhl IHBpcGUncyBiYWNrZ3JvdW5kIGNvbG9yLiAgVGhlIGJhY2tncm91bmQKPiArCSAqIGNvbG9yIChh a2EgImNhbnZhcyBjb2xvciIpIG9mIGEgcGlwZSBpcyB0aGUgY29sb3IgdGhhdCB3aWxsIGJlIHVz ZWQKPiArCSAqIGZvciBwaXhlbHMgbm90IGNvdmVyZWQgYnkgYSBwbGFuZSwgb3IgY292ZXJlZCBi eSB0cmFuc3BhcmVudCBwaXhlbHMKPiArCSAqIG9mIGEgcGxhbmUuICBUaGUgdmFsdWUgaGVyZSBz aG91bGQgYmUgYnVpbHQgdmlhIGRybV9yZ2JhKCk7Cj4gKwkgKiBpbmRpdmlkdWFsIGNvbG9yIGNv bXBvbmVudHMgY2FuIGJlIGV4dHJhY3RlZCB3aXRoIGRlc2lyZWQgcHJlY2lzaW9uCj4gKwkgKiB2 aWEgdGhlIERSTV9SR0JBXyooKSBtYWNyb3MuCj4gKwkgKi8KPiArCXU2NCBiYWNrZ3JvdW5kX2Nv bG9yOwoKbml0OiBmd2l3LCBJIGZpbmQgaXQncyBtb3JlIHVzZWZ1bCBrZWVwIHRoZSBwcm9wZXJ0 eSBuYW1lIGNvbnNpc3RlbnQgdGhyb3VnaG91dAp0aGUgY29kZWJhc2UgZm9yIGVhc2llciBncmVw cGluZy4gU28gZWl0aGVyIGV4cGFuZCB0aGUgb3RoZXJzIGZyb20gYmdjb2xvciB0bwpiYWNrZ3Jv dW5kX2NvbG9yLCBvciB2aWNlIHZlcnNhLgoKPiArCj4gIAkvKioKPiAgCSAqIEB0YXJnZXRfdmJs YW5rOgo+ICAJICoKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtX21vZGVfY29uZmlnLmgg Yi9pbmNsdWRlL2RybS9kcm1fbW9kZV9jb25maWcuaAo+IGluZGV4IDkyOGU0MTcyYTBiYi4uYzNm NTdhOWU1YjMxIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9tb2RlX2NvbmZpZy5oCj4g KysrIGIvaW5jbHVkZS9kcm0vZHJtX21vZGVfY29uZmlnLmgKPiBAQCAtODA3LDYgKzgwNywxMSBA QCBzdHJ1Y3QgZHJtX21vZGVfY29uZmlnIHsKPiAgCSAqLwo+ICAJc3RydWN0IGRybV9wcm9wZXJ0 eSAqd3JpdGViYWNrX291dF9mZW5jZV9wdHJfcHJvcGVydHk7Cj4gIAo+ICsJLyoqCj4gKwkgKiBA Ymdjb2xvcl9wcm9wZXJ0eTogUkdCQSBiYWNrZ3JvdW5kIGNvbG9yIGZvciBDUlRDLgo+ICsJICov Cj4gKwlzdHJ1Y3QgZHJtX3Byb3BlcnR5ICpiZ2NvbG9yX3Byb3BlcnR5Owo+ICsKPiAgCS8qIGR1 bWIgaW9jdGwgcGFyYW1ldGVycyAqLwo+ICAJdWludDMyX3QgcHJlZmVycmVkX2RlcHRoLCBwcmVm ZXJfc2hhZG93Owo+ICAJYm9vbCBxdWlya19hZGRmYl9wcmVmZXJfeGJncl8zMGJwcDsKPiBkaWZm IC0tZ2l0IGEvaW5jbHVkZS91YXBpL2RybS9kcm1fbW9kZS5oIGIvaW5jbHVkZS91YXBpL2RybS9k cm1fbW9kZS5oCj4gaW5kZXggZDNlMGZlMzFlZmM1Li42NmUyZTJjMjYzMGUgMTAwNjQ0Cj4gLS0t IGEvaW5jbHVkZS91YXBpL2RybS9kcm1fbW9kZS5oCj4gKysrIGIvaW5jbHVkZS91YXBpL2RybS9k cm1fbW9kZS5oCj4gQEAgLTg4OCw2ICs4ODgsMzIgQEAgc3RydWN0IGRybV9tb2RlX3Jldm9rZV9s ZWFzZSB7Cj4gIAlfX3UzMiBsZXNzZWVfaWQ7Cj4gIH07Cj4gIAo+ICsvKgo+ICsgKiBQdXQgUkdC QSB2YWx1ZXMgaW50byBhIHN0YW5kYXJkIDY0LWJpdCByZXByZXNlbnRhdGlvbiB0aGF0IGNhbiBi ZSB1c2VkCj4gKyAqIGZvciBpb2N0bCBwYXJhbWV0ZXJzLCBpbnRlci1kcml2ZXIgY29tbW11bmlj YXRpb24sIGV0Yy4gIElmIHRoZSBjb21wb25lbnQKPiArICogdmFsdWVzIGJlaW5nIHByb3ZpZGVk IGNvbnRhaW4gbGVzcyB0aGFuIDE2IGJpdHMgb2YgcHJlY2lzaW9uLCB0aGV5J2xsCj4gKyAqIGJl IHNoaWZ0ZWQgaW50byB0aGUgbW9zdCBzaWduaWZpY2FudCBiaXRzLgo+ICsgKi8KPiArc3RhdGlj IGlubGluZSBfX3U2NAo+ICtkcm1fcmdiYShfX3U4IGJwYywgX191MTYgcmVkLCBfX3UxNiBncmVl biwgX191MTYgYmx1ZSwgX191MTYgYWxwaGEpCj4gK3sKPiArCWludCBtc2Jfc2hpZnQgPSAxNiAt IGJwYzsKPiArCj4gKwlyZXR1cm4gKF9fdTY0KWFscGhhIDw8IG1zYl9zaGlmdCA8PCA0OCB8Cj4g KwkgICAgICAgKF9fdTY0KWJsdWUgIDw8IG1zYl9zaGlmdCA8PCAzMiB8Cj4gKwkgICAgICAgKF9f dTY0KWdyZWVuIDw8IG1zYl9zaGlmdCA8PCAxNiB8Cj4gKwkgICAgICAgKF9fdTY0KXJlZCAgIDw8 IG1zYl9zaGlmdDsKPiArfQo+ICsKPiArLyoKPiArICogRXh0cmFjdCB0aGUgc3BlY2lmaWVkIG51 bWJlciBvZiBiaXRzIG9mIGEgc3BlY2lmaWMgY29sb3IgY29tcG9uZW50IGZyb20gYQo+ICsgKiBz dGFuZGFyZCA2NC1iaXQgUkdCQSB2YWx1ZS4KPiArICovCj4gKyNkZWZpbmUgRFJNX1JHQkFfUkVE KGMsIG51bWJpdHMpICAgKF9fdTE2KSgoYyAmIDB4RkZGRnVsbCkgICAgID4+ICgxNi1udW1iaXRz KSkKPiArI2RlZmluZSBEUk1fUkdCQV9HUkVFTihjLCBudW1iaXRzKSAoX191MTYpKChjICYgMHhG RkZGdWxsPDwxNikgPj4gKDMyLW51bWJpdHMpKQo+ICsjZGVmaW5lIERSTV9SR0JBX0JMVUUoYywg bnVtYml0cykgIChfX3UxNikoKGMgJiAweEZGRkZ1bGw8PDMyKSA+PiAoNDgtbnVtYml0cykpCj4g KyNkZWZpbmUgRFJNX1JHQkFfQUxQSEEoYywgbnVtYml0cykgKF9fdTE2KSgoYyAmIDB4RkZGRnVs bDw8NDgpID4+ICg2NC1udW1iaXRzKSkKPiArCj4gICNpZiBkZWZpbmVkKF9fY3BsdXNwbHVzKQo+ ICB9Cj4gICNlbmRpZgo+IC0tIAo+IDIuMTQuNAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gClNlYW4gUGF1bCwgU29mdHdhcmUgRW5n aW5lZXIsIEdvb2dsZSAvIENocm9taXVtIE9TCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo=