From: Tom Rini Date: Fri, 9 Nov 2018 13:43:22 -0500 Subject: [U-Boot] [U-Boot, v2, 12/23] spl: Print a message if we are unable to load an image In-Reply-To: <20181002112253.202931-13-sjg@chromium.org> References: <20181002112253.202931-13-sjg@chromium.org> Message-ID: <20181109184322.GA11247@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Oct 02, 2018 at 05:22:42AM -0600, Simon Glass wrote: > It can confusing when U-Boot SPL hangs for no obvious reason, when it is > unable to load U-Boot. Add a message to indicate the cause. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > common/spl/spl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/common/spl/spl.c b/common/spl/spl.c > index 396c42e1e1b..512141c4139 100644 > --- a/common/spl/spl.c > +++ b/common/spl/spl.c > @@ -485,6 +485,7 @@ static int boot_from_devices(struct spl_image_info *spl_image, > return 0; > } > } > + puts(SPL_TPL_PROMPT "No more boot devices\n"); > > return -ENODEV; > } Don't we have a similar debug() statement around this part of the boot flow? It is annoying but I also think we ended up dropping it due to binary size issues. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: