Date: Mon, 12 Nov 2018 11:52:28 -0500 From: Steven Rostedt Subject: Re: [PATCH 1/1] stackleak: Disable ftrace for stackleak.c Message-ID: <20181112115228.1c747426@vmware.local.home> In-Reply-To: <97842534.3842.1542034409326.JavaMail.zimbra@efficios.com> References: <1541887530-16610-1-git-send-email-alex.popov@linux.com> <20181110183011.2290fc20@gandalf.local.home> <20181111205351.1874bb1e@vmware.local.home> <20181112115058.39e98750750c91eeb349cfdf@kernel.org> <97842534.3842.1542034409326.JavaMail.zimbra@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit To: Mathieu Desnoyers Cc: Masami Hiramatsu , Alexander Popov , kernel-hardening , Kees Cook , Jann Horn , Ingo Molnar , Andy Lutomirski , Joerg Roedel , Borislav Petkov , Thomas Gleixner , Dave Hansen , Peter Zijlstra , Jan Kara , Dan Williams , Masahiro Yamada , x86 , linux-kernel List-ID: On Mon, 12 Nov 2018 09:53:29 -0500 (EST) Mathieu Desnoyers wrote: > Just to clarify: AFAIU you guys are recommending to add _both_ a "notrace" > annotation to stackleak_erase() _and_ a NOKPROBE_SYMBOL(stackleak_erase), > so neither function tracing nor kprobes can hook on that function. Correct. -- Steve