Return-Path: Received: from verein.lst.de ([213.95.11.211]:50797 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728124AbeKQCLt (ORCPT ); Fri, 16 Nov 2018 21:11:49 -0500 Date: Fri, 16 Nov 2018 16:58:53 +0100 From: Christoph Hellwig To: Carlos Maiolino Cc: linux-fsdevel@vger.kernel.org, sandeen@redhat.com, hch@lst.de, david@fromorbit.com, darrick.wong@oracle.com Subject: Re: [PATCH 16/20] fibmap: Use bmap instead of ->bmap method in ioctl_fibmap Message-ID: <20181116155853.GJ15119@lst.de> References: <20181030131823.29040-1-cmaiolino@redhat.com> <20181030131823.29040-17-cmaiolino@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181030131823.29040-17-cmaiolino@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > + error = bmap(inode, (sector_t *)&block); You can't cast and int * to a sector_t * without causing problems. You'll need a local variable of type sector_t that the value gets assigned to and read back from instead. Also shouldn't this patch be earlier in the series?