Date: Wed, 21 Nov 2018 10:34:43 +0100 (CET) Message-Id: <201811210934.wAL9YhYM092344@...2054...> From: Gert Doering In-Reply-To: <1541757573-30178-1-git-send-email-lstipakov@...277...> References: <1541757573-30178-1-git-send-email-lstipakov@...277...> Subject: [Openvpn-devel] [PATCH applied] Re: Remove extra token after #endif List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Lev Stipakov Cc: openvpn-devel@lists.sourceforge.net Acked-by: Gert Doering Thanks. Regarding Christian's comment about "#endif" vs. "#endif /* ENABLE_CRYPTO /*" - well, we have both in our tree, so neither is "correct" or "wrong". For such a short #ifdef/#endif span, I'd see it as optional because the corresponding #ifdef is easily spotted. For something spanning more code, possibly nested #ifdef, a comment after the #endif would definitely be better, though. Your patch has been applied to the release/2.4 branch. commit ca962f3837ab05b0e8a4382960391f289497eaa2 Author: Lev Stipakov Date: Fri Nov 9 11:59:33 2018 +0200 Remove extra token after #endif Signed-off-by: Lev Stipakov Acked-by: Gert Doering Message-Id: <1541757573-30178-1-git-send-email-lstipakov@...277...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17883.html Signed-off-by: Gert Doering -- kind regards, Gert Doering