From: Christoph Hellwig Date: Wed, 21 Nov 2018 15:00:27 +0100 Subject: [Cluster-devel] [PATCH V11 10/19] block: loop: pass multi-page bvec to iov_iter In-Reply-To: <20181121032327.8434-11-ming.lei@redhat.com> References: <20181121032327.8434-1-ming.lei@redhat.com> <20181121032327.8434-11-ming.lei@redhat.com> Message-ID: <20181121140027.GA2323@lst.de> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 1ad6eafc43f2..a281b6737b61 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -805,6 +805,10 @@ struct req_iterator { > __rq_for_each_bio(_iter.bio, _rq) \ > bio_for_each_segment(bvl, _iter.bio, _iter.iter) > > +#define rq_for_each_bvec(bvl, _rq, _iter) \ > + __rq_for_each_bio(_iter.bio, _rq) \ > + bio_for_each_bvec(bvl, _iter.bio, _iter.iter) > + I think this should go into the patch adding bio_for_each_bvec and friends. Otherwise looks fine: Reviewed-by: Christoph Hellwig