From: Daniel Vetter Subject: Re: [PATCH v2] drm: set is_master to 0 upon drm_new_set_master() failure Date: Thu, 22 Nov 2018 09:58:03 +0100 Message-ID: <20181122085803.GY4266@phenom.ffwll.local> References: <20181118235720.3150-1-sergio@correia.cc> <20181122053329.2692-1-sergio@correia.cc> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9FD4D6E227 for ; Thu, 22 Nov 2018 08:58:07 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id r27so7085393eda.0 for ; Thu, 22 Nov 2018 00:58:07 -0800 (PST) Content-Disposition: inline In-Reply-To: <20181122053329.2692-1-sergio@correia.cc> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sergio Correia Cc: maxime.ripard@bootlin.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, sean@poorly.run List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBOb3YgMjIsIDIwMTggYXQgMDI6MzM6MjlBTSAtMDMwMCwgU2VyZ2lvIENvcnJlaWEg d3JvdGU6Cj4gV2hlbiBkcm1fbmV3X3NldF9tYXN0ZXIoKSBmYWlscywgc2V0IGlzX21hc3RlciB0 byAwLCB0byBwcmV2ZW50IGEKPiBwb3NzaWJsZSBOVUxMIHBvaW50ZXIgZGVyZWYuCj4gCj4gSGVy ZSBpcyBhIHByb2JsZW1hdGljIGZsb3c6IHdlIGNoZWNrIGlzX21hc3RlciBpbiBkcm1faXNfY3Vy cmVudF9tYXN0ZXIoKSwKPiB0aGVuIHByb2NlZWQgdG8gY2FsbCBkcm1fbGVhc2Vfb3duZXIoKSBw YXNzaW5nIG1hc3Rlci4gSWYgd2UgZG8gbm90IHJlc3RvcmUKPiBpc19tYXN0ZXIgc3RhdHVzIHdo ZW4gZHJtX25ld19zZXRfbWFzdGVyKCkgZmFpbHMsIHdlIG1heSBoYXZlIGEgc2l0dWF0aW9uCj4g aW4gd2hpY2ggaXNfbWFzdGVyIHdpbGwgYmUgMSBhbmQgbWFzdGVyIGl0c2VsZiwgTlVMTCwgbGVh ZGluZyB0byB0aGUgZGVyZWYKPiBvZiBhIE5VTEwgcG9pbnRlciBpbiBkcm1fbGVhc2Vfb3duZXIo KS4KPiAKPiBUaGlzIGZpeGVzIHRoZSBmb2xsb3dpbmcgT09QUywgb2JzZXJ2ZWQgb24gYW4gQXJj aExpbnV4IHJ1bm5pbmcgYSA0LjE5LjIKPiBrZXJuZWw6Cj4gCj4gWyAgIDk3LjgwNDI4Ml0gQlVH OiB1bmFibGUgdG8gaGFuZGxlIGtlcm5lbCBOVUxMIHBvaW50ZXIgZGVyZWZlcmVuY2UgYXQgMDAw MDAwMDAwMDAwMDA4MAo+IFsgICA5Ny44MDcyMjRdIFBHRCAwIFA0RCAwCj4gWyAgIDk3LjgwNzIy NF0gT29wczogMDAwMCBbIzFdIFBSRUVNUFQgU01QIE5PUFRJCj4gWyAgIDk3LjgwNzIyNF0gQ1BV OiAwIFBJRDogMTM0OCBDb21tOiB4ZndtNCBUYWludGVkOiBQICAgICAgICAgICBPRSAgICAgNC4x OS4yLWFyY2gxLTEtQVJDSCAjMQo+IFsgICA5Ny44MDcyMjRdIEhhcmR3YXJlIG5hbWU6IFRvIEJl IEZpbGxlZCBCeSBPLkUuTS4gVG8gQmUgRmlsbGVkIEJ5IE8uRS5NLi9BQjM1MCBQcm80LCBCSU9T IFA1LjEwIDEwLzE2LzIwMTgKPiBbICAgOTcuODA3MjI0XSBSSVA6IDAwMTA6ZHJtX2xlYXNlX293 bmVyKzB4ZC8weDIwIFtkcm1dCj4gWyAgIDk3LjgwNzIyNF0gQ29kZTogODMgYzQgMTggNWIgNWQg YzMgYjggZWEgZmYgZmYgZmYgZWIgZTIgYjggZWQgZmYgZmYgZmYgZWIgZGIgZTggYjQgY2EgNjgg ZmIgMGYgMWYgNDAgMDAgMGYgMWYgNDQgMDAgMDAgNDggODkgZjggZWIgMDMgNDggODkgZDAgPDQ4 PiA4YiA5MCA4MCAwMCAwMCAwMCA0OCA4NSBkMiA3NSBmMSBjMyA2NiAwZiAxZiA0NCAwMCAwMCAw ZiAxZiA0NAo+IFsgICA5Ny44MDcyMjRdIFJTUDogMDAxODpmZmZmYjhjZjA4ZTA3YmIwIEVGTEFH UzogMDAwMTAyMDIKPiBbICAgOTcuODA3MjI0XSBSQVg6IDAwMDAwMDAwMDAwMDAwMDAgUkJYOiBm ZmZmOWNmMGYyNTg2YzAwIFJDWDogZmZmZjljZjBmMjU4NmM4OAo+IFsgICA5Ny44MDcyMjRdIFJE WDogZmZmZjljZjBkZGJkODAwMCBSU0k6IDAwMDAwMDAwMDAwMDAwMDAgUkRJOiAwMDAwMDAwMDAw MDAwMDAwCj4gWyAgIDk3LjgwNzIyNF0gUkJQOiBmZmZmOWNmMTA0MGU5ODAwIFIwODogMDAwMDAw MDAwMDAwMDAwMCBSMDk6IDAwMDAwMDAwMDAwMDAwMDAKPiBbICAgOTcuODA3MjI0XSBSMTA6IGZm ZmZkZWIzMGZkNWQ2ODAgUjExOiBmZmZmZGViMzBmNWQ2ODA4IFIxMjogZmZmZjljZjEwNDBlOTg4 OAo+IFsgICA5Ny44MDcyMjRdIFIxMzogMDAwMDAwMDAwMDAwMDAwMCBSMTQ6IGRlYWQwMDAwMDAw MDAyMDAgUjE1OiBmZmZmOWNmMGYyNTg2Y2M4Cj4gWyAgIDk3LjgwNzIyNF0gRlM6ICAwMDAwN2Y0 MTQ1NTEzMTgwKDAwMDApIEdTOmZmZmY5Y2YxMGVhMDAwMDAoMDAwMCkga25sR1M6MDAwMDAwMDAw MDAwMDAwMAo+IFsgICA5Ny44MDcyMjRdIENTOiAgMDAxMCBEUzogMDAwMCBFUzogMDAwMCBDUjA6 IDAwMDAwMDAwODAwNTAwMzMKPiBbICAgOTcuODA3MjI0XSBDUjI6IDAwMDAwMDAwMDAwMDAwODAg Q1IzOiAwMDAwMDAwM2Q3NTQ4MDAwIENSNDogMDAwMDAwMDAwMDM0MDZmMAo+IFsgICA5Ny44MDcy MjRdIENhbGwgVHJhY2U6Cj4gWyAgIDk3LjgwNzIyNF0gIGRybV9pc19jdXJyZW50X21hc3Rlcisw eDFhLzB4MzAgW2RybV0KPiBbICAgOTcuODA3MjI0XSAgZHJtX21hc3Rlcl9yZWxlYXNlKzB4M2Uv MHgxMzAgW2RybV0KPiBbICAgOTcuODA3MjI0XSAgZHJtX2ZpbGVfZnJlZS5wYXJ0LjArMHgyYmUv MHgyZDAgW2RybV0KPiBbICAgOTcuODA3MjI0XSAgZHJtX29wZW4rMHgxYmEvMHgxZTAgW2RybV0K PiBbICAgOTcuODA3MjI0XSAgZHJtX3N0dWJfb3BlbisweGFmLzB4ZTAgW2RybV0KPiBbICAgOTcu ODA3MjI0XSAgY2hyZGV2X29wZW4rMHhhMy8weDFiMAo+IFsgICA5Ny44MDcyMjRdICA/IGNkZXZf cHV0LnBhcnQuMCsweDIwLzB4MjAKPiBbICAgOTcuODA3MjI0XSAgZG9fZGVudHJ5X29wZW4rMHgx MzIvMHgzNDAKPiBbICAgOTcuODA3MjI0XSAgcGF0aF9vcGVuYXQrMHgyZDEvMHgxNGUwCj4gWyAg IDk3LjgwNzIyNF0gID8gbWVtX2Nncm91cF9jb21taXRfY2hhcmdlKzB4N2EvMHg1MjAKPiBbICAg OTcuODA3MjI0XSAgZG9fZmlscF9vcGVuKzB4OTMvMHgxMDAKPiBbICAgOTcuODA3MjI0XSAgPyBf X2NoZWNrX29iamVjdF9zaXplKzB4MTAyLzB4MTg5Cj4gWyAgIDk3LjgwNzIyNF0gID8gX3Jhd19z cGluX3VubG9jaysweDE2LzB4MzAKPiBbICAgOTcuODA3MjI0XSAgZG9fc3lzX29wZW4rMHgxODYv MHgyMTAKPiBbICAgOTcuODA3MjI0XSAgZG9fc3lzY2FsbF82NCsweDViLzB4MTcwCj4gWyAgIDk3 LjgwNzIyNF0gIGVudHJ5X1NZU0NBTExfNjRfYWZ0ZXJfaHdmcmFtZSsweDQ0LzB4YTkKPiBbICAg OTcuODA3MjI0XSBSSVA6IDAwMzM6MHg3ZjQxNDdiMDc5NzYKPiBbICAgOTcuODA3MjI0XSBDb2Rl OiA4OSA1NCAyNCAwOCBlOCA3YiBmNCBmZiBmZiA4YiA3NCAyNCAwYyA0OCA4YiAzYyAyNCA0MSA4 OSBjMCA0NCA4YiA1NCAyNCAwOCBiOCAwMSAwMSAwMCAwMCA4OSBmMiA0OCA4OSBmZSBiZiA5YyBm ZiBmZiBmZiAwZiAwNSA8NDg+IDNkIDAwIGYwIGZmIGZmIDc3IDMwIDQ0IDg5IGM3IDg5IDQ0IDI0 IDA4IGU4IGE2IGY0IGZmIGZmIDhiIDQ0Cj4gWyAgIDk3LjgwNzIyNF0gUlNQOiAwMDJiOjAwMDA3 ZmZjY2VkOTZjYTAgRUZMQUdTOiAwMDAwMDI5MyBPUklHX1JBWDogMDAwMDAwMDAwMDAwMDEwMQo+ IFsgICA5Ny44MDcyMjRdIFJBWDogZmZmZmZmZmZmZmZmZmZkYSBSQlg6IDAwMDA1NjE5ZDUwMzdm ODAgUkNYOiAwMDAwN2Y0MTQ3YjA3OTc2Cj4gWyAgIDk3LjgwNzIyNF0gUkRYOiAwMDAwMDAwMDAw MDAwMDAyIFJTSTogMDAwMDU2MTlkNDZiOTY5YyBSREk6IDAwMDAwMDAwZmZmZmZmOWMKPiBbICAg OTguMDQwMDM5XSBSQlA6IDAwMDAwMDAwMDAwMDAwMjQgUjA4OiAwMDAwMDAwMDAwMDAwMDAwIFIw OTogMDAwMDAwMDAwMDAwMDAwMAo+IFsgICA5OC4wNDAwMzldIFIxMDogMDAwMDAwMDAwMDAwMDAw MCBSMTE6IDAwMDAwMDAwMDAwMDAyOTMgUjEyOiAwMDAwMDAwMDAwMDAwMDI0Cj4gWyAgIDk4LjA0 MDAzOV0gUjEzOiAwMDAwMDAwMDAwMDAwMDEyIFIxNDogMDAwMDU2MTlkNTAzNTk1MCBSMTU6IDAw MDAwMDAwMDAwMDAwMTIKPiBbICAgOTguMDQwMDM5XSBNb2R1bGVzIGxpbmtlZCBpbjogbmN0Njc3 NSBod21vbl92aWQgYWxnaWZfc2tjaXBoZXIgYWZfYWxnIG5sc19pc284ODU5XzEgbmxzX2NwNDM3 IHZmYXQgZmF0IHV2Y3ZpZGVvIHZpZGVvYnVmMl92bWFsbG9jIHZpZGVvYnVmMl9tZW1vcHMgdmlk ZW9idWYyX3Y0bDIgdmlkZW9idWYyX2NvbW1vbiBhcmM0IHZpZGVvZGV2IG1lZGlhIHNuZF91c2Jf YXVkaW8gc25kX2hkYV9jb2RlY19oZG1pIHNuZF91c2JtaWRpX2xpYiBzbmRfcmF3bWlkaSBzbmRf c2VxX2RldmljZSBtb3VzZWRldiBpbnB1dF9sZWRzIGl3bG12bSBtYWM4MDIxMSBzbmRfaGRhX2Nv ZGVjX3JlYWx0ZWsgc25kX2hkYV9jb2RlY19nZW5lcmljIHNuZF9oZGFfaW50ZWwgc25kX2hkYV9j b2RlYyBlZGFjX21jZV9hbWQga3ZtX2FtZCBzbmRfaGRhX2NvcmUga3ZtIGl3bHdpZmkgc25kX2h3 ZGVwIHI4MTY5IHdtaV9ibW9mIGNmZzgwMjExIHNuZF9wY20gaXJxYnlwYXNzIHNuZF90aW1lciBz bmQgbGlicGh5IHNvdW5kY29yZSBwaW5jdHJsX2FtZCByZmtpbGwgcGNzcGtyIHNwNTEwMF90Y28g ZXZkZXYgZ3Bpb19hbWRwdCBrMTB0ZW1wIG1hY19oaWQgaTJjX3BpaXg0IHdtaSBwY2NfY3B1ZnJl cSBhY3BpX2NwdWZyZXEgdmJveG5ldGZsdChPRSkgdmJveG5ldGFkcChPRSkgdmJveHBjaShPRSkg dmJveGRydihPRSkgbXNyIHNnIGNyeXB0b191c2VyIGlwX3RhYmxlcyB4X3RhYmxlcyBleHQ0IGNy YzMyY19nZW5lcmljIGNyYzE2IG1iY2FjaGUgamJkMiBmc2NyeXB0byB1YXMgdXNiX3N0b3JhZ2Ug ZG1fY3J5cHQgaGlkX2dlbmVyaWMgdXNiaGlkIGhpZAo+IFsgICA5OC4wNDAwMzldICBkbV9tb2Qg cmFpZDEgbWRfbW9kIHNkX21vZCBjcmN0MTBkaWZfcGNsbXVsIGNyYzMyX3BjbG11bCBjcmMzMmNf aW50ZWwgZ2hhc2hfY2xtdWxuaV9pbnRlbCBwY2JjIGFoY2kgbGliYWhjaSBhZXNuaV9pbnRlbCBh ZXNfeDg2XzY0IGxpYmF0YSBjcnlwdG9fc2ltZCBjcnlwdGQgZ2x1ZV9oZWxwZXIgY2NwIHhoY2lf cGNpIHJuZ19jb3JlIHNjc2lfbW9kIHhoY2lfaGNkIG52aWRpYV9kcm0oUE9FKSBkcm1fa21zX2hl bHBlciBzeXNjb3B5YXJlYSBzeXNmaWxscmVjdCBzeXNpbWdibHQgZmJfc3lzX2ZvcHMgZHJtIGFn cGdhcnQgbnZpZGlhX3V2bShQT0UpIG52aWRpYV9tb2Rlc2V0KFBPRSkgbnZpZGlhKFBPRSkgaXBt aV9kZXZpbnRmIGlwbWlfbXNnaGFuZGxlcgo+IFsgICA5OC4wNDAwMzldIENSMjogMDAwMDAwMDAw MDAwMDA4MAo+IFsgICA5OC4wNDAwMzldIC0tLVsgZW5kIHRyYWNlIDNiNjUwOTNiNmZlNjJiMmYg XS0tLQo+IFsgICA5OC4wNDAwMzldIFJJUDogMDAxMDpkcm1fbGVhc2Vfb3duZXIrMHhkLzB4MjAg W2RybV0KPiBbICAgOTguMDQwMDM5XSBDb2RlOiA4MyBjNCAxOCA1YiA1ZCBjMyBiOCBlYSBmZiBm ZiBmZiBlYiBlMiBiOCBlZCBmZiBmZiBmZiBlYiBkYiBlOCBiNCBjYSA2OCBmYiAwZiAxZiA0MCAw MCAwZiAxZiA0NCAwMCAwMCA0OCA4OSBmOCBlYiAwMyA0OCA4OSBkMCA8NDg+IDhiIDkwIDgwIDAw IDAwIDAwIDQ4IDg1IGQyIDc1IGYxIGMzIDY2IDBmIDFmIDQ0IDAwIDAwIDBmIDFmIDQ0Cj4gWyAg IDk4LjA0MDAzOV0gUlNQOiAwMDE4OmZmZmZiOGNmMDhlMDdiYjAgRUZMQUdTOiAwMDAxMDIwMgo+ IFsgICA5OC4wNDAwMzldIFJBWDogMDAwMDAwMDAwMDAwMDAwMCBSQlg6IGZmZmY5Y2YwZjI1ODZj MDAgUkNYOiBmZmZmOWNmMGYyNTg2Yzg4Cj4gWyAgIDk4LjA0MDAzOV0gUkRYOiBmZmZmOWNmMGRk YmQ4MDAwIFJTSTogMDAwMDAwMDAwMDAwMDAwMCBSREk6IDAwMDAwMDAwMDAwMDAwMDAKPiBbICAg OTguMDQwMDM5XSBSQlA6IGZmZmY5Y2YxMDQwZTk4MDAgUjA4OiAwMDAwMDAwMDAwMDAwMDAwIFIw OTogMDAwMDAwMDAwMDAwMDAwMAo+IFsgICA5OC4wNDAwMzldIFIxMDogZmZmZmRlYjMwZmQ1ZDY4 MCBSMTE6IGZmZmZkZWIzMGY1ZDY4MDggUjEyOiBmZmZmOWNmMTA0MGU5ODg4Cj4gWyAgIDk4LjA0 MDAzOV0gUjEzOiAwMDAwMDAwMDAwMDAwMDAwIFIxNDogZGVhZDAwMDAwMDAwMDIwMCBSMTU6IGZm ZmY5Y2YwZjI1ODZjYzgKPiBbICAgOTguMDQwMDM5XSBGUzogIDAwMDA3ZjQxNDU1MTMxODAoMDAw MCkgR1M6ZmZmZjljZjEwZWEwMDAwMCgwMDAwKSBrbmxHUzowMDAwMDAwMDAwMDAwMDAwCj4gWyAg IDk4LjA0MDAzOV0gQ1M6ICAwMDEwIERTOiAwMDAwIEVTOiAwMDAwIENSMDogMDAwMDAwMDA4MDA1 MDAzMwo+IFsgICA5OC4wNDAwMzldIENSMjogMDAwMDAwMDAwMDAwMDA4MCBDUjM6IDAwMDAwMDAz ZDc1NDgwMDAgQ1I0OiAwMDAwMDAwMDAwMzQwNmYwCj4gCj4gU2lnbmVkLW9mZi1ieTogU2VyZ2lv IENvcnJlaWEgPHNlcmdpb0Bjb3JyZWlhLmNjPgo+IC0tLQo+IHYxIC0+IHYyOgo+IDEpIGZvcm1l ciB0aXRsZTogZHJtOiByZXN0b3JlIGlzX21hc3RlciB1cG9uIGZhaWx1cmUgaW4KPiBkcm1fbmV3 X3NldF9tYXN0ZXIoKQo+IDIpIGFkZCBXQVJOX09OIGF0IHRoZSBiZWdpbm5pbmcgb2YgZHJtX25l d19zZXRfbWFzdGVyKCkKPiAzKSBzZXQgaXNfbWFzdGVyIHVuY29uZGl0aW9uYWxseSB0byAwLCB1 cG9uIGZhaWx1cmUgaW4KPiBkcm1fbmV3X3NldF9tYXN0ZXIoKQoKVGhhbmtzIGZvciByZXNwaW5u aW5nLCBtZXJnZWQgdG8gZHJtLW1pc2MtZml4ZXMgd2l0aCBhIGNjOiBzdGFibGUuCi1EYW5pZWwK Cj4gCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXV0aC5jIHwgMiArKwo+ICAxIGZpbGUgY2hhbmdl ZCwgMiBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f YXV0aC5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdXRoLmMKPiBpbmRleCBkOWMwZjc1NzM5MDUu LjE2NjljNDJjNDBlZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F1dGguYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXV0aC5jCj4gQEAgLTE0Miw2ICsxNDIsNyBAQCBz dGF0aWMgaW50IGRybV9uZXdfc2V0X21hc3RlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1 Y3QgZHJtX2ZpbGUgKmZwcml2KQo+ICAKPiAgCWxvY2tkZXBfYXNzZXJ0X2hlbGRfb25jZSgmZGV2 LT5tYXN0ZXJfbXV0ZXgpOwo+ICAKPiArCVdBUk5fT04oZnByaXYtPmlzX21hc3Rlcik7Cj4gIAlv bGRfbWFzdGVyID0gZnByaXYtPm1hc3RlcjsKPiAgCWZwcml2LT5tYXN0ZXIgPSBkcm1fbWFzdGVy X2NyZWF0ZShkZXYpOwo+ICAJaWYgKCFmcHJpdi0+bWFzdGVyKSB7Cj4gQEAgLTE3MCw2ICsxNzEs NyBAQCBzdGF0aWMgaW50IGRybV9uZXdfc2V0X21hc3RlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 LCBzdHJ1Y3QgZHJtX2ZpbGUgKmZwcml2KQo+ICAJLyogZHJvcCByZWZlcmVuY2VzIGFuZCByZXN0 b3JlIG9sZCBtYXN0ZXIgb24gZmFpbHVyZSAqLwo+ICAJZHJtX21hc3Rlcl9wdXQoJmZwcml2LT5t YXN0ZXIpOwo+ICAJZnByaXYtPm1hc3RlciA9IG9sZF9tYXN0ZXI7Cj4gKwlmcHJpdi0+aXNfbWFz dGVyID0gMDsKPiAgCj4gIAlyZXR1cm4gcmV0Owo+ICB9Cj4gLS0gCj4gMi4xOS4xCj4gCgotLSAK RGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDov L2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg==