Date: Thu, 22 Nov 2018 10:33:27 +0100
From: Jan Kara <jack@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>,
        Matthew Bobrowski <mbobrowski@mbobrowski.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v2 2/5] fsnotify: annotate filename events
Message-ID: <20181122093327.GA9840@quack2.suse.cz>
References: <20181114174344.17530-1-amir73il@gmail.com>
 <20181114174344.17530-3-amir73il@gmail.com>
 <20181120115901.GH8842@quack2.suse.cz>
 <CAOQ4uxgh8qZJkU5ZddpbKqket3rJzgeoJSoSrApaN_0p2LSikQ@mail.gmail.com>
 <20181121131830.GB28182@quack2.suse.cz>
 <CAOQ4uxhescuc0M8XQ8F-33NjgqabnVNdHdHRvpq1wUOwc4VTww@mail.gmail.com>
 <CAOQ4uxjYQTWbaRSNpnmwE-t=VCp3pNCCvD4dEPZRH_A7DRaPXQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOQ4uxjYQTWbaRSNpnmwE-t=VCp3pNCCvD4dEPZRH_A7DRaPXQ@mail.gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org

On Thu 22-11-18 09:45:06, Amir Goldstein wrote:
> > > But we never generate FS_MODIFY|FS_ISDIR events so I don't think there's a
> > > big space for confusion (and I've deliberately used CHANGE instead of
> > > MODIFY to make the distinction even clearer). FWIW
> > > FANOTIFY_DIRENT_MODIFY_EVENTS would also look better than _FILENAME_EVENTS
> > > to me.
> > >
> >
> > Fair enough. I'll change to FANOTIFY_DIRENT_MODIFY_EVENTS
> > and similar named helpers and comments in fsnotify.h.
> >
> 
> On second thought, if you don't object, I will opt for brevity and use:
> FANOTIFY_DIRENT_EVENTS.
> I don't thing that dropping the _MODIFY_ /_change part of the name is
> going to be a source of ambiguity.
> 
> /* Notify this directory about a change in one of its directory entries. */
> static inline int __fsnotify_dirent(struct inode *dir, __u32 mask,
>                                     const unsigned char *file_name, u32 cookie)
> /*
>  * Notify this dentry's parent about a change in the directory entry
>  * associated with this dentry.
>  * Unlike fsnotify_parent(), the event will be reported regardless of the
>  * FS_EVENT_ON_CHILD mask on the parent inode
>  * Safe to call with negative dentry, e.g. from fsnotify_nameremove()
>  */
> static inline int fsnotify_dirent(struct dentry *dentry, __u32 mask)

Fine by me. Thanks!

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR