From: Ming Lei Date: Tue, 27 Nov 2018 10:25:19 +0800 Subject: [Cluster-devel] [PATCH V12 16/20] block: enable multipage bvecs In-Reply-To: <20181126125842.GE6383@lst.de> References: <20181126021720.19471-1-ming.lei@redhat.com> <20181126021720.19471-17-ming.lei@redhat.com> <20181126125842.GE6383@lst.de> Message-ID: <20181127022517.GC25199@ming.t460p> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Nov 26, 2018 at 01:58:42PM +0100, Christoph Hellwig wrote: > > + phys_addr_t vec_end_addr = page_to_phys(bv->bv_page) + > > + bv->bv_offset + bv->bv_len; > > The name is a little confusing, as the real end addr would be -1. Maybe > throw the -1 in here, and adjust for it in the contigous check below? Yeah, it makes sense. thanks, Ming