DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FDB720879
Date:   Wed, 5 Dec 2018 06:40:06 -0800
From:   Christoph Hellwig <hch@infradead.org>
To:     axboe@kernel.dk, bvanassche@acm.org, linux-block@vger.kernel.org
Subject: Re: [PATCH v3] block: add documentation for io_timeout
Message-ID: <20181205144006.GA18123@infradead.org>
References: <20181205141701.GA33910@192.168.3.9>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20181205141701.GA33910@192.168.3.9>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-block-owner@vger.kernel.org
Precedence: bulk

Can you please also send a patch to not show this attribute for
drivers without a timeout handler?  Thanks!

On Wed, Dec 05, 2018 at 10:17:06PM +0800, Weiping Zhang wrote:
> Add documentation for /sys/block/<disk>/queue/io_timeout.
> 
> Signed-off-by: Weiping Zhang <zhangweiping@didiglobal.com>
> ---
>  Documentation/ABI/testing/sysfs-block | 10 ++++++++++
>  Documentation/block/queue-sysfs.txt   |  7 +++++++
>  2 files changed, 17 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-block b/Documentation/ABI/testing/sysfs-block
> index dea212db9df3..f254a374710a 100644
> --- a/Documentation/ABI/testing/sysfs-block
> +++ b/Documentation/ABI/testing/sysfs-block
> @@ -271,3 +271,13 @@ Description:
>  		size of 512B sectors of the zones of the device, with
>  		the eventual exception of the last zone of the device
>  		which may be smaller.
> +
> +What:		/sys/block/<disk>/queue/io_timeout
> +Date:		November 2018
> +Contact:	Weiping Zhang <zhangweiping@didiglobal.com>
> +Description:
> +		io_timeout is a request’s timeouts at block layer in
> +		milliseconds. When the underlying driver starts processing
> +		a request, the generic block layer will start a timer, if
> +		this request cannot be completed in io_timeout milliseconds,
> +		a timeout event will occur.
> diff --git a/Documentation/block/queue-sysfs.txt b/Documentation/block/queue-sysfs.txt
> index 2c1e67058fd3..f0c9bbce73fd 100644
> --- a/Documentation/block/queue-sysfs.txt
> +++ b/Documentation/block/queue-sysfs.txt
> @@ -67,6 +67,13 @@ If set to a value larger than 0, the kernel will put the process issuing
>  IO to sleep for this amont of microseconds before entering classic
>  polling.
>  
> +io_timeout (RW)
> +---------------
> +This is a request’s timeouts at block layer in milliseconds. When the
> +underlying driver starts processing a request, the generic block layer
> +will start a timer, if this request cannot be completed in io_timeout
> +milliseconds, a timeout event will occur.
> +
>  iostats (RW)
>  -------------
>  This file is used to control (on/off) the iostats accounting of the
> -- 
> 2.14.1
> 
---end quoted text---