From: Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH] firmware: qcom: scm: fix compilation error when disabled
Date: Wed, 5 Dec 2018 09:37:21 -0800
Message-ID: <20181205173721.GA5232@tuxbook-pro>
References: <20181122023226.1074-1-jonathan@marek.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20181122023226.1074-1-jonathan@marek.ca>
Sender: linux-kernel-owner@vger.kernel.org
To: Jonathan Marek <jonathan@marek.ca>
Cc: Andy Gross <andy.gross@linaro.org>, Niklas Cassel <niklas.cassel@linaro.org>, Kalle Valo <kvalo@codeaurora.org>, Brian Norris <briannorris@chromium.org>, Jordan Crouse <jcrouse@codeaurora.org>, Govind Singh <govinds@codeaurora.org>, open list <linux-kernel@vger.kernel.org>, linux-arm-msm@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org

+ linux-arm-msm

On Wed 21 Nov 18:32 PST 2018, Jonathan Marek wrote:

> This fixes the case when CONFIG_QCOM_SCM is not enabled, and linux/errno.h
> has not been included previously.
> 
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

> ---
> drm/msm includes qcom_scm.h, but can be used with non-qcom hw (IMX5)
> 
>  include/linux/qcom_scm.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/qcom_scm.h b/include/linux/qcom_scm.h
> index 06996ad4f2bc..1637385bcc17 100644
> --- a/include/linux/qcom_scm.h
> +++ b/include/linux/qcom_scm.h
> @@ -67,6 +67,9 @@ extern int qcom_scm_iommu_secure_ptbl_init(u64 addr, u32 size, u32 spare);
>  extern int qcom_scm_io_readl(phys_addr_t addr, unsigned int *val);
>  extern int qcom_scm_io_writel(phys_addr_t addr, unsigned int val);
>  #else
> +
> +#include <linux/errno.h>
> +
>  static inline
>  int qcom_scm_set_cold_boot_addr(void *entry, const cpumask_t *cpus)
>  {
> -- 
> 2.17.1
>