From: Tom Rini Date: Thu, 6 Dec 2018 16:41:57 -0500 Subject: [U-Boot] [PATCH] spl: fix build failure with !CONFIG_SPL_PCI_SUPPORT In-Reply-To: <20181206101008.11250-1-nsekhar@ti.com> References: <20181206101008.11250-1-nsekhar@ti.com> Message-ID: <20181206214157.GR32109@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Dec 06, 2018 at 03:40:08PM +0530, Sekhar Nori wrote: > Building U-Boot with CONFIG_PCI and CONFIG_DM_PCI enabled, but > CONFIG_SPL_PCI_SUPPORT disabled, results in following linker > error: > > lib/built-in.o: In function `fdtdec_get_pci_bar32': > lib/fdtdec.c:305: undefined reference to `dm_pci_read_bar32' > fdtdec.c:305:(.text.fdtdec_get_pci_bar32+0x24): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `dm_pci_read_bar32' > > This is because reference to dm_pci_read_bar32() remains in lib/fdtdec.c > while SPL build does not descend into drivers/pci directory in > drivers/Makefile if CONFIG_SPL_PCI_SUPPORT is not enabled. > > Fix this by applying appropriate #define guards in lib/fdtdec.c. > It looks like ns16550.c has the same problem, so fixed that too. > > To simplify this, CONFIG_SPL_PCI_SUPPORT is renamed to CONFIG_SPL_PCI > (enables use of CONFIG_IS_ENABLED() macro). > > Suggested-by: Vignesh R > Signed-off-by: Sekhar Nori Reviewed-by: Tom Rini -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: