From: Peter Zijlstra Subject: Re: [PATCH v2 08/17] locking/lockdep: Add support for nestable terminal locks Date: Fri, 7 Dec 2018 10:52:17 +0100 Message-ID: <20181207095217.GA5307@hirez.programming.kicks-ass.net> References: <1542653726-5655-1-git-send-email-longman@redhat.com> <1542653726-5655-9-git-send-email-longman@redhat.com> <20181207092252.GF2237@hirez.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20181207092252.GF2237-Nxj+rRp3nVydTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Waiman Long Cc: Petr Mladek , Sergey Senozhatsky , Will Deacon , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kasan-dev-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Ingo Molnar , Tejun Heo , Andrey Ryabinin , Thomas Gleixner , Andrew Morton List-Id: iommu@lists.linux-foundation.org On Fri, Dec 07, 2018 at 10:22:52AM +0100, Peter Zijlstra wrote: > On Mon, Nov 19, 2018 at 01:55:17PM -0500, Waiman Long wrote: > > There are use cases where we want to allow nesting of one terminal lock > > underneath another terminal-like lock. That new lock type is called > > nestable terminal lock which can optionally allow the acquisition of > > no more than one regular (non-nestable) terminal lock underneath it. > > I think I asked for a more coherent changelog on this. The above is > still self contradictory and doesn't explain why you'd ever want such a > 'misfeature' :-) So maybe call the thing penterminal (contraction of penultimate and terminal) locks and explain why this annotation is safe -- in great detail.