From: Roman Kagan Subject: Re: [PATCH v2 4/7] x86/kvm/hyper-v: Introduce KVM_GET_SUPPORTED_HV_CPUID Date: Tue, 11 Dec 2018 14:02:52 +0000 Message-ID: <20181211140247.GC2378@rkaganb.sw.ru> References: <20181210172159.410-1-vkuznets@redhat.com> <20181210172159.410-5-vkuznets@redhat.com> <20181211124956.GA2378@rkaganb.sw.ru> <87bm5sp501.fsf@vitty.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable Cc: "kvm@vger.kernel.org" , Paolo Bonzini , =?iso-8859-2?Q?Radim_Kr=E8m=E1=F8?= , "linux-kernel@vger.kernel.org" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , "x86@kernel.org" , "Michael Kelley (EOSG)" , Eduardo Habkost To: Vitaly Kuznetsov Return-path: In-Reply-To: <87bm5sp501.fsf@vitty.brq.redhat.com> Content-Language: en-US Content-ID: <8253547EC0A35049BAC975F8D6FF5C48@eurprd08.prod.outlook.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Tue, Dec 11, 2018 at 02:28:14PM +0100, Vitaly Kuznetsov wrote: > Roman Kagan writes: >=20 > > On Mon, Dec 10, 2018 at 06:21:56PM +0100, Vitaly Kuznetsov wrote: >=20 > >> + > >> +Currently, the following list of CPUID leaves are returned: > >> + HYPERV_CPUID_VENDOR_AND_MAX_FUNCTIONS > >> + HYPERV_CPUID_INTERFACE > >> + HYPERV_CPUID_VERSION > >> + HYPERV_CPUID_FEATURES > >> + HYPERV_CPUID_ENLIGHTMENT_INFO > >> + HYPERV_CPUID_IMPLEMENT_LIMITS > >> + HYPERV_CPUID_NESTED_FEATURES > >> + > >> +HYPERV_CPUID_NESTED_FEATURES leaf is only exposed when Enlightened VM= CS was > >> +enabled on the corresponding vCPU (KVM_CAP_HYPERV_ENLIGHTENED_VMCS). > > > > IOW the output of ioctl(KVM_GET_SUPPORTED_HV_CPUID) depends on > > whether ioctl(KVM_ENABLE_CAP, KVM_CAP_HYPERV_ENLIGHTENED_VMCS) has > > already been called on that vcpu? I wonder if this fits the intended > > usage? >=20 > I added HYPERV_CPUID_NESTED_FEATURES in the list (and made the new ioctl > per-cpu and not per-vm) for consistency. *In theory* > KVM_CAP_HYPERV_ENLIGHTENED_VMCS is also enabled per-vcpu so some > hypothetical userspace can later check enabled eVMCS versions (which can > differ across vCPUs!) with KVM_GET_SUPPORTED_HV_CPUID. We will also have > direct tlb flush and other nested features there so to avoid addning new > KVM_CAP_* for them we need the CPUID. This is different from how KVM_GET_SUPPORTED_CPUID is used: QEMU assumes that its output doesn't change between calls, and even caches the result calling the ioctl only once. > Another thing I'm thinking about is something like 'hv_all' cpu flag for > Qemu which would enable everything by setting guest CPUIDs to what > KVM_GET_SUPPORTED_HV_CPUID returns. In that case it would also be > convenient to have HYPERV_CPUID_NESTED_FEATURES properly filled (or not > filled when eVMCS was not enabled). I think this is orthogonal to the way you obtain capability info from the kernel. Roman.