From: Olaf Hering Subject: [PATCH v1] xen_disk: fix memory leak Date: Tue, 11 Dec 2018 17:02:24 +0100 Message-ID: <20181211160224.22181-1-olaf@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gWkUO-0000J6-Qu for xen-devel@lists.xenproject.org; Tue, 11 Dec 2018 16:02:29 +0000 List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: qemu-devel@nongnu.org Cc: Kevin Wolf , Olaf Hering , Stefano Stabellini , "open list:Block layer core" , Max Reitz , Anthony Perard , "open list:X86" List-Id: xen-devel@lists.xenproject.org VGhlcmUgYXJlIHNvbWUgY29kZSBwYXRocyB0aGF0IGNsb2JiZXIgaW9yZXEtPmJ1Ziwgd2hpY2gg bGVhZHMgdG8gYSBodWdlCm1lbW9yeSBsZWFrIGFmdGVyIGEgZmV3IGhvdXJzIG9mIHJ1bnRpbWUu IE9uZSBjb2RlIHBhdGggaXMKcWVtdV9haW9fY29tcGxldGUsIHdoaWNoIG1pZ2h0IGJlIGNhbGxl ZCByZWN1cnNpdmUuIEFub3RoZXIgb25lIGlzCmlvcmVxX3Jlc2V0LCB3aGljaCBtaWdodCBjbG9i YmVyIGlvcmVxLT5idWYgYXMgd2VsbC4KCkFkZCB3cmFwcGVycyB0byBmcmVlIGlvcmVxLT5idWYg YmVmb3JlIHJlYXNzaWdubWVudC4KClNpZ25lZC1vZmYtYnk6IE9sYWYgSGVyaW5nIDxvbGFmQGFl cGZsZS5kZT4KLS0tCiBody9ibG9jay94ZW5fZGlzay5jIHwgMjIgKysrKysrKysrKysrKysrKyst LS0tLQogMSBmaWxlIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvaHcvYmxvY2sveGVuX2Rpc2suYyBiL2h3L2Jsb2NrL3hlbl9kaXNrLmMKaW5k ZXggMzZlZmY5NGY4NC4uZTE1ZWVmZTYyNSAxMDA2NDQKLS0tIGEvaHcvYmxvY2sveGVuX2Rpc2su YworKysgYi9ody9ibG9jay94ZW5fZGlzay5jCkBAIC0xMDMsMTIgKzEwMywyNCBAQCBzdHJ1Y3Qg WGVuQmxrRGV2IHsKIAogLyogLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLSAqLwogCitzdGF0aWMgdm9pZCBpb3JlcV9idWZfYWxsb2Mo c3RydWN0IGlvcmVxICppb3JlcSwgc2l6ZV90IGFsaWdubWVudCkKK3sKKyAgICBpZiAoaW9yZXEt PmJ1ZikKKyAgICAgICAgcWVtdV92ZnJlZShpb3JlcS0+YnVmKTsKKyAgICBpb3JlcS0+YnVmID0g cWVtdV9tZW1hbGlnbihYQ19QQUdFX1NJWkUsIGlvcmVxLT5zaXplKTsKK30KK3N0YXRpYyB2b2lk IGlvcmVxX2J1Zl9mcmVlKHN0cnVjdCBpb3JlcSAqaW9yZXEpCit7CisgICAgaWYgKGlvcmVxLT5i dWYpCisgICAgICAgIHFlbXVfdmZyZWUoaW9yZXEtPmJ1Zik7CisgICAgaW9yZXEtPmJ1ZiA9IE5V TEw7Cit9CiBzdGF0aWMgdm9pZCBpb3JlcV9yZXNldChzdHJ1Y3QgaW9yZXEgKmlvcmVxKQogewor ICAgIGlvcmVxX2J1Zl9mcmVlKGlvcmVxKTsKICAgICBtZW1zZXQoJmlvcmVxLT5yZXEsIDAsIHNp emVvZihpb3JlcS0+cmVxKSk7CiAgICAgaW9yZXEtPnN0YXR1cyA9IDA7CiAgICAgaW9yZXEtPnN0 YXJ0ID0gMDsKLSAgICBpb3JlcS0+YnVmID0gTlVMTDsKICAgICBpb3JlcS0+c2l6ZSA9IDA7CiAg ICAgaW9yZXEtPnByZXN5bmMgPSAwOwogCkBAIC0zMTUsMTQgKzMyNywxNCBAQCBzdGF0aWMgdm9p ZCBxZW11X2Fpb19jb21wbGV0ZSh2b2lkICpvcGFxdWUsIGludCByZXQpCiAgICAgICAgIGlmIChy ZXQgPT0gMCkgewogICAgICAgICAgICAgaW9yZXFfZ3JhbnRfY29weShpb3JlcSk7CiAgICAgICAg IH0KLSAgICAgICAgcWVtdV92ZnJlZShpb3JlcS0+YnVmKTsKKyAgICAgICAgaW9yZXFfYnVmX2Zy ZWUoaW9yZXEpOwogICAgICAgICBicmVhazsKICAgICBjYXNlIEJMS0lGX09QX1dSSVRFOgogICAg IGNhc2UgQkxLSUZfT1BfRkxVU0hfRElTS0NBQ0hFOgogICAgICAgICBpZiAoIWlvcmVxLT5yZXEu bnJfc2VnbWVudHMpIHsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9Ci0gICAgICAgIHFl bXVfdmZyZWUoaW9yZXEtPmJ1Zik7CisgICAgICAgIGlvcmVxX2J1Zl9mcmVlKGlvcmVxKTsKICAg ICAgICAgYnJlYWs7CiAgICAgZGVmYXVsdDoKICAgICAgICAgYnJlYWs7CkBAIC0zOTAsMTIgKzQw MiwxMiBAQCBzdGF0aWMgaW50IGlvcmVxX3J1bmlvX3FlbXVfYWlvKHN0cnVjdCBpb3JlcSAqaW9y ZXEpCiB7CiAgICAgc3RydWN0IFhlbkJsa0RldiAqYmxrZGV2ID0gaW9yZXEtPmJsa2RldjsKIAot ICAgIGlvcmVxLT5idWYgPSBxZW11X21lbWFsaWduKFhDX1BBR0VfU0laRSwgaW9yZXEtPnNpemUp OworICAgIGlvcmVxX2J1Zl9hbGxvYyhpb3JlcSwgWENfUEFHRV9TSVpFKTsKICAgICBpZiAoaW9y ZXEtPnJlcS5ucl9zZWdtZW50cyAmJgogICAgICAgICAoaW9yZXEtPnJlcS5vcGVyYXRpb24gPT0g QkxLSUZfT1BfV1JJVEUgfHwKICAgICAgICAgIGlvcmVxLT5yZXEub3BlcmF0aW9uID09IEJMS0lG X09QX0ZMVVNIX0RJU0tDQUNIRSkgJiYKICAgICAgICAgaW9yZXFfZ3JhbnRfY29weShpb3JlcSkp IHsKLSAgICAgICAgcWVtdV92ZnJlZShpb3JlcS0+YnVmKTsKKyAgICAgICAgaW9yZXFfYnVmX2Zy ZWUoaW9yZXEpOwogICAgICAgICBnb3RvIGVycjsKICAgICB9CiAKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVu LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcv bWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw=