Return-Path: Received: from mx2.suse.de ([195.135.220.15]:55364 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726402AbeLKRYa (ORCPT ); Tue, 11 Dec 2018 12:24:30 -0500 From: Jan Kara To: Al Viro Cc: , Jan Kara Subject: [PATCH 0/2 RESEND] vfs: Fix crashes when reading /proc/mounts Date: Tue, 11 Dec 2018 18:24:21 +0100 Message-Id: <20181211172423.7709-1-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hello, resending this patch series since I got no reply for almost two months. This patch series aims at fixing possible races between functions formatting output for /proc/mounts and friends and remount. Especially ->show_options functions of filesystems are not counting with the fact that options can change under them and thus races can result in bogus output or outright crashes (like was the case with ext4 handling of quota mount option, or udf could crash when printing charset name, or xfs when printing log device name etc.). Admittedly the patch 2/2 is somewhat ugly because namespace_sem ranks below sb->s_umount semaphore but I think it is bearable. Al, what do you think? Honza