From: Anthony PERARD Subject: [PATCH] libxl_create: Re-order callbacks of initiate_domain_create Date: Wed, 12 Dec 2018 14:53:46 +0000 Message-ID: <20181212145346.10331-1-anthony.perard@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gX5tt-0007ti-N1 for xen-devel@lists.xenproject.org; Wed, 12 Dec 2018 14:54:13 +0000 List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: xen-devel@lists.xenproject.org Cc: Anthony PERARD , Wei Liu , Ian Jackson List-Id: xen-devel@lists.xenproject.org Q2FsbGJhY2tzIHNob3VsZCBiZSBpbiB0aGUgb3JkZXIgdGhhdCB0aGVyZSBhcmUgZ29pbmcgdG8g YmUgZXhlY3V0ZWQuClRoaXMgcGF0Y2ggZml4IHRoZSBpbml0aWF0ZV9kb21haW5fY3JlYXRlIGNh bGxiYWNrcywgYW5kIGFsc28gcmVvcmRlcgp0aGUgY2FsbGJhY2tzIHByb3RvdHl0ZXMuIFRoYXQg d2F5LCBpdCdzIGVhc2llciB0byBmb2xsb3cgdGhlIGZsb3cuCgpUaGlzIHBhdGNoOgotIG1vdmUg bGlieGxfX2NvbG9fcmVzdG9yZV9zZXR1cF9kb25lIGFmdGVyIGRvbWNyZWF0ZV9ib290bG9hZGVy X2RvbmUuCi0gbW92ZSBkb21jcmVhdGVfYXR0YWNoX2RldmljZXMgYWZ0ZXIgZG9tY3JlYXRlX2Rl dm1vZGVsX3N0YXJ0ZWQuCgpObyBmdW5jdGlvbmFsIGNoYW5nZS4KClNpZ25lZC1vZmYtYnk6IEFu dGhvbnkgUEVSQVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPgotLS0KIHRvb2xzL2xpYnhs L2xpYnhsX2NyZWF0ZS5jIHwgMTIzICsrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0t LS0KIDEgZmlsZSBjaGFuZ2VkLCA2MyBpbnNlcnRpb25zKCspLCA2MCBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS90b29scy9saWJ4bC9saWJ4bF9jcmVhdGUuYyBiL3Rvb2xzL2xpYnhsL2xpYnhs X2NyZWF0ZS5jCmluZGV4IGZhNTczMzQ0YmMuLjg5MTE3NWIxNWIgMTAwNjQ0Ci0tLSBhL3Rvb2xz L2xpYnhsL2xpYnhsX2NyZWF0ZS5jCisrKyBiL3Rvb2xzL2xpYnhsL2xpYnhsX2NyZWF0ZS5jCkBA IC03NzEsMjggKzc3MSwzMSBAQCBzdGF0aWMgaW50IHN0b3JlX2xpYnhsX2VudHJ5KGxpYnhsX19n YyAqZ2MsIHVpbnQzMl90IGRvbWlkLAogICovCiAKIC8qIEV2ZW50IGNhbGxiYWNrcywgaW4gdGhp cyBvcmRlcjogKi8KLXN0YXRpYyB2b2lkIGRvbWNyZWF0ZV9kZXZtb2RlbF9zdGFydGVkKGxpYnhs X19lZ2MgKmVnYywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxpYnhs X19kbV9zcGF3bl9zdGF0ZSAqZG1zcywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGludCByYyk7CiBzdGF0aWMgdm9pZCBkb21jcmVhdGVfYm9vdGxvYWRlcl9jb25zb2xl X2F2YWlsYWJsZShsaWJ4bF9fZWdjICplZ2MsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBsaWJ4bF9fYm9vdGxvYWRlcl9zdGF0ZSAqYmwpOwotc3Rh dGljIHZvaWQgZG9tY3JlYXRlX2Jvb3Rsb2FkZXJfZG9uZShsaWJ4bF9fZWdjICplZ2MsCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxpYnhsX19ib290bG9hZGVyX3N0YXRl ICpibCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW50IHJjKTsKLQot c3RhdGljIHZvaWQgZG9tY3JlYXRlX2xhdW5jaF9kbShsaWJ4bF9fZWdjICplZ2MsIGxpYnhsX19t dWx0aWRldiAqYW9kZXZzLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgcmV0 KTsKLQogc3RhdGljIHZvaWQgZG9tY3JlYXRlX2NvbnNvbGVfYXZhaWxhYmxlKGxpYnhsX19lZ2Mg KmVnYywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsaWJ4bF9fZG9t YWluX2NyZWF0ZV9zdGF0ZSAqZGNzKTsKIAorc3RhdGljIHZvaWQgZG9tY3JlYXRlX2Jvb3Rsb2Fk ZXJfZG9uZShsaWJ4bF9fZWdjICplZ2MsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGxpYnhsX19ib290bG9hZGVyX3N0YXRlICpibCwKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgaW50IHJjKTsKK3N0YXRpYyB2b2lkIGxpYnhsX19jb2xvX3Jlc3Rv cmVfc2V0dXBfZG9uZShsaWJ4bF9fZWdjICplZ2MsCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgbGlieGxfX2NvbG9fcmVzdG9yZV9zdGF0ZSAqY3JzLAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCByYyk7CiBzdGF0aWMgdm9p ZCBkb21jcmVhdGVfc3RyZWFtX2RvbmUobGlieGxfX2VnYyAqZWdjLAogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGxpYnhsX19zdHJlYW1fcmVhZF9zdGF0ZSAqc3JzLAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCByZXQpOwotCiBzdGF0aWMgdm9pZCBkb21j cmVhdGVfcmVidWlsZF9kb25lKGxpYnhsX19lZ2MgKmVnYywKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgbGlieGxfX2RvbWFpbl9jcmVhdGVfc3RhdGUgKmRjcywKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgaW50IHJldCk7CitzdGF0aWMgdm9pZCBkb21jcmVh dGVfbGF1bmNoX2RtKGxpYnhsX19lZ2MgKmVnYywgbGlieGxfX211bHRpZGV2ICphb2RldnMsCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCByZXQpOworc3RhdGljIHZvaWQgZG9t Y3JlYXRlX2Rldm1vZGVsX3N0YXJ0ZWQobGlieGxfX2VnYyAqZWdjLAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgbGlieGxfX2RtX3NwYXduX3N0YXRlICpkbXNzLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW50IHJjKTsKK3N0YXRpYyB2b2lk IGRvbWNyZWF0ZV9hdHRhY2hfZGV2aWNlcyhsaWJ4bF9fZWdjICplZ2MsCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgbGlieGxfX211bHRpZGV2ICptdWx0aWRldiwKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgcmV0KTsKIAogLyogT3VyIG93biBm dW5jdGlvbiB0byBjbGVhbiB1cCBhbmQgY2FsbCB0aGUgdXNlcidzIGNhbGxiYWNrLgogICogVGhl IGZpbmFsIGNhbGwgaW4gdGhlIHNlcXVlbmNlLiAqLwpAQCAtMTAzMSwyMyArMTAzNCw2IEBAIHN0 YXRpYyB2b2lkIGRvbWNyZWF0ZV9jb25zb2xlX2F2YWlsYWJsZShsaWJ4bF9fZWdjICplZ2MsCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGNzLT5hb3BfY29uc29sZV9o b3cuZm9yX2V2ZW50KSk7CiB9CiAKLXN0YXRpYyB2b2lkIGxpYnhsX19jb2xvX3Jlc3RvcmVfc2V0 dXBfZG9uZShsaWJ4bF9fZWdjICplZ2MsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgbGlieGxfX2NvbG9fcmVzdG9yZV9zdGF0ZSAqY3JzLAotICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCByYykKLXsKLSAgICBsaWJ4bF9fZG9t YWluX2NyZWF0ZV9zdGF0ZSAqZGNzID0gQ09OVEFJTkVSX09GKGNycywgKmRjcywgY3JzKTsKLQot ICAgIEVHQ19HQzsKLQotICAgIGlmIChyYykgewotICAgICAgICBMT0dEKEVSUk9SLCBkY3MtPmd1 ZXN0X2RvbWlkLCAiY29sbyByZXN0b3JlIHNldHVwIGZhaWxzOiAlZCIsIHJjKTsKLSAgICAgICAg ZG9tY3JlYXRlX3N0cmVhbV9kb25lKGVnYywgJmRjcy0+c3JzLCByYyk7Ci0gICAgICAgIHJldHVy bjsKLSAgICB9Ci0KLSAgICBsaWJ4bF9fc3RyZWFtX3JlYWRfc3RhcnQoZWdjLCAmZGNzLT5zcnMp OwotfQotCiBzdGF0aWMgdm9pZCBkb21jcmVhdGVfYm9vdGxvYWRlcl9kb25lKGxpYnhsX19lZ2Mg KmVnYywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGlieGxfX2Jvb3Rs b2FkZXJfc3RhdGUgKmJsLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBp bnQgcmMpCkBAIC0xMTQ1LDYgKzExMzEsMjMgQEAgc3RhdGljIHZvaWQgZG9tY3JlYXRlX2Jvb3Rs b2FkZXJfZG9uZShsaWJ4bF9fZWdjICplZ2MsCiAgICAgZG9tY3JlYXRlX3N0cmVhbV9kb25lKGVn YywgJmRjcy0+c3JzLCByYyk7CiB9CiAKK3N0YXRpYyB2b2lkIGxpYnhsX19jb2xvX3Jlc3RvcmVf c2V0dXBfZG9uZShsaWJ4bF9fZWdjICplZ2MsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgbGlieGxfX2NvbG9fcmVzdG9yZV9zdGF0ZSAqY3JzLAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCByYykKK3sKKyAgICBsaWJ4bF9f ZG9tYWluX2NyZWF0ZV9zdGF0ZSAqZGNzID0gQ09OVEFJTkVSX09GKGNycywgKmRjcywgY3JzKTsK KworICAgIEVHQ19HQzsKKworICAgIGlmIChyYykgeworICAgICAgICBMT0dEKEVSUk9SLCBkY3Mt Pmd1ZXN0X2RvbWlkLCAiY29sbyByZXN0b3JlIHNldHVwIGZhaWxzOiAlZCIsIHJjKTsKKyAgICAg ICAgZG9tY3JlYXRlX3N0cmVhbV9kb25lKGVnYywgJmRjcy0+c3JzLCByYyk7CisgICAgICAgIHJl dHVybjsKKyAgICB9CisKKyAgICBsaWJ4bF9fc3RyZWFtX3JlYWRfc3RhcnQoZWdjLCAmZGNzLT5z cnMpOworfQorCiB2b2lkIGxpYnhsX19zcm1fY2FsbG91dF9jYWxsYmFja19yZXN0b3JlX3Jlc3Vs dHMoeGVuX3Bmbl90IHN0b3JlX21mbiwKICAgICAgICAgICB4ZW5fcGZuX3QgY29uc29sZV9tZm4s IHZvaWQgKnVzZXIpCiB7CkBAIC0xNTA5LDYgKzE1MTIsMzggQEAgY29uc3Qgc3RydWN0IGxpYnhs X2RldmljZV90eXBlICpkZXZpY2VfdHlwZV90YmxbXSA9IHsKICAgICBOVUxMCiB9OwogCitzdGF0 aWMgdm9pZCBkb21jcmVhdGVfZGV2bW9kZWxfc3RhcnRlZChsaWJ4bF9fZWdjICplZ2MsCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsaWJ4bF9fZG1fc3Bhd25fc3RhdGUg KmRtc3MsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgcmV0KQor eworICAgIGxpYnhsX19kb21haW5fY3JlYXRlX3N0YXRlICpkY3MgPSBDT05UQUlORVJfT0YoZG1z cywgKmRjcywgc2Rzcy5kbSk7CisgICAgU1RBVEVfQU9fR0MoZG1zcy0+c3Bhd24uYW8pOworICAg IGludCBkb21pZCA9IGRjcy0+Z3Vlc3RfZG9taWQ7CisKKyAgICAvKiBjb252ZW5pZW5jZSBhbGlh c2VzICovCisgICAgbGlieGxfZG9tYWluX2NvbmZpZyAqY29uc3QgZF9jb25maWcgPSBkY3MtPmd1 ZXN0X2NvbmZpZzsKKworICAgIGlmIChyZXQpIHsKKyAgICAgICAgTE9HRChFUlJPUiwgZG9taWQs ICJkZXZpY2UgbW9kZWwgZGlkIG5vdCBzdGFydDogJWQiLCByZXQpOworICAgICAgICBnb3RvIGVy cm9yX291dDsKKyAgICB9CisKKyAgICBpZiAoZGNzLT5zZHNzLmRtLmd1ZXN0X2RvbWlkKSB7Cisg ICAgICAgIGlmIChkX2NvbmZpZy0+Yl9pbmZvLmRldmljZV9tb2RlbF92ZXJzaW9uCisgICAgICAg ICAgICA9PSBMSUJYTF9ERVZJQ0VfTU9ERUxfVkVSU0lPTl9RRU1VX1hFTikgeworICAgICAgICAg ICAgbGlieGxfX3FtcF9pbml0aWFsaXphdGlvbnMoZ2MsIGRvbWlkLCBkX2NvbmZpZyk7CisgICAg ICAgIH0KKyAgICB9CisKKyAgICBkY3MtPmRldmljZV90eXBlX2lkeCA9IC0xOworICAgIGRvbWNy ZWF0ZV9hdHRhY2hfZGV2aWNlcyhlZ2MsICZkY3MtPm11bHRpZGV2LCAwKTsKKyAgICByZXR1cm47 CisKK2Vycm9yX291dDoKKyAgICBhc3NlcnQocmV0KTsKKyAgICBkb21jcmVhdGVfY29tcGxldGUo ZWdjLCBkY3MsIHJldCk7Cit9CisKIHN0YXRpYyB2b2lkIGRvbWNyZWF0ZV9hdHRhY2hfZGV2aWNl cyhsaWJ4bF9fZWdjICplZ2MsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg bGlieGxfX211bHRpZGV2ICptdWx0aWRldiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBpbnQgcmV0KQpAQCAtMTU1MiwzOCArMTU4Nyw2IEBAIHN0YXRpYyB2b2lkIGRvbWNy ZWF0ZV9hdHRhY2hfZGV2aWNlcyhsaWJ4bF9fZWdjICplZ2MsCiAgICAgZG9tY3JlYXRlX2NvbXBs ZXRlKGVnYywgZGNzLCByZXQpOwogfQogCi1zdGF0aWMgdm9pZCBkb21jcmVhdGVfZGV2bW9kZWxf c3RhcnRlZChsaWJ4bF9fZWdjICplZ2MsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBsaWJ4bF9fZG1fc3Bhd25fc3RhdGUgKmRtc3MsCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBpbnQgcmV0KQotewotICAgIGxpYnhsX19kb21haW5fY3JlYXRl X3N0YXRlICpkY3MgPSBDT05UQUlORVJfT0YoZG1zcywgKmRjcywgc2Rzcy5kbSk7Ci0gICAgU1RB VEVfQU9fR0MoZG1zcy0+c3Bhd24uYW8pOwotICAgIGludCBkb21pZCA9IGRjcy0+Z3Vlc3RfZG9t aWQ7Ci0KLSAgICAvKiBjb252ZW5pZW5jZSBhbGlhc2VzICovCi0gICAgbGlieGxfZG9tYWluX2Nv bmZpZyAqY29uc3QgZF9jb25maWcgPSBkY3MtPmd1ZXN0X2NvbmZpZzsKLQotICAgIGlmIChyZXQp IHsKLSAgICAgICAgTE9HRChFUlJPUiwgZG9taWQsICJkZXZpY2UgbW9kZWwgZGlkIG5vdCBzdGFy dDogJWQiLCByZXQpOwotICAgICAgICBnb3RvIGVycm9yX291dDsKLSAgICB9Ci0KLSAgICBpZiAo ZGNzLT5zZHNzLmRtLmd1ZXN0X2RvbWlkKSB7Ci0gICAgICAgIGlmIChkX2NvbmZpZy0+Yl9pbmZv LmRldmljZV9tb2RlbF92ZXJzaW9uCi0gICAgICAgICAgICA9PSBMSUJYTF9ERVZJQ0VfTU9ERUxf VkVSU0lPTl9RRU1VX1hFTikgewotICAgICAgICAgICAgbGlieGxfX3FtcF9pbml0aWFsaXphdGlv bnMoZ2MsIGRvbWlkLCBkX2NvbmZpZyk7Ci0gICAgICAgIH0KLSAgICB9Ci0KLSAgICBkY3MtPmRl dmljZV90eXBlX2lkeCA9IC0xOwotICAgIGRvbWNyZWF0ZV9hdHRhY2hfZGV2aWNlcyhlZ2MsICZk Y3MtPm11bHRpZGV2LCAwKTsKLSAgICByZXR1cm47Ci0KLWVycm9yX291dDoKLSAgICBhc3NlcnQo cmV0KTsKLSAgICBkb21jcmVhdGVfY29tcGxldGUoZWdjLCBkY3MsIHJldCk7Ci19Ci0KIHN0YXRp YyB2b2lkIGRvbWNyZWF0ZV9jb21wbGV0ZShsaWJ4bF9fZWdjICplZ2MsCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgbGlieGxfX2RvbWFpbl9jcmVhdGVfc3RhdGUgKmRjcywKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgcmMpCi0tIApBbnRob255IFBFUkFSRAoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBt YWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMu eGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw=