From: Sean Paul Subject: Re: [PATCH v3 3/3] drm/msm/dpu: add display port support in DPU Date: Fri, 14 Dec 2018 10:26:12 -0500 Message-ID: <20181214152612.GR154160@art_vandelay> References: <1544727064-26763-1-git-send-email-jsanka@codeaurora.org> <1544727064-26763-3-git-send-email-jsanka@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1544727064-26763-3-git-send-email-jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Jeykumar Sankaran Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, hoegsberg-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBEZWMgMTMsIDIwMTggYXQgMTA6NTE6MDRBTSAtMDgwMCwgSmV5a3VtYXIgU2Fua2Fy YW4gd3JvdGU6Cj4gQWRkIGRpc3BsYXkgcG9ydCBzdXBwb3J0IGluIERQVSBieSBjcmVhdGluZyBo b29rcwo+IGZvciBEUCBlbmNvZGVyIGVudW1lcmF0aW9uIGFuZCBlbmNvZGVyIG1vZGUKPiBpbml0 aWFsaXphdGlvbi4KPiAKPiBUaGlzIGNoYW5nZSBpcyBiYXNlZCBvbiB0aGUgU0RNODQ1IERpc3Bs YXkgcG9ydAo+IGRyaXZlciBjaGFuZ2VzWzFdLgo+IAo+IGNoYW5nZXMgaW4gdjI6Cj4gCS0gcmVi YXNlIG9uIFsyXSAoU2VhbiBQYXVsKQo+IAktIHJlbW92ZSB1bndhbnRlZCBlcnJvciBjaGVja3Mg YW5kCj4gCSAgc3dpdGNoIGNhc2VzIChKb3JkYW4gQ3JvdXNlKQo+IGNoYW5nZXMgaW4gdjM6Cj4g CS0gYWRkIGRwIHN1cHBvcnQgYWZ0ZXIgZml4aW5nCj4gCSAgdGhlIGN1cnJlbnQgY29kZSBiYXNl IGZvciBlcnJvciBsb2dnaW5nIChTZWFuIFBhdWwpCj4gCj4gWzFdIGh0dHBzOi8vbHduLm5ldC9B cnRpY2xlcy83NjgyNjUvCj4gWzJdIGh0dHBzOi8vbGttbC5vcmcvbGttbC8yMDE4LzExLzE3Lzg3 Cj4gCj4gU2lnbmVkLW9mZi1ieTogSmV5a3VtYXIgU2Fua2FyYW4gPGpzYW5rYUBjb2RlYXVyb3Jh Lm9yZz4KCkxHVE0sIHRoYW5rcyBmb3IgcmV2aXNpbmcuIAoKSSdsbCBsYW5kIHRoZSBmaXJzdCAy IHBhdGNoZXMgKGFmdGVyIHRoZSAybmQgb25lIGlzIGZpeGVkIHVwKSwgYW5kIENoYW5kYW4gY2Fu CnJvbGwgdGhpcyBwYXRjaCBpbnRvIGhpcyBzZXQgd2hlbiBoZSBzZW5kcyB0aGUgbmV3IHZlcnNp b24uIAoKUmV2aWV3ZWQtYnk6IFNlYW4gUGF1bCA8c2VhbkBwb29ybHkucnVuPgoKPiAtLS0KPiAg ZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2VuY29kZXIuYyB8ICA4ICsrLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9rbXMuYyAgICAgfCA1MSArKysrKysr KysrKysrKysrKysrKysrKysrLS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDQ5IGluc2VydGlvbnMo KyksIDEwIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNt L2Rpc3AvZHB1MS9kcHVfZW5jb2Rlci5jIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEv ZHB1X2VuY29kZXIuYwo+IGluZGV4IDM2MTU4YjcuLmI3OWZkOWQgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2VuY29kZXIuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9lbmNvZGVyLmMKPiBAQCAtMjAyOSw3ICsyMDI5LDcg QEAgc3RhdGljIGludCBkcHVfZW5jb2Rlcl9zZXR1cF9kaXNwbGF5KHN0cnVjdCBkcHVfZW5jb2Rl cl92aXJ0ICpkcHVfZW5jLAo+ICB7Cj4gIAlpbnQgcmV0ID0gMDsKPiAgCWludCBpID0gMDsKPiAt CWVudW0gZHB1X2ludGZfdHlwZSBpbnRmX3R5cGU7Cj4gKwllbnVtIGRwdV9pbnRmX3R5cGUgaW50 Zl90eXBlID0gSU5URl9OT05FOwo+ICAJc3RydWN0IGRwdV9lbmNfcGh5c19pbml0X3BhcmFtcyBw aHlzX3BhcmFtczsKPiAgCj4gIAlpZiAoIWRwdV9lbmMgfHwgIWRwdV9rbXMpIHsKPiBAQCAtMjA1 Miw5ICsyMDUyLDkgQEAgc3RhdGljIGludCBkcHVfZW5jb2Rlcl9zZXR1cF9kaXNwbGF5KHN0cnVj dCBkcHVfZW5jb2Rlcl92aXJ0ICpkcHVfZW5jLAo+ICAJY2FzZSBEUk1fTU9ERV9FTkNPREVSX0RT SToKPiAgCQlpbnRmX3R5cGUgPSBJTlRGX0RTSTsKPiAgCQlicmVhazsKPiAtCWRlZmF1bHQ6Cj4g LQkJRFBVX0VSUk9SX0VOQyhkcHVfZW5jLCAidW5zdXBwb3J0ZWQgZGlzcGxheSBpbnRlcmZhY2Ug dHlwZVxuIik7Cj4gLQkJcmV0dXJuIC1FSU5WQUw7Cj4gKwljYXNlIERSTV9NT0RFX0VOQ09ERVJf VE1EUzoKPiArCQlpbnRmX3R5cGUgPSBJTlRGX0RQOwo+ICsJCWJyZWFrOwo+ICAJfQo+ICAKPiAg CVdBUk5fT04oZGlzcF9pbmZvLT5udW1fb2ZfaF90aWxlcyA8IDEpOwo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfa21zLmMgYi9kcml2ZXJzL2dwdS9kcm0v bXNtL2Rpc3AvZHB1MS9kcHVfa21zLmMKPiBpbmRleCAzOWM4NTQ5Li5iYTNlNzVjIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9rbXMuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9rbXMuYwo+IEBAIC00MzcsNiArNDM3LDMy IEBAIHN0YXRpYyBpbnQgX2RwdV9rbXNfaW5pdGlhbGl6ZV9kc2koc3RydWN0IGRybV9kZXZpY2Ug KmRldiwKPiAgCXJldHVybiByYzsKPiAgfQo+ICAKPiArc3RhdGljIGludCBfZHB1X2ttc19pbml0 aWFsaXplX2Rpc3BsYXlwb3J0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gKwkJCQkJICAgIHN0 cnVjdCBtc21fZHJtX3ByaXZhdGUgKnByaXYsCj4gKwkJCQkJICAgIHN0cnVjdCBkcHVfa21zICpk cHVfa21zKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIgPSBOVUxMOwo+ICsJ aW50IHJjID0gMDsKPiArCj4gKwlpZiAoIXByaXYtPmRwKQo+ICsJCXJldHVybiByYzsKPiArCj4g KwllbmNvZGVyID0gZHB1X2VuY29kZXJfaW5pdChkZXYsIERSTV9NT0RFX0VOQ09ERVJfVE1EUyk7 Cj4gKwlpZiAoSVNfRVJSKGVuY29kZXIpKSB7Cj4gKwkJRFBVX0VSUk9SKCJlbmNvZGVyIGluaXQg ZmFpbGVkIGZvciBkc2kgZGlzcGxheVxuIik7Cj4gKwkJcmV0dXJuIFBUUl9FUlIoZW5jb2Rlcik7 Cj4gKwl9Cj4gKwo+ICsJcmMgPSBtc21fZHBfbW9kZXNldF9pbml0KHByaXYtPmRwLCBkZXYsIGVu Y29kZXIpOwo+ICsJaWYgKHJjKSB7Cj4gKwkJRFBVX0VSUk9SKCJtb2Rlc2V0X2luaXQgZmFpbGVk IGZvciBEUCwgcmMgPSAlZFxuIiwgcmMpOwo+ICsJCWRybV9lbmNvZGVyX2NsZWFudXAoZW5jb2Rl cik7Cj4gKwkJcmV0dXJuIHJjOwo+ICsJfQo+ICsKPiArCXJldHVybiByYzsKPiArfQo+ICsKPiAg LyoqCj4gICAqIF9kcHVfa21zX3NldHVwX2Rpc3BsYXlzIC0gY3JlYXRlIGVuY29kZXJzLCBicmlk Z2VzIGFuZCBjb25uZWN0b3JzCj4gICAqICAgICAgICAgICAgICAgICAgICAgICAgICAgZm9yIHVu ZGVybHlpbmcgZGlzcGxheXMKPiBAQCAtNDU3LDYgKzQ4MywxMiBAQCBzdGF0aWMgaW50IF9kcHVf a21zX3NldHVwX2Rpc3BsYXlzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAkJcmV0dXJuIHJj Owo+ICAJfQo+ICAKPiArCXJjID0gX2RwdV9rbXNfaW5pdGlhbGl6ZV9kaXNwbGF5cG9ydChkZXYs IHByaXYsIGRwdV9rbXMpOwo+ICsJaWYgKHJjKSB7Cj4gKwkJRFBVX0VSUk9SKCJmYWlsZWQgdG8g aW5pdGlhbGl6ZSBkaXNwbGF5IHBvcnQsIHJjID0gJWRcbiIsIHJjKTsKPiArCQlyZXR1cm4gcmM7 Cj4gKwl9Cj4gKwo+ICAJLyoqCj4gIAkgKiBFeHRlbmQgdGhpcyBmdW5jdGlvbiB0byBpbml0aWFs aXplIG90aGVyCj4gIAkgKiB0eXBlcyBvZiBkaXNwbGF5cwo+IEBAIC02NzUsMTMgKzcwNywyMCBA QCBzdGF0aWMgdm9pZCBfZHB1X2ttc19zZXRfZW5jb2Rlcl9tb2RlKHN0cnVjdCBtc21fa21zICpr bXMsCj4gIAlpbmZvLmNhcGFiaWxpdGllcyA9IGNtZF9tb2RlID8gTVNNX0RJU1BMQVlfQ0FQX0NN RF9NT0RFIDoKPiAgCQkJTVNNX0RJU1BMQVlfQ0FQX1ZJRF9NT0RFOwo+ICAKPiAtCS8qIFRPRE86 IE5vIHN1cHBvcnQgZm9yIERTSSBzd2FwICovCj4gLQlmb3IgKGkgPSAwOyBpIDwgQVJSQVlfU0la RShwcml2LT5kc2kpOyBpKyspIHsKPiAtCQlpZiAocHJpdi0+ZHNpW2ldKSB7Cj4gLQkJCWluZm8u aF90aWxlX2luc3RhbmNlW2luZm8ubnVtX29mX2hfdGlsZXNdID0gaTsKPiAtCQkJaW5mby5udW1f b2ZfaF90aWxlcysrOwo+ICsJc3dpdGNoIChpbmZvLmludGZfdHlwZSkgewo+ICsJY2FzZSBEUk1f TU9ERV9FTkNPREVSX0RTSToKPiArCQkvKiBUT0RPOiBObyBzdXBwb3J0IGZvciBEU0kgc3dhcCAq Lwo+ICsJCWZvciAoaSA9IDA7IGkgPCBBUlJBWV9TSVpFKHByaXYtPmRzaSk7IGkrKykgewo+ICsJ CQlpZiAocHJpdi0+ZHNpW2ldKSB7Cj4gKwkJCQlpbmZvLmhfdGlsZV9pbnN0YW5jZVtpbmZvLm51 bV9vZl9oX3RpbGVzXSA9IGk7Cj4gKwkJCQlpbmZvLm51bV9vZl9oX3RpbGVzKys7Cj4gKwkJCX0K PiAgCQl9Cj4gLQl9Cj4gKwkJYnJlYWs7Cj4gKwljYXNlIERSTV9NT0RFX0VOQ09ERVJfVE1EUzoK PiArCQlpbmZvLm51bV9vZl9oX3RpbGVzID0gMTsKPiArCQlicmVhazsKPiArCX07Cj4gIAo+ICAJ cmMgPSBkcHVfZW5jb2Rlcl9zZXR1cChlbmNvZGVyLT5kZXYsIGVuY29kZXIsICZpbmZvKTsKPiAg CWlmIChyYykKPiAtLSAKPiBUaGUgUXVhbGNvbW0gSW5ub3ZhdGlvbiBDZW50ZXIsIEluYy4gaXMg YSBtZW1iZXIgb2YgdGhlIENvZGUgQXVyb3JhIEZvcnVtLAo+IGEgTGludXggRm91bmRhdGlvbiBD b2xsYWJvcmF0aXZlIFByb2plY3QKPiAKCi0tIApTZWFuIFBhdWwsIFNvZnR3YXJlIEVuZ2luZWVy LCBHb29nbGUgLyBDaHJvbWl1bSBPUwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpGcmVlZHJlbm8gbWFpbGluZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9mcmVlZHJlbm8K