Return-Path: Received: from verein.lst.de ([213.95.11.211]:57931 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729910AbeLPQlb (ORCPT ); Sun, 16 Dec 2018 11:41:31 -0500 Date: Sun, 16 Dec 2018 17:41:30 +0100 From: Christoph Hellwig To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, hch@lst.de, jmoyer@redhat.com, clm@fb.com Subject: Re: [PATCH 24/26] fs: add support for mapping an ITER_BVEC for O_DIRECT Message-ID: <20181216164130.GD13234@lst.de> References: <20181213175645.22181-1-axboe@kernel.dk> <20181213175645.22181-25-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181213175645.22181-25-axboe@kernel.dk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > + if (iov_iter_is_bvec(iter)) > + ret = bio_iov_bvec_add_pages(&bio, iter); > + else > + ret = bio_iov_iter_get_pages(&bio, iter); Shouldn't this actually be done inside bio_iov_iter_get_pages?