From: Daniel Vetter Subject: Re: [RFC PATCH 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2 Date: Thu, 27 Dec 2018 13:00:46 +0100 Message-ID: <20181227120046.GC9058@dvetter-linux.ger.corp.intel.com> References: <20181226121124.1632-1-mironov.ivan@gmail.com> <20181226121124.1632-2-mironov.ivan@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id EDD666E2D3 for ; Thu, 27 Dec 2018 12:00:51 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id h50so15073570ede.5 for ; Thu, 27 Dec 2018 04:00:51 -0800 (PST) Content-Disposition: inline In-Reply-To: <20181226121124.1632-2-mironov.ivan@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ivan Mironov Cc: Maxime Ripard , Eugeniy Paltsev , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, saahriktu , David Airlie , Sean Paul List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBEZWMgMjYsIDIwMTggYXQgMDU6MTE6MjNQTSArMDUwMCwgSXZhbiBNaXJvbm92IHdy b3RlOgo+IFNETCAxLjIgc2V0cyBhbGwgZmllbGRzIHJlbGF0ZWQgdG8gdGhlIHBpeGVsIGZvcm1h dCB0byB6ZXJvIGluIHNvbWUKPiBjYXNlc1sxXS4gUHJpb3IgdG8gY29tbWl0IGRiMDVjNDgxOTc3 NTkgKCJkcm06IGZiLWhlbHBlcjogUmVqZWN0IGFsbAo+IHBpeGVsIGZvcm1hdCBjaGFuZ2luZyBy ZXF1ZXN0cyIpLCB0aGVyZSB3YXMgYW4gdW5pbnRlbnRpb25hbCB3b3JrYXJvdW5kCj4gZm9yIHRo aXMgdGhhdCBleGlzdGVkIGZvciBtb3JlIHRoYW4gYSBkZWNhZGUuIEZpcnN0IGluIGRldmljZS1z cGVjaWZpYyBEUk0KPiBkcml2ZXJzLCB0aGVuIGhlcmUgaW4gZHJtX2ZiX2hlbHBlci5jLgo+IAo+ IFByZXZpb3VzIGNvZGUgY29udGFpbmluZyB0aGlzIHdvcmthcm91bmQganVzdCBpZ25vcmVzIHBp eGVsIGZvcm1hdCBmaWVsZHMKPiBmcm9tIHVzZXJzcGFjZSBjb2RlLiBOb3QgYSBnb29kIHRoaW5n IGVpdGhlciwgYXMgdGhpcyB3YXksIGRyaXZlciBtYXkKPiBzaWxlbnRseSB1c2UgcGl4ZWwgZm9y bWF0IGRpZmZlcmVudCBmcm9tIHdoYXQgY2xpZW50IGFjdHVhbGx5IHJlcXVlc3RlZCwKPiBhbmQg dGhpcyBpbiB0dXJuIHdpbGwgbGVhZCB0byBkaXNwbGF5aW5nIGdhcmJhZ2Ugb24gdGhlIHNjcmVl bi4gSSB0aGluawo+IHRoYXQgcmV0dXJuaW5nIEVJTlZBTCB0byB1c2Vyc3BhY2UgaW4gdGhpcyBw YXJ0aWN1bGFyIGNhc2UgaXMgdGhlIHJpZ2h0Cj4gb3B0aW9uLCBzbyBJIGRlY2lkZWQgdG8gbGVm dCBjb2RlIGZyb20gcHJvYmxlbWF0aWMgY29tbWl0IHVudG91Y2hlZAo+IGluc3RlYWQgb2YganVz dCByZXZlcnRpbmcgaXQgZW50aXJlbHkuCj4gCj4gWzFdIFNETCAxLjIuMTUgc291cmNlIGNvZGUs IHNyYy92aWRlby9mYmNvbi9TRExfZmJ2aWRlby5jLAo+ICAgICBGQl9TZXRWaWRlb01vZGUoKQo+ IAo+IFJlcG9ydGVkLWJ5OiBzYWFocmlrdHUgPG1haWxAc2FhaHJpa3R1Lm9yZz4KPiBTdWdnZXN0 ZWQtYnk6IHNhYWhyaWt0dSA8bWFpbEBzYWFocmlrdHUub3JnPgo+IEZpeGVzOiBkYjA1YzQ4MTk3 NzU5ICgiZHJtOiBmYi1oZWxwZXI6IFJlamVjdCBhbGwgcGl4ZWwgZm9ybWF0IGNoYW5naW5nIHJl cXVlc3RzIikKPiBTaWduZWQtb2ZmLWJ5OiBJdmFuIE1pcm9ub3YgPG1pcm9ub3YuaXZhbkBnbWFp bC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMgfCAxNDYgKysr KysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDkzIGluc2Vy dGlvbnMoKyksIDUzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vZHJtX2ZiX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+IGlu ZGV4IGQzYWYwOThiMDkyMi4uYWZmNTc2YzNjNGZiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9kcm1fZmJfaGVscGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBl ci5jCj4gQEAgLTE2MjEsNiArMTYyMSw2NCBAQCBzdGF0aWMgYm9vbCBkcm1fZmJfcGl4ZWxfZm9y bWF0X2VxdWFsKGNvbnN0IHN0cnVjdCBmYl92YXJfc2NyZWVuaW5mbyAqdmFyXzEsCj4gIAkgICAg ICAgdmFyXzEtPnRyYW5zcC5tc2JfcmlnaHQgPT0gdmFyXzItPnRyYW5zcC5tc2JfcmlnaHQ7Cj4g IH0KPiAgCj4gK3N0YXRpYyB2b2lkIGRybV9mYl9oZWxwZXJfZmlsbF9waXhlbF9mbXQoc3RydWN0 IGZiX3Zhcl9zY3JlZW5pbmZvICp2YXIsCj4gKwkJCQkJIHU4IGRlcHRoKQo+ICt7Cj4gKwlzd2l0 Y2ggKGRlcHRoKSB7Cj4gKwljYXNlIDg6Cj4gKwkJdmFyLT5yZWQub2Zmc2V0ID0gMDsKPiArCQl2 YXItPmdyZWVuLm9mZnNldCA9IDA7Cj4gKwkJdmFyLT5ibHVlLm9mZnNldCA9IDA7Cj4gKwkJdmFy LT5yZWQubGVuZ3RoID0gODsgLyogOGJpdCBEQUMgKi8KPiArCQl2YXItPmdyZWVuLmxlbmd0aCA9 IDg7Cj4gKwkJdmFyLT5ibHVlLmxlbmd0aCA9IDg7Cj4gKwkJdmFyLT50cmFuc3Aub2Zmc2V0ID0g MDsKPiArCQl2YXItPnRyYW5zcC5sZW5ndGggPSAwOwo+ICsJCWJyZWFrOwo+ICsJY2FzZSAxNToK PiArCQl2YXItPnJlZC5vZmZzZXQgPSAxMDsKPiArCQl2YXItPmdyZWVuLm9mZnNldCA9IDU7Cj4g KwkJdmFyLT5ibHVlLm9mZnNldCA9IDA7Cj4gKwkJdmFyLT5yZWQubGVuZ3RoID0gNTsKPiArCQl2 YXItPmdyZWVuLmxlbmd0aCA9IDU7Cj4gKwkJdmFyLT5ibHVlLmxlbmd0aCA9IDU7Cj4gKwkJdmFy LT50cmFuc3Aub2Zmc2V0ID0gMTU7Cj4gKwkJdmFyLT50cmFuc3AubGVuZ3RoID0gMTsKPiArCQli cmVhazsKPiArCWNhc2UgMTY6Cj4gKwkJdmFyLT5yZWQub2Zmc2V0ID0gMTE7Cj4gKwkJdmFyLT5n cmVlbi5vZmZzZXQgPSA1Owo+ICsJCXZhci0+Ymx1ZS5vZmZzZXQgPSAwOwo+ICsJCXZhci0+cmVk Lmxlbmd0aCA9IDU7Cj4gKwkJdmFyLT5ncmVlbi5sZW5ndGggPSA2Owo+ICsJCXZhci0+Ymx1ZS5s ZW5ndGggPSA1Owo+ICsJCXZhci0+dHJhbnNwLm9mZnNldCA9IDA7Cj4gKwkJYnJlYWs7Cj4gKwlj YXNlIDI0Ogo+ICsJCXZhci0+cmVkLm9mZnNldCA9IDE2Owo+ICsJCXZhci0+Z3JlZW4ub2Zmc2V0 ID0gODsKPiArCQl2YXItPmJsdWUub2Zmc2V0ID0gMDsKPiArCQl2YXItPnJlZC5sZW5ndGggPSA4 Owo+ICsJCXZhci0+Z3JlZW4ubGVuZ3RoID0gODsKPiArCQl2YXItPmJsdWUubGVuZ3RoID0gODsK PiArCQl2YXItPnRyYW5zcC5vZmZzZXQgPSAwOwo+ICsJCXZhci0+dHJhbnNwLmxlbmd0aCA9IDA7 Cj4gKwkJYnJlYWs7Cj4gKwljYXNlIDMyOgo+ICsJCXZhci0+cmVkLm9mZnNldCA9IDE2Owo+ICsJ CXZhci0+Z3JlZW4ub2Zmc2V0ID0gODsKPiArCQl2YXItPmJsdWUub2Zmc2V0ID0gMDsKPiArCQl2 YXItPnJlZC5sZW5ndGggPSA4Owo+ICsJCXZhci0+Z3JlZW4ubGVuZ3RoID0gODsKPiArCQl2YXIt PmJsdWUubGVuZ3RoID0gODsKPiArCQl2YXItPnRyYW5zcC5vZmZzZXQgPSAyNDsKPiArCQl2YXIt PnRyYW5zcC5sZW5ndGggPSA4Owo+ICsJCWJyZWFrOwo+ICsJZGVmYXVsdDoKPiArCQlicmVhazsK PiArCX0KPiArfQo+ICsKPiAgLyoqCj4gICAqIGRybV9mYl9oZWxwZXJfY2hlY2tfdmFyIC0gaW1w bGVtZW50YXRpb24gZm9yICZmYl9vcHMuZmJfY2hlY2tfdmFyCj4gICAqIEB2YXI6IHNjcmVlbmlu Zm8gdG8gY2hlY2sKPiBAQCAtMTY1NCw2ICsxNzEyLDQwIEBAIGludCBkcm1fZmJfaGVscGVyX2No ZWNrX3ZhcihzdHJ1Y3QgZmJfdmFyX3NjcmVlbmluZm8gKnZhciwKPiAgCQlyZXR1cm4gLUVJTlZB TDsKPiAgCX0KPiAgCj4gKwkvKgo+ICsJICogV29ya2Fyb3VuZCBmb3IgU0RMIDEuMiwgd2hpY2gg aXMga25vd24gdG8gYmUgc2V0dGluZyBhbGwgcGl4ZWwgZm9ybWF0Cj4gKwkgKiBmaWVsZHMgdmFs dWVzIHRvIHplcm8gaW4gc29tZSBjYXNlcy4gV2UgdHJlYXQgdGhpcyBzaXR1YXRpb24gYXMgYQo+ ICsJICoga2luZCBvZiAidXNlIHNvbWUgcmVhc29uYWJsZSBhdXRvZGV0ZWN0ZWQgdmFsdWVzIi4K PiArCSAqLwo+ICsJaWYgKCF2YXItPnJlZC5vZmZzZXQgICAgICYmICF2YXItPmdyZWVuLm9mZnNl dCAgICAmJgo+ICsJICAgICF2YXItPmJsdWUub2Zmc2V0ICAgICYmICF2YXItPnRyYW5zcC5vZmZz ZXQgICAmJgo+ICsJICAgICF2YXItPnJlZC5sZW5ndGggICAgICYmICF2YXItPmdyZWVuLmxlbmd0 aCAgICAmJgo+ICsJICAgICF2YXItPmJsdWUubGVuZ3RoICAgICYmICF2YXItPnRyYW5zcC5sZW5n dGggICAmJgo+ICsJICAgICF2YXItPnJlZC5tc2JfcmlnaHQgICYmICF2YXItPmdyZWVuLm1zYl9y aWdodCAmJgo+ICsJICAgICF2YXItPmJsdWUubXNiX3JpZ2h0ICYmICF2YXItPnRyYW5zcC5tc2Jf cmlnaHQpIHsKPiArCQl1OCBkZXB0aDsKPiArCj4gKwkJLyoKPiArCQkgKiBUaGVyZSBpcyBubyB3 YXkgdG8gZ3Vlc3MgdGhlIHJpZ2h0IHZhbHVlIGZvciBkZXB0aCB3aGVuCj4gKwkJICogYnBwIGlz IDE2IG9yIDMyLiBTbyB3ZSBqdXN0IHJlc3RvcmUgdGhlIGJlaGF2aW91ciBwcmV2aW91c2x5Cj4g KwkJICogaW50cm9kdWNlZCBoZXJlIGJ5IGNvbW1pdCA3ODViOTNlZjhjMzA5LiBJbiBmYWN0LCB0 aGlzIHdhcwo+ICsJCSAqIGltcGxlbWVudGVkIGV2ZW4gZWFybGllciBpbiB2YXJpb3VzIGRldmlj ZSBkcml2ZXJzLgo+ICsJCSAqLwo+ICsJCXN3aXRjaCAodmFyLT5iaXRzX3Blcl9waXhlbCkgewo+ ICsJCWNhc2UgMTY6Cj4gKwkJCWRlcHRoID0gMTU7Cj4gKwkJCWJyZWFrOwo+ICsJCWNhc2UgMzI6 Cj4gKwkJCWRlcHRoID0gMjQ7Cj4gKwkJCWJyZWFrOwo+ICsJCWRlZmF1bHQ6Cj4gKwkJCWRlcHRo ID0gdmFyLT5iaXRzX3Blcl9waXhlbDsKPiArCQkJYnJlYWs7Cj4gKwkJfQoKVGhlIGd1ZXNzd29y ayBoZXJlIGxvb2tzIGZpc2h5LiBXZSBzaG91bGQgc3RpbGwgaGF2ZSB0aGUgZHJtLXNpZGUgZm9y bWF0LAphbmQgc2hvdWxkIHVzZSB0aGF0LiBPdGhlcndpc2UgdGhlIHBhdGNoZXMgbG9vayBnb29k IEkgdGhpbmssIGJ1dCB0aGV5Cm5lZWQgYSBGaXhlczogdGFnIGFuZCBjYzogc3RhYmxlIHNvIGJh Y2twb3J0ZXJzIGtub3cgd2hhdCB0byBkbyB3aXRoCnRoZXNlLgotRGFuaWVsCgo+ICsKPiArCQlk cm1fZmJfaGVscGVyX2ZpbGxfcGl4ZWxfZm10KHZhciwgZGVwdGgpOwo+ICsJfQo+ICsKPiAgCS8q Cj4gIAkgKiBkcm0gZmJkZXYgZW11bGF0aW9uIGRvZXNuJ3Qgc3VwcG9ydCBjaGFuZ2luZyB0aGUg cGl4ZWwgZm9ybWF0IGF0IGFsbCwKPiAgCSAqIHNvIHJlamVjdCBhbGwgcGl4ZWwgZm9ybWF0IGNo YW5naW5nIHJlcXVlc3RzLgo+IEBAIC0xOTY3LDU5ICsyMDU5LDcgQEAgdm9pZCBkcm1fZmJfaGVs cGVyX2ZpbGxfdmFyKHN0cnVjdCBmYl9pbmZvICppbmZvLCBzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAq ZmJfaGVscGUKPiAgCWluZm8tPnZhci55b2Zmc2V0ID0gMDsKPiAgCWluZm8tPnZhci5hY3RpdmF0 ZSA9IEZCX0FDVElWQVRFX05PVzsKPiAgCj4gLQlzd2l0Y2ggKGZiLT5mb3JtYXQtPmRlcHRoKSB7 Cj4gLQljYXNlIDg6Cj4gLQkJaW5mby0+dmFyLnJlZC5vZmZzZXQgPSAwOwo+IC0JCWluZm8tPnZh ci5ncmVlbi5vZmZzZXQgPSAwOwo+IC0JCWluZm8tPnZhci5ibHVlLm9mZnNldCA9IDA7Cj4gLQkJ aW5mby0+dmFyLnJlZC5sZW5ndGggPSA4OyAvKiA4Yml0IERBQyAqLwo+IC0JCWluZm8tPnZhci5n cmVlbi5sZW5ndGggPSA4Owo+IC0JCWluZm8tPnZhci5ibHVlLmxlbmd0aCA9IDg7Cj4gLQkJaW5m by0+dmFyLnRyYW5zcC5vZmZzZXQgPSAwOwo+IC0JCWluZm8tPnZhci50cmFuc3AubGVuZ3RoID0g MDsKPiAtCQlicmVhazsKPiAtCWNhc2UgMTU6Cj4gLQkJaW5mby0+dmFyLnJlZC5vZmZzZXQgPSAx MDsKPiAtCQlpbmZvLT52YXIuZ3JlZW4ub2Zmc2V0ID0gNTsKPiAtCQlpbmZvLT52YXIuYmx1ZS5v ZmZzZXQgPSAwOwo+IC0JCWluZm8tPnZhci5yZWQubGVuZ3RoID0gNTsKPiAtCQlpbmZvLT52YXIu Z3JlZW4ubGVuZ3RoID0gNTsKPiAtCQlpbmZvLT52YXIuYmx1ZS5sZW5ndGggPSA1Owo+IC0JCWlu Zm8tPnZhci50cmFuc3Aub2Zmc2V0ID0gMTU7Cj4gLQkJaW5mby0+dmFyLnRyYW5zcC5sZW5ndGgg PSAxOwo+IC0JCWJyZWFrOwo+IC0JY2FzZSAxNjoKPiAtCQlpbmZvLT52YXIucmVkLm9mZnNldCA9 IDExOwo+IC0JCWluZm8tPnZhci5ncmVlbi5vZmZzZXQgPSA1Owo+IC0JCWluZm8tPnZhci5ibHVl Lm9mZnNldCA9IDA7Cj4gLQkJaW5mby0+dmFyLnJlZC5sZW5ndGggPSA1Owo+IC0JCWluZm8tPnZh ci5ncmVlbi5sZW5ndGggPSA2Owo+IC0JCWluZm8tPnZhci5ibHVlLmxlbmd0aCA9IDU7Cj4gLQkJ aW5mby0+dmFyLnRyYW5zcC5vZmZzZXQgPSAwOwo+IC0JCWJyZWFrOwo+IC0JY2FzZSAyNDoKPiAt CQlpbmZvLT52YXIucmVkLm9mZnNldCA9IDE2Owo+IC0JCWluZm8tPnZhci5ncmVlbi5vZmZzZXQg PSA4Owo+IC0JCWluZm8tPnZhci5ibHVlLm9mZnNldCA9IDA7Cj4gLQkJaW5mby0+dmFyLnJlZC5s ZW5ndGggPSA4Owo+IC0JCWluZm8tPnZhci5ncmVlbi5sZW5ndGggPSA4Owo+IC0JCWluZm8tPnZh ci5ibHVlLmxlbmd0aCA9IDg7Cj4gLQkJaW5mby0+dmFyLnRyYW5zcC5vZmZzZXQgPSAwOwo+IC0J CWluZm8tPnZhci50cmFuc3AubGVuZ3RoID0gMDsKPiAtCQlicmVhazsKPiAtCWNhc2UgMzI6Cj4g LQkJaW5mby0+dmFyLnJlZC5vZmZzZXQgPSAxNjsKPiAtCQlpbmZvLT52YXIuZ3JlZW4ub2Zmc2V0 ID0gODsKPiAtCQlpbmZvLT52YXIuYmx1ZS5vZmZzZXQgPSAwOwo+IC0JCWluZm8tPnZhci5yZWQu bGVuZ3RoID0gODsKPiAtCQlpbmZvLT52YXIuZ3JlZW4ubGVuZ3RoID0gODsKPiAtCQlpbmZvLT52 YXIuYmx1ZS5sZW5ndGggPSA4Owo+IC0JCWluZm8tPnZhci50cmFuc3Aub2Zmc2V0ID0gMjQ7Cj4g LQkJaW5mby0+dmFyLnRyYW5zcC5sZW5ndGggPSA4Owo+IC0JCWJyZWFrOwo+IC0JZGVmYXVsdDoK PiAtCQlicmVhazsKPiAtCX0KPiArCWRybV9mYl9oZWxwZXJfZmlsbF9waXhlbF9mbXQoJmluZm8t PnZhciwgZmItPmZvcm1hdC0+ZGVwdGgpOwo+ICAKPiAgCWluZm8tPnZhci54cmVzID0gZmJfd2lk dGg7Cj4gIAlpbmZvLT52YXIueXJlcyA9IGZiX2hlaWdodDsKPiAtLSAKPiAyLjIwLjEKPiAKCi0t IApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRw Oi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK