From: Christoph Hellwig Subject: Re: [git pull] device mapper changes for 4.21 Date: Wed, 2 Jan 2019 23:27:54 -0800 Message-ID: <20190103072754.GA2667@infradead.org> References: <20181227160944.GA12190@redhat.com> <20181230090646.GB1022@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Linus Torvalds Cc: Sweet Tea , linux-block , AliOS system security , Nikos Tsironis , Mike Snitzer , Eric Biggers , Heinz Mauelshagen , Shenghui Wang , Christoph Hellwig , dm-devel@redhat.com, Mikulas Patocka , Jaegeuk Kim , wuzhouhui , Colin Ian King , Milan Broz , Alasdair G Kergon List-Id: dm-devel.ids On Sun, Dec 30, 2018 at 04:25:46PM -0800, Linus Torvalds wrote: > On Sun, Dec 30, 2018 at 11:15 AM Mikulas Patocka wrote: > > > > But you're right that 2TiB devices are common and that perhaps this option > > should go away. > > 2TiB devices are definitely not common in the one situation where this > option might matter: small embedded devices. > > I don't think the cost of 64 bit is in the arithmetic, but it might be > in some of the data structures. > > But my gut feel is that it probably doesn't much matter, and we could > get rid of the config option without anybody ever noticing. I don't > think we have that many data structures with 'sector_t' in them. > > We might try to first just force the option on, and see if anybody even cares. Our smallest embedded devices use raw flash using the MTD subsystem, and even that is using 64-bit size types everywhere. So I'd be really surprised if it is an issue. > > Linus ---end quoted text---