From: "StDenis, Tom" Subject: [PATCH] add missing mutex lock to amdgpu_get_xgmi_hive() (v2) Date: Mon, 7 Jan 2019 15:16:28 +0000 Message-ID: <20190107151620.11701-1-tom.stdenis@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" Cc: "StDenis, Tom" djI6IE1vdmUgbG9ja3MgYXJvdW5kIGluIG90aGVyIGZ1bmN0aW9ucyBzbyB0aGF0IHRoaXMKZnVu Y3Rpb24gY2FuIHN0YW5kIG9uIGl0cyBvd24uICBBbHNvIG9ubHkgaG9sZCB0aGUgaGl2ZQpzcGVj aWZpYyBsb2NrIGZvciBhZGQvcmVtb3ZlIGRldmljZSBpbnN0ZWFkIG9mIHRoZSBkcml2ZXIKZ2xv YmFsIGxvY2sgc28geW91IGNhbid0IGFkZC9yZW1vdmUgZGV2aWNlcyBpbiBwYXJhbGxlbCBmcm9t Cm9uZSBoaXZlLgoKU2lnbmVkLW9mZi1ieTogVG9tIFN0IERlbmlzIDx0b20uc3RkZW5pc0BhbWQu Y29tPgotLS0KIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYyB8ICAy ICstCiBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfeGdtaS5jICAgfCAzNiArKysr KysrKysrKysrKy0tLS0tLS0tCiBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfeGdt aS5oICAgfCAgMiArLQogMyBmaWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCAxNSBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVf ZGV2aWNlLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMKaW5k ZXggMzlkNWQwNThiMmM3Li4xM2Q4ZTJhZDJmN2EgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9hbWRncHVfZGV2aWNlLmMKQEAgLTM1MjUsNyArMzUyNSw3IEBAIGludCBhbWRncHVfZGV2 aWNlX2dwdV9yZWNvdmVyKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LAogCSAqIGJ5IGRpZmZl cmVudCBub2Rlcy4gTm8gcG9pbnQgYWxzbyBzaW5jZSB0aGUgb25lIG5vZGUgYWxyZWFkeSBleGVj dXRpbmcKIAkgKiByZXNldCB3aWxsIGFsc28gcmVzZXQgYWxsIHRoZSBvdGhlciBub2RlcyBpbiB0 aGUgaGl2ZS4KIAkgKi8KLQloaXZlID0gYW1kZ3B1X2dldF94Z21pX2hpdmUoYWRldik7CisJaGl2 ZSA9IGFtZGdwdV9nZXRfeGdtaV9oaXZlKGFkZXYsIDApOwogCWlmIChoaXZlICYmIGFkZXYtPmdt Yy54Z21pLm51bV9waHlzaWNhbF9ub2RlcyA+IDEgJiYKIAkgICAgIW11dGV4X3RyeWxvY2soJmhp dmUtPmhpdmVfbG9jaykpCiAJCXJldHVybiAwOwpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvYW1kZ3B1X3hnbWkuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2Ft ZGdwdV94Z21pLmMKaW5kZXggOGE4YmM2MGNiNmI0Li5lYmY1MDgwOTQ4NWYgMTAwNjQ0Ci0tLSBh L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV94Z21pLmMKKysrIGIvZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3hnbWkuYwpAQCAtNDAsMjYgKzQwLDM5IEBAIHZvaWQg KmFtZGdwdV94Z21pX2hpdmVfdHJ5X2xvY2soc3RydWN0IGFtZGdwdV9oaXZlX2luZm8gKmhpdmUp CiAJcmV0dXJuICZoaXZlLT5kZXZpY2VfbGlzdDsKIH0KIAotc3RydWN0IGFtZGdwdV9oaXZlX2lu Zm8gKmFtZGdwdV9nZXRfeGdtaV9oaXZlKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQorc3Ry dWN0IGFtZGdwdV9oaXZlX2luZm8gKmFtZGdwdV9nZXRfeGdtaV9oaXZlKHN0cnVjdCBhbWRncHVf ZGV2aWNlICphZGV2LCBpbnQgbG9jaykKIHsKIAlpbnQgaTsKIAlzdHJ1Y3QgYW1kZ3B1X2hpdmVf aW5mbyAqdG1wOwogCiAJaWYgKCFhZGV2LT5nbWMueGdtaS5oaXZlX2lkKQogCQlyZXR1cm4gTlVM TDsKKworCW11dGV4X2xvY2soJnhnbWlfbXV0ZXgpOworCiAJZm9yIChpID0gMCA7IGkgPCBoaXZl X2NvdW50OyArK2kpIHsKIAkJdG1wID0gJnhnbWlfaGl2ZXNbaV07Ci0JCWlmICh0bXAtPmhpdmVf aWQgPT0gYWRldi0+Z21jLnhnbWkuaGl2ZV9pZCkKKwkJaWYgKHRtcC0+aGl2ZV9pZCA9PSBhZGV2 LT5nbWMueGdtaS5oaXZlX2lkKSB7CisJCQlpZiAobG9jaykKKwkJCQltdXRleF9sb2NrKCZ0bXAt PmhpdmVfbG9jayk7CisJCQltdXRleF91bmxvY2soJnhnbWlfbXV0ZXgpOwogCQkJcmV0dXJuIHRt cDsKKwkJfQogCX0KLQlpZiAoaSA+PSBBTURHUFVfTUFYX1hHTUlfSElWRSkKKwlpZiAoaSA+PSBB TURHUFVfTUFYX1hHTUlfSElWRSkgeworCQltdXRleF91bmxvY2soJnhnbWlfbXV0ZXgpOwogCQly ZXR1cm4gTlVMTDsKKwl9CiAKIAkvKiBpbml0aWFsaXplIG5ldyBoaXZlIGlmIG5vdCBleGlzdCAq LwogCXRtcCA9ICZ4Z21pX2hpdmVzW2hpdmVfY291bnQrK107CiAJdG1wLT5oaXZlX2lkID0gYWRl di0+Z21jLnhnbWkuaGl2ZV9pZDsKIAlJTklUX0xJU1RfSEVBRCgmdG1wLT5kZXZpY2VfbGlzdCk7 CiAJbXV0ZXhfaW5pdCgmdG1wLT5oaXZlX2xvY2spOworCWlmIChsb2NrKQorCQltdXRleF9sb2Nr KCZ0bXAtPmhpdmVfbG9jayk7CisKKwltdXRleF91bmxvY2soJnhnbWlfbXV0ZXgpOwogCiAJcmV0 dXJuIHRtcDsKIH0KQEAgLTExMSw4ICsxMjQsOCBAQCBpbnQgYW1kZ3B1X3hnbWlfYWRkX2Rldmlj ZShzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldikKIAkJcmV0dXJuIHJldDsKIAl9CiAKLQltdXRl eF9sb2NrKCZ4Z21pX211dGV4KTsKLQloaXZlID0gYW1kZ3B1X2dldF94Z21pX2hpdmUoYWRldik7 CisJLyogZmluZCBoaXZlIGFuZCB0YWtlIGxvY2sgKi8KKwloaXZlID0gYW1kZ3B1X2dldF94Z21p X2hpdmUoYWRldiwgMSk7CiAJaWYgKCFoaXZlKQogCQlnb3RvIGV4aXQ7CiAKQEAgLTE0Miw4ICsx NTUsOCBAQCBpbnQgYW1kZ3B1X3hnbWlfYWRkX2RldmljZShzdHJ1Y3QgYW1kZ3B1X2RldmljZSAq YWRldikKIAkJCWJyZWFrOwogCX0KIAorCW11dGV4X3VubG9jaygmaGl2ZS0+aGl2ZV9sb2NrKTsK IGV4aXQ6Ci0JbXV0ZXhfdW5sb2NrKCZ4Z21pX211dGV4KTsKIAlyZXR1cm4gcmV0OwogfQogCkBA IC0xNTQsMTUgKzE2NywxMiBAQCB2b2lkIGFtZGdwdV94Z21pX3JlbW92ZV9kZXZpY2Uoc3RydWN0 IGFtZGdwdV9kZXZpY2UgKmFkZXYpCiAJaWYgKCFhZGV2LT5nbWMueGdtaS5zdXBwb3J0ZWQpCiAJ CXJldHVybjsKIAotCW11dGV4X2xvY2soJnhnbWlfbXV0ZXgpOwotCi0JaGl2ZSA9IGFtZGdwdV9n ZXRfeGdtaV9oaXZlKGFkZXYpOworCWhpdmUgPSBhbWRncHVfZ2V0X3hnbWlfaGl2ZShhZGV2LCAx KTsKIAlpZiAoIWhpdmUpCi0JCWdvdG8gZXhpdDsKKwkJcmV0dXJuOwogCiAJaWYgKCEoaGl2ZS0+ bnVtYmVyX2RldmljZXMtLSkpCiAJCW11dGV4X2Rlc3Ryb3koJmhpdmUtPmhpdmVfbG9jayk7Ci0K LWV4aXQ6Ci0JbXV0ZXhfdW5sb2NrKCZ4Z21pX211dGV4KTsKKwllbHNlCisJCW11dGV4X3VubG9j aygmaGl2ZS0+aGl2ZV9sb2NrKTsKIH0KZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdV94Z21pLmggYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVf eGdtaS5oCmluZGV4IDYxNTFlYjljOGFkMy4uOGQ3OTg0ODQ0MTc0IDEwMDY0NAotLS0gYS9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfeGdtaS5oCisrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1kZ3B1L2FtZGdwdV94Z21pLmgKQEAgLTMyLDcgKzMyLDcgQEAgc3RydWN0IGFtZGdw dV9oaXZlX2luZm8gewogCXN0cnVjdCBtdXRleCBoaXZlX2xvY2s7CiB9OwogCi1zdHJ1Y3QgYW1k Z3B1X2hpdmVfaW5mbyAqYW1kZ3B1X2dldF94Z21pX2hpdmUoc3RydWN0IGFtZGdwdV9kZXZpY2Ug KmFkZXYpOworc3RydWN0IGFtZGdwdV9oaXZlX2luZm8gKmFtZGdwdV9nZXRfeGdtaV9oaXZlKHN0 cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LCBpbnQgbG9jayk7CiBpbnQgYW1kZ3B1X3hnbWlfdXBk YXRlX3RvcG9sb2d5KHN0cnVjdCBhbWRncHVfaGl2ZV9pbmZvICpoaXZlLCBzdHJ1Y3QgYW1kZ3B1 X2RldmljZSAqYWRldik7CiBpbnQgYW1kZ3B1X3hnbWlfYWRkX2RldmljZShzdHJ1Y3QgYW1kZ3B1 X2RldmljZSAqYWRldik7CiB2b2lkIGFtZGdwdV94Z21pX3JlbW92ZV9kZXZpY2Uoc3RydWN0IGFt ZGdwdV9kZXZpY2UgKmFkZXYpOwotLSAKMi4xNy4yCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2FtZC1nZngK