Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 09 Jan 2019 18:06:38 -0000 Received: from mga01.intel.com ([192.55.52.88]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1ghIFR-0007GL-Bx for speck@linutronix.de; Wed, 09 Jan 2019 19:06:37 +0100 Date: Wed, 9 Jan 2019 10:06:33 -0800 From: Andi Kleen Subject: [MODERATED] Re: [PATCH v3 00/32] MDSv3 12 Message-ID: <20190109180633.GT6118@tassilo.jf.intel.com> References: <20190109173122.GP6118@tassilo.jf.intel.com> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: > > I don't know what parts of Intel you're talking with, but the parts > > I talk with say that it's likely some CPUs won't be able to do the > > microcode update for VERW. > > Right. And they say that because nobody cares. There are two different cases: - Some old CPUs won't get any support. That's the "nobody cares" case. I already don't support those in the patch (e.g. pre Nehalem) - Some newer CPUs where people care and which are widely used, but they ran out of space for the patch. So they would like to, but can't. That's the cases I'm trying to handle. > I will not take that crazy per-microarchitecture software sequence > THAT DOESN'T EVEN WORK. Even on the micro-architectures it is designed > for, virtualization and SMM break it. Virtualization works, as long as the Hypervisor supports it. I fixed KVM to do so (it's in the patchkit). Basically it needs to always flush on entry if VERW is not exposed to the guest. This ensures that even if the sequence is interrupted, a clear happens anyways. SMM is a problem on CPUs without microcode update. It could be handled by a BIOS update (and some vendors might do that). However SMM is quite rare and normally not user controllable (with the recent fixes we did for retpoline) so I think it falls into your "theoretical only / uninteresting" cases bucket. Does that change anything in your opinion? -Andi