Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 09 Jan 2019 18:20:24 -0000 Received: from mga09.intel.com ([134.134.136.24]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1ghINW-0007Vr-Pk for speck@linutronix.de; Wed, 09 Jan 2019 19:15:00 +0100 Date: Wed, 9 Jan 2019 10:14:55 -0800 From: Andi Kleen Subject: [MODERATED] Re: [PATCH v3 00/32] MDSv3 12 Message-ID: <20190109181455.GU6118@tassilo.jf.intel.com> References: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: On Wed, Jan 09, 2019 at 09:35:22AM -0800, speck for Linus Torvalds wrote: > On Wed, Jan 9, 2019 at 3:01 AM speck for Andi Kleen wrote: > > > > VERW is not done unconditionally because it doesn't allow reporting > > the correct status in the vulnerabilities file, which I consider important. > > Instead we now have a mds=verw option that can be set as needed, > > but is reported explicitely in the mitigation status. > > I also don't see what the logic of this is AT ALL. > > "Reporting" has absolutely nothign to do with "use VERW". The fact > that you link the two is crazy. > > The rule for VERW should be simple: use VERW if the CPU doesn't have > the NOMDS bit set (or whatever the name is today). The case that worried me is that with this we would end up with some systems which are actually protected, but report vulnerable. So you could not simply say "If the sysfs file says you're vulnerable you're vulnerable" but would need "If the sysfs file says you're vulnerable, you're vulnerable except " Doesn't seem like a clear message for me. With the current scheme at least only the people who see vulnerable have to read the documentation and figure out the VMWare mess. -Andi