Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 09 Jan 2019 18:42:20 -0000 Received: from mga01.intel.com ([192.55.52.88]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1ghIny-0000CK-QQ for speck@linutronix.de; Wed, 09 Jan 2019 19:42:19 +0100 Date: Wed, 9 Jan 2019 10:42:16 -0800 From: Andi Kleen Subject: [MODERATED] Re: [PATCH v3 00/32] MDSv3 12 Message-ID: <20190109184216.GV6118@tassilo.jf.intel.com> References: <20190109171804.GV23427@char.us.oracle.com> <20190109174127.GS6118@tassilo.jf.intel.com> <20190109180917.GX23427@char.us.oracle.com> MIME-Version: 1.0 In-Reply-To: <20190109180917.GX23427@char.us.oracle.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: On Wed, Jan 09, 2019 at 01:09:17PM -0500, speck for Konrad Rzeszutek Wilk wrote: > On Wed, Jan 09, 2019 at 09:41:27AM -0800, speck for Andi Kleen wrote: > > On Wed, Jan 09, 2019 at 12:18:04PM -0500, speck for Konrad Rzeszutek Wilk wrote: > > > On Thu, Dec 20, 2018 at 04:27:10PM -0800, speck for Andi Kleen wrote: > > > > From: Andi Kleen > > > > Subject: MDSv3 > > > > > > > > Here's a new version of flushing CPU buffers for group 4. > > > > > > Could you send also a git bundle of them please? The titles of them is not in sync with the XX/YY. > > > I can probably figure out the right flow but it would help (also helps in review). > > > > > > Thank you! > > > > > > And one more thing - I see 'MB' and 'MDS' and also 'MSB' (Microarchitectual > > > Store Buffer). > > > > The code all uses MDS / mds > > > > The only thing called MB_* is the cpuid bit because that is the name > > the documentation uses. > > Could you confirm that please? The doc in Keybase and which has been circulating > has it as 'MD_CLEAR'. Or maybe I am behind a version or too. Let me check. Frankly I don't care really. Please do some real code review instead of bike shedding. -Andi