Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 508E8C43444 for ; Thu, 10 Jan 2019 12:47:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B28A2173B for ; Thu, 10 Jan 2019 12:47:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727391AbfAJMrH convert rfc822-to-8bit (ORCPT ); Thu, 10 Jan 2019 07:47:07 -0500 Received: from 6.mo4.mail-out.ovh.net ([188.165.36.253]:32822 "EHLO 6.mo4.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727704AbfAJMrF (ORCPT ); Thu, 10 Jan 2019 07:47:05 -0500 X-Greylist: delayed 926 seconds by postgrey-1.27 at vger.kernel.org; Thu, 10 Jan 2019 07:47:04 EST Received: from player762.ha.ovh.net (unknown [10.109.143.216]) by mo4.mail-out.ovh.net (Postfix) with ESMTP id 90F471C98A2 for ; Thu, 10 Jan 2019 13:31:37 +0100 (CET) Received: from kaod.org (lns-bzn-46-82-253-208-248.adsl.proxad.net [82.253.208.248]) (Authenticated sender: groug@kaod.org) by player762.ha.ovh.net (Postfix) with ESMTPSA id 7729C18553D2; Thu, 10 Jan 2019 12:31:30 +0000 (UTC) Date: Thu, 10 Jan 2019 13:31:25 +0100 From: Greg Kurz To: Michael Ellerman Cc: Frederic Barrat , aik@ozlabs.ru, linuxppc-dev@lists.ozlabs.org, stable@vger.kernel.org, andrew.donnellan@au1.ibm.com Subject: Re: [PATCH] powerpc/powernv/npu: Fix oops in pnv_try_setup_npu_table_group() Message-ID: <20190110133125.572e323e@bahia.lan> In-Reply-To: <87h8egsnrs.fsf@concordia.ellerman.id.au> References: <20190109151342.19953-1-fbarrat@linux.ibm.com> <20190109172529.10c45ce6@bahia.lan> <41fc8267-7a40-a3e0-df39-773771b661d2@linux.ibm.com> <20190109175622.75525ff8@bahia.lan> <87h8egsnrs.fsf@concordia.ellerman.id.au> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Ovh-Tracer-Id: 4262938523217009073 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtledrfeefgdegudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, 10 Jan 2019 23:25:11 +1100 Michael Ellerman wrote: > Greg Kurz writes: > > On Wed, 9 Jan 2019 17:45:53 +0100 > > Frederic Barrat wrote: > > > >> Le 09/01/2019 à 17:25, Greg Kurz a écrit : > >> > On Wed, 9 Jan 2019 16:13:42 +0100 > >> > Frederic Barrat wrote: > >> > > >> >> With a recent change around IOMMU group, a system with an opencapi > >> >> adapter is no longer booting and we get a kernel oops: > >> >> > >> >> BUG: Kernel NULL pointer dereference at 0x00000028 > >> >> Faulting instruction address: 0xc0000000000aa38c > >> >> Oops: Kernel access of bad area, sig: 7 [#1] > >> >> LE SMP NR_CPUS=2048 NUMA PowerNV > >> >> Modules linked in: > >> >> CPU: 5 PID: 1 Comm: swapper/4 Not tainted 5.0.0-rc1-fxb-00001-g3bd6e94bec12 > >> >> NIP: c0000000000aa38c LR: c0000000000a6608 CTR: c000000000097480 > >> >> REGS: c000000005783700 TRAP: 0300 Not tainted (5.0.0-rc1-fxb-00001-g3bd6 > >> >> MSR: 9000000002009033 CR: 28000228 XER: 20 > >> >> CFAR: c0000000000a6604 DAR: 0000000000000028 DSISR: 00080000 IRQMASK: 0 > >> >> GPR00: c0000000000a6608 c000000005783990 c000000001036100 c0000007bf761860 > >> >> GPR04: 0000000000000000 c000000005783834 0000000000000000 0000000000000000 > >> >> GPR08: 69626d2c6e707500 0000000000000000 0000000000000000 9000000002001003 > >> >> GPR12: 0000000000000000 c0000007bfff8300 c000000000010450 0000000000000000 > >> >> GPR16: c000000000ced938 0000000000000100 c000000000ced948 00000000000a0000 > >> >> GPR20: 00000000000bfffe c000000000ced9a8 0000000000000200 c000000000ced978 > >> >> GPR24: 00000000006080c0 c000000716d09828 c00000002e6fd000 0000000000000000 > >> >> GPR28: c0000007bf4aff68 c0000007bf8d0080 c000000000f23938 c0000007bf761860 > >> >> NIP [c0000000000aa38c] pnv_try_setup_npu_table_group+0x1c/0x1a0 > >> >> LR [c0000000000a6608] pnv_pci_ioda_fixup+0x1f8/0x660 > >> >> Call Trace: > >> >> [c000000005783990] [c0000000000aa3d0] pnv_try_setup_npu_table_group+0x60/0x > >> >> [c0000000057839d0] [c0000000000a661c] pnv_pci_ioda_fixup+0x20c/0x660 > >> >> [c000000005783ab0] [c000000000e1d4c0] pcibios_resource_survey+0x2c8/0x31c > >> >> [c000000005783b90] [c000000000e1caf4] pcibios_init+0xb0/0xe4 > >> >> [c000000005783c10] [c000000000010054] do_one_initcall+0x64/0x264 > >> >> [c000000005783ce0] [c000000000e1132c] kernel_init_freeable+0x36c/0x468 > >> >> [c000000005783db0] [c000000000010474] kernel_init+0x2c/0x148 > >> >> [c000000005783e20] [c00000000000b794] ret_from_kernel_thread+0x5c/0x68 > >> >> > >> >> An opencapi device is using a device PE, so the current code breaks > >> >> because pe->pbus is not defined. > >> >> > >> >> More generally, there's no need to define an IOMMU group for opencapi, > >> >> as the device sends real addresses directly (admittedly, the > >> >> virtualization story is yet to be written). So let's fix it by > >> > > >> > Current plan is to go for mediated VFIO. The real HW stays under the control > >> > of the host ocxl driver, and we still don't need an IOMMU group. > >> > > >> >> skipping the IOMMU group setup for opencapi PHBs. > >> >> > >> >> Fixes: 0bd971676e68 ("powerpc/powernv/npu: Add compound IOMMU groups") > >> >> Signed-off-by: Frederic Barrat > >> >> --- > >> > > >> > Reviewed-by: Greg Kurz > >> > > >> > and > >> > > >> > Cc: stable@vger.kernel.org # v4.20 > >> > >> Thanks for the review! But why did you add stable? that problem is only > >> seen on 5.0-rc1, isn't it? > > > > Based on the fact that 0bd971676e68 was committed in 4.20... but I haven't > > tested :) > > It was committed to a branch based off 4.20-rc2, but it wasn't merged > into the 4.20 release. > > $ git describe --match "v[0-9]*" --contains 0bd971676e68 > v5.0-rc1~137^2~15 > > So it doesn't need to go to stable. > Yeah I realized that afterwards, sorry for the noise and Happy New Year :) > cheers