From: Mike Snitzer Subject: Re: dm-crypt: Fix parsing of extended IV arguments. Date: Thu, 10 Jan 2019 15:27:35 -0500 Message-ID: <20190110202735.GB1169@redhat.com> References: <20190109105714.3606-1-gmazyland@gmail.com> <20190110191825.GA936@redhat.com> <43e7c378-b87e-03d9-ceb7-348ba84c71e1@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <43e7c378-b87e-03d9-ceb7-348ba84c71e1@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Milan Broz Cc: dm-devel@redhat.com, mpatocka@redhat.com List-Id: dm-devel.ids On Thu, Jan 10 2019 at 2:50pm -0500, Milan Broz wrote: > On 10/01/2019 20:18, Mike Snitzer wrote: > > On Wed, Jan 09 2019 at 5:57am -0500, > > Milan Broz wrote: > > >> This patch fixes the dm-crypt constructor to ignore additional dash in IV options and also removes > >> bogus warning (that is ignored anyway). > >> > >> [This patch should go into stable tree as well.] > > > > Rather than this it'd be useful to just be more explicit, e.g.: > > There is no single reference commit. > > The new capi: was introduced in > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/md/dm-crypt.c?id=33d2f09fcb357fd1861c4959d1d3505492bf91f8 > > but I think the second part applies even to older kernel, but not sure it makes sense to fix it there (I guess not)... > > So perhaps the best is to apply it to stable kernel >= 4.12 OK, now staged, I tweaked your header though because (like your email reply) it was lacking proper wrapping. See: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-5.0&id=1856b9f7bcc8e9bdcccc360aabb56fbd4dd6c565 Thanks, Mike