Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13CBBC43444 for ; Fri, 11 Jan 2019 14:26:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC2F020874 for ; Fri, 11 Jan 2019 14:26:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547216802; bh=xguMtctK6F4fsqcmC4g3wDGgmz4Veasv2R0VDyhWB7Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=V348leV9ygdqAI3Y7EuiVJBoTSYsON/Ao8HZJo2lLqIoCPnLyr2vZp3tNpaBubfRT kisK3JB6XtxGhbadxNIP8Ke0HqIHBaAuVSozeIzrm8sjN3yfJgMYzV3fdblOy7gX7u kn0Mw8tW4f0bXKNkewDKfKrBbMCdbI/WzQVKKIlw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732572AbfAKO0l (ORCPT ); Fri, 11 Jan 2019 09:26:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:34172 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387897AbfAKORo (ORCPT ); Fri, 11 Jan 2019 09:17:44 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BBF102177B; Fri, 11 Jan 2019 14:17:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547216264; bh=xguMtctK6F4fsqcmC4g3wDGgmz4Veasv2R0VDyhWB7Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fXRujlhU45/E0ZEk2oF9d4l1gG+ej6AUB+mLO333BkNINNOIFmB36RsVbqzofepAd 275aI9mKb4Woz2Ev5H8IfX0D7Ul083fbCdwbOTB2GwpyguuTqmmkvWhQtDMXJinbRi dkUjps1ld2Ode3mb5MUC74x08euPqiT7HpfdPfPw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mohan Kumar , Dara Ramesh , Sameer Pujar , Takashi Iwai Subject: [PATCH 4.4 35/88] ALSA: hda/tegra: clear pending irq handlers Date: Fri, 11 Jan 2019 15:08:04 +0100 Message-Id: <20190111131051.065992594@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190111131045.137499039@linuxfoundation.org> References: <20190111131045.137499039@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sameer Pujar commit 63d2a9ec310d8bcc955574220d4631aa55c1a80c upstream. Even after disabling interrupts on the module, it could be possible that irq handlers are still running. System hang is seen during suspend path. It was found that, there were pending writes on the HDA bus and clock was disabled by that time. Above mentioned issue is fixed by clearing any pending irq handlers before disabling clocks and returning from hda suspend. Suggested-by: Mohan Kumar Suggested-by: Dara Ramesh Signed-off-by: Sameer Pujar Cc: Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/hda_tegra.c | 2 ++ 1 file changed, 2 insertions(+) --- a/sound/pci/hda/hda_tegra.c +++ b/sound/pci/hda/hda_tegra.c @@ -249,10 +249,12 @@ static int hda_tegra_suspend(struct devi struct snd_card *card = dev_get_drvdata(dev); struct azx *chip = card->private_data; struct hda_tegra *hda = container_of(chip, struct hda_tegra, chip); + struct hdac_bus *bus = azx_bus(chip); snd_power_change_state(card, SNDRV_CTL_POWER_D3hot); azx_stop_chip(chip); + synchronize_irq(bus->irq); azx_enter_link_reset(chip); hda_tegra_disable_clocks(hda);