Received: from eggs.gnu.org ([209.51.188.92]:46819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gi1HM-0003f2-BG for qemu-devel@nongnu.org; Fri, 11 Jan 2019 13:11:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gi1HL-0007Db-KM for qemu-devel@nongnu.org; Fri, 11 Jan 2019 13:11:36 -0500 Received: from smtp03.citrix.com ([162.221.156.55]:57315) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gi1HL-0007Cz-CN for qemu-devel@nongnu.org; Fri, 11 Jan 2019 13:11:35 -0500 Date: Fri, 11 Jan 2019 18:11:27 +0000 From: Anthony PERARD Message-ID: <20190111181127.GN1508@perard.uk.xensource.com> References: <20190111180941.6198-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20190111180941.6198-1-anthony.perard@citrix.com> Subject: Re: [Qemu-devel] [PATCH] xen: Fix event channel interface for XenDevice-s List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Stefano Stabellini , Paul Durrant , "open list:X86" On Fri, Jan 11, 2019 at 06:09:41PM +0000, Anthony PERARD wrote: > Patch "xen: add event channel interface for XenDevice-s" makes use of > the type xenevtchn_port_or_error_t, but this isn't avaiable before Xen > 4.7. Also the function xen_device_bind_event_channel assign the return > value of xenevtchn_bind_interdomain to channel->local_port but check the > result for error with xendev->local_port. > > Fix by: > - removing local_port from struct XenDevice as it isn't use anywere. > - adding a compatibility typedef for xenevtchn_port_or_error_t for Xen > 4.6 and earlier. > > As extra, replace the type of XenEventChannel->local_port by > evtchn_port_t. > > Signed-off-by: Anthony PERARD Notes: This patch fix "xen: add event channel interface for XenDevice-s" that isn't commited yet, of the patch series "Xen PV backend 'qdevification'". -- Anthony PERARD