Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60C29C43387 for ; Fri, 11 Jan 2019 20:54:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30F3321783 for ; Fri, 11 Jan 2019 20:54:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547240099; bh=uJ58G8MOdMXiSbvP0FF2XKaXP1dBMrMKoFAV14tpgBk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=UQsViDhDFJMrMCJvQl4Z0kyJHxxfBoEJAibNwa3eBgeBtYuKKluGza/xid37eL9Pm CjiamTe6TjKZ+ATlA8j97cGxdIzf40DUVsyYMR3jP/cwLrGEJ664zAO6TzvC6DoRnp 4VK+r+69AGrtQ33wshfcbi0nuLneIsbaLKY+fkiE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726595AbfAKUy6 (ORCPT ); Fri, 11 Jan 2019 15:54:58 -0500 Received: from mail-yw1-f49.google.com ([209.85.161.49]:34260 "EHLO mail-yw1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726587AbfAKUy4 (ORCPT ); Fri, 11 Jan 2019 15:54:56 -0500 Received: by mail-yw1-f49.google.com with SMTP id g75so6352106ywb.1 for ; Fri, 11 Jan 2019 12:54:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=efjfyMCIZBSfBd49Ti85ALyKVE5OCTwcnEDgywG1D6o=; b=gFv0DlT5lhbCwdz/4DjdwXEmJIHy7/eNygDAKNGgKUzPIMbZyAWNCjyT2LBDDG/kUW e4ziFmBSSmQ85SABEdd1TaNq3vSAB/9M0ErDdimxrt8/InBk14DjHU9hJEwEjewQWWN3 Nd90D/2OjgbmTykZ+rdt2ihsHBOjwdpFoUnqadjeHjhDY4Pmivm0favhjRwhE77osC4W /GxGKr9sQ3gzi/r7kctyeZ8g+RYtdwpfbtL5cqnkPV1E0L7cR70fqvqHd8YcHhO5gLQl +QLOn7RNsAKVmF7TPsaWLlDOPQpm3OEddG9NHfc5h+POz3BraQpSSXP9DDOOsCk+oAK+ mrLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=efjfyMCIZBSfBd49Ti85ALyKVE5OCTwcnEDgywG1D6o=; b=N+gd37zyR5KDO5685yy/fdIN7fSQOypy7G0izVODeLXBM5WM2RJCCeJVpqYOthfuR+ sWe/PH3vuFeS4eZi92Ij8HdxyoksXtHq7+Xd1Dt46eCu1Ccu/e5uuMQmbDXw+GfX/Qcc dTe5L5rnJjd8MMfsDXpVZ4SwOAYsQzkr7vN+q2VFWLvl6itt67m7uERkyhuiMqYnVzFU iEmObbs0Vq0sF9TwretxSjnL1CQI+fh5P3P004sIuvrrxnTcn7rWBtuyvnTyuA7OazSn HMCQkeo5a6N1fvxWBnLsW+6BVX5mwWi26vFiVh/uxkbPzWRoPrtYkN8S1tqhz67c+BE9 0WkA== X-Gm-Message-State: AJcUukdQgr5O8eRyakVn/LbldrxFg+uZsNg4XE6BkyXu+oMBPYrGqVJs TH5tDdB7vQPVGpuIsAh07xQ= X-Google-Smtp-Source: ALg8bN5p2Jc72fmX6PKgpWlzUrHLe1uZoU+Vj7mE1Ee+VUaMxIIj2EcO3F1bqux3Zc0mGENpmlSrHA== X-Received: by 2002:a81:3594:: with SMTP id c142mr16153989ywa.234.1547240095674; Fri, 11 Jan 2019 12:54:55 -0800 (PST) Received: from localhost ([2620:10d:c091:180::1:1af2]) by smtp.gmail.com with ESMTPSA id z2sm27010427ywe.32.2019.01.11.12.54.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Jan 2019 12:54:55 -0800 (PST) Date: Fri, 11 Jan 2019 12:54:51 -0800 From: Tejun Heo To: Al Viro Cc: Zefan Li , Linus Torvalds , linux-fsdevel@vger.kernel.org Subject: Re: [heads-up] buggered refcounting logics in cgroup1_mount() Message-ID: <20190111205451.GX2509588@devbig004.ftw2.facebook.com> References: <20190111072309.GT2217@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190111072309.GT2217@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hello, Al. On Fri, Jan 11, 2019 at 07:23:09AM +0000, Al Viro wrote: > AFAICS, a cleaner solution would be this: > * to hell with kernfs_pin_sb(); just try to grab a reference to > cgroup_root on reuse. > * have cgroup_kill_sb() treat "it's already marked killed" as > "just drop the reference, then". > * after cgroup_do_mount() check if cgroup_root got marked killed and > do deactivate_locked_super() in such case (with the same > restart_syscall() failure exit). > > Objections? I would love to kill kernfs_pin_sb() as > a followup (it's a fundamentally broken API), but that's not > a stable fodder; some fix of refcounting bugs, OTOH, should be. cgroup1 hierarchies have really weird set of requirements and the implementation has always been somewhat broken. I thought I fixed it but obviously not. I have no objection whatsoever and would much appreciate the work. Thanks a lot and happy new year! -- tejun