From: Matt Roper Subject: Re: [v5 4/6] drm/i915/icl: Add icl pipe degamma and gamma support Date: Fri, 11 Jan 2019 14:18:38 -0800 Message-ID: <20190111221838.GP4563@mdroper-desk.amr.corp.intel.com> References: <1546933053-10731-1-git-send-email-uma.shankar@intel.com> <1546933053-10731-5-git-send-email-uma.shankar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8A2086E24C for ; Fri, 11 Jan 2019 22:18:39 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1546933053-10731-5-git-send-email-uma.shankar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Uma Shankar Cc: intel-gfx@lists.freedesktop.org, ville.syrjala@intel.com, maarten.lankhorst@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKYW4gMDgsIDIwMTkgYXQgMDE6MDc6MzFQTSArMDUzMCwgVW1hIFNoYW5rYXIgd3Jv dGU6Cj4gQWRkIHN1cHBvcnQgZm9yIGljbCBwaXBlIGRlZ2FtbWEgYW5kIGdhbW1hLgo+IAo+IHYy OiBSZW1vdmVkIGEgUE9TVElOR19SRUFEIGFuZCBjb3JyZWN0ZWQgdGhlIEJpdAo+IERlZmluaXRp b24gYXMgcGVyIE1hYXJ0ZW4ncyBjb21tZW50cy4KPiAKPiB2MzogQWRkcmVzc2VkIE1hdHQncyBy ZXZpZXcgY29tbWVudHMuIFJlbW92ZWQgcm13IHBhdHRlcm5zCj4gYXMgc3VnZ2VzdGVkIGJ5IE1h dHQuCj4gCj4gdjQ6IEZpeGVkIE1hdHQncyByZXZpZXcgY29tbWVudHMuCj4gCj4gdjU6IENvcnJl Y3RlZCBtYWNybyBhbGlnbm1lbnQgYXMgcGVyIEphbmkgTmlrdWxhJ3MgY29tbWVudHMuCj4gQWRk cmVzc2VkIFZpbGxlIGFuZCBNYXR0J3MgIHJldmlldyBjb21tZW50cy4KPiAKPiBTaWduZWQtb2Zm LWJ5OiBVbWEgU2hhbmthciA8dW1hLnNoYW5rYXJAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oICAgIHwgMTIgKysrKy0tLQo+ICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9jb2xvci5jIHwgNjUgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCA3MiBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9u cygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+IGluZGV4IDQ0OTU4ZDkuLmYyOWVlZjcg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiBAQCAtNzA4OCwxMSArNzA4OCwxMyBAQCBl bnVtIHsKPiAgI2RlZmluZSBfR0FNTUFfTU9ERV9BCQkweDRhNDgwCj4gICNkZWZpbmUgX0dBTU1B X01PREVfQgkJMHg0YWM4MAo+ICAjZGVmaW5lIEdBTU1BX01PREUocGlwZSkgX01NSU9fUElQRShw aXBlLCBfR0FNTUFfTU9ERV9BLCBfR0FNTUFfTU9ERV9CKQo+IC0jZGVmaW5lIEdBTU1BX01PREVf TU9ERV9NQVNLCSgzIDw8IDApCj4gLSNkZWZpbmUgR0FNTUFfTU9ERV9NT0RFXzhCSVQJKDAgPDwg MCkKPiAtI2RlZmluZSBHQU1NQV9NT0RFX01PREVfMTBCSVQJKDEgPDwgMCkKPiAtI2RlZmluZSBH QU1NQV9NT0RFX01PREVfMTJCSVQJKDIgPDwgMCkKPiAtI2RlZmluZSBHQU1NQV9NT0RFX01PREVf U1BMSVQJKDMgPDwgMCkKPiArI2RlZmluZSAgUFJFX0NTQ19HQU1NQV9FTkFCTEUJKDEgPDwgMzEp Cj4gKyNkZWZpbmUgIFBPU1RfQ1NDX0dBTU1BX0VOQUJMRQkoMSA8PCAzMCkKPiArI2RlZmluZSAg R0FNTUFfTU9ERV9NT0RFX01BU0sJKDMgPDwgMCkKPiArI2RlZmluZSAgR0FNTUFfTU9ERV9NT0RF XzhCSVQJKDAgPDwgMCkKPiArI2RlZmluZSAgR0FNTUFfTU9ERV9NT0RFXzEwQklUCSgxIDw8IDAp Cj4gKyNkZWZpbmUgIEdBTU1BX01PREVfTU9ERV8xMkJJVAkoMiA8PCAwKQo+ICsjZGVmaW5lICBH QU1NQV9NT0RFX01PREVfU1BMSVQJKDMgPDwgMCkKPiAgCj4gIC8qIERNQy9DU1IgKi8KPiAgI2Rl ZmluZSBDU1JfUFJPR1JBTShpKQkJX01NSU8oMHg4MDAwMCArIChpKSAqIDQpCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9yLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9jb2xvci5jCj4gaW5kZXggOWE3MmU2NC4uOWNkNDY0NiAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfY29sb3IuYwo+IEBAIC01MjAsNiArNTIwLDY5IEBAIHN0YXRpYyB2b2lk IGdsa19sb2FkX2x1dHMoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gIAlQ T1NUSU5HX1JFQUQoR0FNTUFfTU9ERShwaXBlKSk7Cj4gIH0KPiAgCj4gK3N0YXRpYyB2b2lkIGlj bF9sb2FkX2RlZ2FtbWFfbHV0KHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQoK QXMgVmlsbGUgbm90ZWQsIEkgdGhpbmsgdGhlIGRlZ2FtbWEgTFVUIHdvcmtzIHRoZSBzYW1lIHdh eSBvbiBHTEstSUNMOwp0aGUgZ2FtbWEgcGFydCBtYXkgYmUgZGlmZmVyZW50IChhbmQgdGhlcmUn cyBleHRyYSBzdHVmZiBsaWtlIHRoZSBleHRyYQpvdXRwdXQgQ1NDIG9uIElDTCksIGJ1dCBmb3Ig ZGVnYW1tYSBzcGVjaWZpY2FsbHkgSSB0aGluayB0aGUgY29kZSB5b3UKd3JvdGUgYmVsb3cgY291 bGQganVzdCBiZSB1c2VkIHRvIHJlcGxhY2UgdGhlIGN1cnJlbnQgYm9keSBvZgpnbGtfbG9hZF9k ZWdhbW1hX2x1dCByYXRoZXIgdGhhbiBhZGRpbmcgaXQgYXMgYSBzZXBhcmF0ZSBmdW5jdGlvbi4K ClNpbmNlIEdMSy1JQ0wgb25seSBzdXBwb3J0IGVxdWFsIHIvZy9iIHZhbHVlcywgd2UgYWxzbyBu ZWVkIHRvIGxhbmQgdGhlCkxVVCB2YWxpZGF0aW9uIHBhdGNoZXMgSSB3cm90ZSBpbiBEZWNlbWJl ci4gIFRob3NlIGFyZSBmdWxseSByZXZpZXdlZCBzbwpJJ2xsIGRvIHRoYXQgYXMgc29vbiBhcyBJ IGdldCBhbiBhY2sgZnJvbSBEYXZlL0RhbmllbCB0byBtZXJnZSB0aGUgZHJtCmNvcmUgcGF0Y2gg dGhyb3VnaCB0aGUgSW50ZWwgdHJlZS4KCgpNYXR0Cgo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2ID0gY3J0Y19zdGF0ZS0+YmFzZS5jcnRjLT5kZXY7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRldik7Cj4gKwllbnVtIHBpcGUgcGlwZSA9IHRv X2ludGVsX2NydGMoY3J0Y19zdGF0ZS0+YmFzZS5jcnRjKS0+cGlwZTsKPiArCWNvbnN0IHVpbnQz Ml90IGx1dF9zaXplID0gSU5URUxfSU5GTyhkZXZfcHJpdiktPmNvbG9yLmRlZ2FtbWFfbHV0X3Np emU7Cj4gKwl1aW50MzJfdCBpOwo+ICsKPiArCS8qCj4gKwkgKiBXaGVuIHNldHRpbmcgdGhlIGF1 dG8taW5jcmVtZW50IGJpdCwgdGhlIGhhcmR3YXJlIHNlZW1zIHRvCj4gKwkgKiBpZ25vcmUgdGhl IGluZGV4IGJpdHMsIHNvIHdlIG5lZWQgdG8gcmVzZXQgaXQgdG8gaW5kZXggMAo+ICsJICogc2Vw YXJhdGVseS4KPiArCSAqLwo+ICsJSTkxNV9XUklURShQUkVfQ1NDX0dBTUNfSU5ERVgocGlwZSks IDApOwo+ICsJSTkxNV9XUklURShQUkVfQ1NDX0dBTUNfSU5ERVgocGlwZSksIFBSRV9DU0NfR0FN Q19BVVRPX0lOQ1JFTUVOVCk7Cj4gKwo+ICsJaWYgKGNydGNfc3RhdGUtPmJhc2UuZGVnYW1tYV9s dXQpIHsKPiArCQlzdHJ1Y3QgZHJtX2NvbG9yX2x1dCAqbHV0ID0gY3J0Y19zdGF0ZS0+YmFzZS5k ZWdhbW1hX2x1dC0+ZGF0YTsKPiArCj4gKwkJZm9yIChpID0gMDsgaSA8IGx1dF9zaXplOyBpKysp IHsKPiArCQkJLyoKPiArCQkJICogRmlyc3QgMzMgZW50cmllcyByZXByZXNlbnQgcmFuZ2UgZnJv bSAwIHRvIDEuMAo+ICsJCQkgKiAzNHRoIGFuZCAzNXRoIGVudHJ5IHdpbGwgcmVwcmVzZW50IGV4 dGVuZGVkIHJhbmdlCj4gKwkJCSAqIGlucHV0cyAzLjAgYW5kIDcuMCByZXNwZWN0aXZlbHksIGN1 cnJlbnRseSBjbGFtcGVkCj4gKwkJCSAqIGF0IDEuMC4gU2luY2UgdGhlIHByZWNpc2lvbiBpcyAx NmJpdCwgdGhlIHVzZXIgdmFsdWUKPiArCQkJICogY2FuIGJlIGRpcmVjdGx5IGZpbGxlZCB0byBy ZWdpc3Rlci4KPiArCQkJICogVG9EbzogRXh0ZW5kIHRvIG1heCA3LjAuCj4gKwkJCSAqLwo+ICsJ CQlJOTE1X1dSSVRFKFBSRV9DU0NfR0FNQ19EQVRBKHBpcGUpLCBsdXRbaV0uZ3JlZW4pOwo+ICsJ CX0KPiArCX0gZWxzZSB7Cj4gKwkJLyogbG9hZCBhIGxpbmVhciB0YWJsZS4gKi8KPiArCQlmb3Ig KGkgPSAwOyBpIDwgbHV0X3NpemU7IGkrKykgewo+ICsJCQl1aW50MzJfdCB2ID0gKGkgKiAoMSA8 PCAxNikpIC8gKGx1dF9zaXplIC0gMSk7Cj4gKwo+ICsJCQlJOTE1X1dSSVRFKFBSRV9DU0NfR0FN Q19EQVRBKHBpcGUpLCB2KTsKPiArCQl9Cj4gKwl9Cj4gKwo+ICsJLyogQ2xhbXAgdmFsdWVzID4g MS4wLiAqLwo+ICsJd2hpbGUgKGkrKyA8IDM1KQo+ICsJCUk5MTVfV1JJVEUoUFJFX0NTQ19HQU1D X0RBVEEocGlwZSksICgxIDw8IDE2KSk7Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIGljbF9sb2Fk X2x1dHMoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gK3sKPiArCXN0cnVj dCBkcm1fY3J0YyAqY3J0YyA9IGNydGNfc3RhdGUtPmJhc2UuY3J0YzsKPiArCXN0cnVjdCBkcm1f ZGV2aWNlICpkZXYgPSBjcnRjX3N0YXRlLT5iYXNlLmNydGMtPmRldjsKPiArCXN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiArCWVudW0gcGlwZSBwaXBl ID0gdG9faW50ZWxfY3J0YyhjcnRjKS0+cGlwZTsKPiArCj4gKwlpZiAoY3J0Y19zdGF0ZV9pc19s ZWdhY3lfZ2FtbWEoY3J0Y19zdGF0ZSkpIHsKPiArCQloYXN3ZWxsX2xvYWRfbHV0cyhjcnRjX3N0 YXRlKTsKPiArCQlyZXR1cm47Cj4gKwl9Cj4gKwo+ICsJaWNsX2xvYWRfZGVnYW1tYV9sdXQoY3J0 Y19zdGF0ZSk7Cj4gKwliZHdfbG9hZF9nYW1tYV9sdXQoY3J0Y19zdGF0ZSwgMCk7Cj4gKwo+ICsJ STkxNV9XUklURShHQU1NQV9NT0RFKHBpcGUpLCBHQU1NQV9NT0RFX01PREVfMTBCSVQgfAo+ICsJ CSAgIFBSRV9DU0NfR0FNTUFfRU5BQkxFIHwgUE9TVF9DU0NfR0FNTUFfRU5BQkxFKTsKPiArfQo+ ICsKPiAgLyogTG9hZHMgdGhlIHBhbGV0dGUvZ2FtbWEgdW5pdCBmb3IgdGhlIENSVEMgb24gQ2hl cnJ5Vmlldy4gKi8KPiAgc3RhdGljIHZvaWQgY2hlcnJ5dmlld19sb2FkX2x1dHMoc3RydWN0IGlu dGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gIHsKPiBAQCAtNjM2LDYgKzY5OSw4IEBAIHZv aWQgaW50ZWxfY29sb3JfaW5pdChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiAgCX0gZWxzZSBp ZiAoSVNfR0VNSU5JTEFLRShkZXZfcHJpdikgfHwgSVNfQ0FOTk9OTEFLRShkZXZfcHJpdikpIHsK PiAgCQlkZXZfcHJpdi0+ZGlzcGxheS5sb2FkX2NzY19tYXRyaXggPSBpbGtfbG9hZF9jc2NfbWF0 cml4Owo+ICAJCWRldl9wcml2LT5kaXNwbGF5LmxvYWRfbHV0cyA9IGdsa19sb2FkX2x1dHM7Cj4g Kwl9IGVsc2UgaWYgKElTX0lDRUxBS0UoZGV2X3ByaXYpKSB7Cj4gKwkJZGV2X3ByaXYtPmRpc3Bs YXkubG9hZF9sdXRzID0gaWNsX2xvYWRfbHV0czsKPiAgCX0gZWxzZSB7Cj4gIAkJZGV2X3ByaXYt PmRpc3BsYXkubG9hZF9sdXRzID0gaTl4eF9sb2FkX2x1dHM7Cj4gIAl9Cj4gLS0gCj4gMS45LjEK PiAKCi0tIApNYXR0IFJvcGVyCkdyYXBoaWNzIFNvZnR3YXJlIEVuZ2luZWVyCklvVEcgUGxhdGZv cm0gRW5hYmxpbmcgJiBEZXZlbG9wbWVudApJbnRlbCBDb3Jwb3JhdGlvbgooOTE2KSAzNTYtMjc5 NQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK