Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A9F3A211B6C23 for ; Fri, 11 Jan 2019 14:53:51 -0800 (PST) From: Vishal Verma Subject: [ndctl PATCH 3/3] ndctl, monitor: switch to ndctl_cmd_submit_xlat Date: Fri, 11 Jan 2019 15:53:39 -0700 Message-Id: <20190111225339.6939-4-vishal.l.verma@intel.com> In-Reply-To: <20190111225339.6939-1-vishal.l.verma@intel.com> References: <20190111225339.6939-1-vishal.l.verma@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: linux-nvdimm@lists.01.org Cc: Ami Pathak List-ID: The ndctl monitor command was neglecting to check the 'firmware_status' field that is set by the platform firmware to indicate failure. Use the new ndctl_cmd_submit_xlat facility to include the firmware_status check as part of the command submission. Cc: QI Fuli Cc: Dan Williams Signed-off-by: Vishal Verma --- ndctl/monitor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ndctl/monitor.c b/ndctl/monitor.c index 233f2bb..01af338 100644 --- a/ndctl/monitor.c +++ b/ndctl/monitor.c @@ -226,7 +226,7 @@ static int enable_dimm_supported_threshold_alarms(struct ndctl_dimm *dimm) err(&monitor, "%s: no smart threshold command support\n", name); goto out; } - if (ndctl_cmd_submit(st_cmd)) { + if (ndctl_cmd_submit_xlat(st_cmd)) { err(&monitor, "%s: smart threshold command failed\n", name); goto out; } @@ -246,7 +246,7 @@ static int enable_dimm_supported_threshold_alarms(struct ndctl_dimm *dimm) alarm |= ND_SMART_CTEMP_TRIP; ndctl_cmd_smart_threshold_set_alarm_control(sst_cmd, alarm); - rc = ndctl_cmd_submit(sst_cmd); + rc = ndctl_cmd_submit_xlat(sst_cmd); if (rc) { err(&monitor, "%s: smart set threshold command failed\n", name); goto out; -- 2.17.2 _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm