From: Tom Rini Date: Sat, 12 Jan 2019 15:13:32 -0500 Subject: [U-Boot] Revert "dm: pinctrl: Prevent (re-)configuring pins when already done before relocation" In-Reply-To: <20190109220502.5992-1-lukma@denx.de> References: <20190109220502.5992-1-lukma@denx.de> Message-ID: <20190112201332.GM5463@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jan 09, 2019 at 11:05:02PM +0100, Lukasz Majewski wrote: > This reverts commit a7f4b4b344396590845e6552c82829ef68ef9f89. > > As reported by Alex Kiernan the above optimization introduces a > regression in the below use case where: > > 1. Device has defined 'u-boot,dm-spl' property (@ eMMC DTS node) > > 2. The device downloads its MLO/SPL via UART (not eMMC - the eMMC pinmux > pins are NOT probed/configured in MLO/SPL). > > 3. The loaded via UART MLO/SPL wants to load Linux from eMMC. In this case > the DM core and pinctrl uclass checks 'u-boot,dm-spl' and don't > configure pins (as it thinks that those were initialized in MLO/SPL). > > As we are very close to release - please revert this commit. > > Reported-by: Alex Kiernan > Signed-off-by: Lukasz Majewski > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: