Received: from eggs.gnu.org ([209.51.188.92]:43104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gj7jy-0005l6-Hh for qemu-devel@nongnu.org; Mon, 14 Jan 2019 14:17:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gj7j1-0007Ru-JC for qemu-devel@nongnu.org; Mon, 14 Jan 2019 14:16:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36022) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gj7j1-0007R1-9U for qemu-devel@nongnu.org; Mon, 14 Jan 2019 14:16:43 -0500 Date: Mon, 14 Jan 2019 17:16:39 -0200 From: Eduardo Habkost Message-ID: <20190114191639.GF28115@habkost.net> References: <97d9193875747d8378c05b9e3b3cb39c1b7d2b4e.1546399191.git.yi.z.zhang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <97d9193875747d8378c05b9e3b3cb39c1b7d2b4e.1546399191.git.yi.z.zhang@linux.intel.com> Subject: Re: [Qemu-devel] [PATCH V8 4/5] hostmem: add more information in error messages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhang Yi Cc: xiaoguangrong.eric@gmail.com, stefanha@redhat.com, pbonzini@redhat.com, pagupta@redhat.com, yu.c.zhang@linux.intel.com, mst@redhat.com, imammedo@redhat.com, dan.j.williams@intel.com, qemu-devel@nongnu.org On Wed, Jan 02, 2019 at 01:26:24PM +0800, Zhang Yi wrote: > When there are multiple memory backends in use, including the object type > name, ID and the property name in the error message can help users to > locate the error. I don't see the object ID anywhere in the code below. With the commit message corrected: Reviewed-by: Eduardo Habkost I'm queueing it on machine-next. > > Signed-off-by: Haozhong Zhang > Signed-off-by: Zhang Yi > --- > backends/hostmem-file.c | 6 ++++-- > backends/hostmem.c | 8 +++++--- > 2 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c > index e640749..0dd7a90 100644 > --- a/backends/hostmem-file.c > +++ b/backends/hostmem-file.c > @@ -82,7 +82,8 @@ static void set_mem_path(Object *o, const char *str, Error **errp) > HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o); > > if (host_memory_backend_mr_inited(backend)) { > - error_setg(errp, "cannot change property value"); > + error_setg(errp, "cannot change property 'mem-path' of %s", > + object_get_typename(o)); > return; > } > g_free(fb->mem_path); > @@ -120,7 +121,8 @@ static void file_memory_backend_set_align(Object *o, Visitor *v, > uint64_t val; > > if (host_memory_backend_mr_inited(backend)) { > - error_setg(&local_err, "cannot change property value"); > + error_setg(&local_err, "cannot change property '%s' of %s", > + name, object_get_typename(o)); > goto out; > } > > diff --git a/backends/hostmem.c b/backends/hostmem.c > index 1a89342..e2bcf9f 100644 > --- a/backends/hostmem.c > +++ b/backends/hostmem.c > @@ -47,7 +47,8 @@ host_memory_backend_set_size(Object *obj, Visitor *v, const char *name, > uint64_t value; > > if (host_memory_backend_mr_inited(backend)) { > - error_setg(&local_err, "cannot change property value"); > + error_setg(&local_err, "cannot change property %s of %s ", > + name, object_get_typename(obj)); > goto out; > } > > @@ -56,8 +57,9 @@ host_memory_backend_set_size(Object *obj, Visitor *v, const char *name, > goto out; > } > if (!value) { > - error_setg(&local_err, "Property '%s.%s' doesn't take value '%" > - PRIu64 "'", object_get_typename(obj), name, value); > + error_setg(&local_err, > + "property '%s' of %s doesn't take value '%" PRIu64 "'", > + name, object_get_typename(obj), value); > goto out; > } > backend->size = value; > -- > 2.7.4 > > -- Eduardo