From: Mathieu Malaterre Subject: [PATCH 2/2] bpf: annotate implicit fall through Date: Mon, 14 Jan 2019 21:29:41 +0100 Message-ID: <20190114202941.16183-2-malat@debian.org> References: <20190114202941.16183-1-malat@debian.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Mathieu Malaterre , Daniel Borkmann , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Alexei Starovoitov Return-path: In-Reply-To: <20190114202941.16183-1-malat@debian.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org There is a plan to build the kernel with -Wimplicit-fallthrough and thise place in the code produced a warnings (W=1). In this particular case change a ‘:’ with a ‘,’ so as to match the regular expression expected by GCC. This commit remove the following warning: net/core/filter.c:5310:6: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- net/core/filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/filter.c b/net/core/filter.c index 447dd1bad31f..c8069a142994 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -5309,7 +5309,7 @@ bpf_base_func_proto(enum bpf_func_id func_id) case BPF_FUNC_trace_printk: if (capable(CAP_SYS_ADMIN)) return bpf_get_trace_printk_proto(); - /* else: fall through */ + /* else, fall through */ default: return NULL; } -- 2.19.2