From: Daniel Vetter Subject: Re: [PATCH v2] drm/meson: Fix atomic mode switching regression Date: Tue, 15 Jan 2019 13:06:18 +0100 Message-ID: <20190115120618.GM10517@phenom.ffwll.local> References: <20190114153118.8024-1-narmstrong@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 189306ECB1 for ; Tue, 15 Jan 2019 12:06:23 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id b14so2338232edt.6 for ; Tue, 15 Jan 2019 04:06:23 -0800 (PST) Content-Disposition: inline In-Reply-To: <20190114153118.8024-1-narmstrong@baylibre.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Neil Armstrong Cc: linux-amlogic@lists.infradead.org, Tony McKahan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBKYW4gMTQsIDIwMTkgYXQgMDQ6MzE6MThQTSArMDEwMCwgTmVpbCBBcm1zdHJvbmcg d3JvdGU6Cj4gU2luY2UgY29tbWl0IDJiY2QzZWNhYjc3MyB3aGVuIHN3aXRjaGluZyBtb2RlIGZy b20gWDExICh1YnVudHUgbWF0ZSBmb3IKPiBleGFtcGxlKSB0aGUgZGlzcGxheSBnZXRzIGJsdXJy eSwgbG9va2luZyBsaWtlIGFuIGludmFsaWQgZnJhbWVidWZmZXIgd2lkdGguCj4gCj4gVGhpcyBj b21taXQgZml4ZWQgYXRvbWljIGNydGMgbW9kZXNldHRpbmcgaW4gYSB0b3RhbGx5IHdyb25nIHdh eSBhbmQKPiBpbnRyb2R1Y2VkIGEgbG9jYWwgdW5uZWNlc3NhcnkgLT5lbmFibGVkIGNydGMgc3Rh dGUuCj4gCj4gVGhpcyBjb21taXQgcmV2ZXJ0cyB0aGUgY3JjdGMgX2JlZ2luKCkgYW5kIF9lbmFi bGUoKSBjaGFuZ2VzIGFuZCBzaW1wbHkKPiBhZGRzIGRybV9hdG9taWNfaGVscGVyX2NvbW1pdF90 YWlsX3JwbSBhcyBoZWxwZXIuCj4gCj4gUmVwb3J0ZWQtYnk6IFRvbnkgTWNLYWhhbiA8dG9ueW1j a2FoYW5AZ21haWwuY29tPgo+IFN1Z2dlc3RlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZm d2xsLmNoPgo+IEZpeGVzOiAyYmNkM2VjYWI3NzMgKCJkcm0vbWVzb246IEZpeGVzIGZvciBkcm1f Y3J0Y192Ymxhbmtfb24vb2ZmIHN1cHBvcnQiKQo+IFNpZ25lZC1vZmYtYnk6IE5laWwgQXJtc3Ry b25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT4KCkZvciB0aGUgcmVjb3JkIChJIGFscmVhZHkg YWNrZWQgdGhpcyBvbiBpcmMpOgoKQWNrZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0 ZXJAZmZ3bGwuY2g+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tZXNvbi9tZXNvbl9jcnRjLmMg fCAyMyArKy0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vbWVzb24vbWVz b25fZHJ2LmMgIHwgIDYgKysrKysrCj4gIDIgZmlsZXMgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCsp LCAyMSBkZWxldGlvbnMoLSkKPiAKPiBDaGFuZ2VzIHNpbmNlIHYxOgo+IC0gZHJvcCB0aGUgdW5l Y2Vzc2FyeSBsb2NhbCAtPmVuYWJsZWQgbG9naWMKPiAtIHVzZSBkcm1fYXRvbWljX2hlbHBlcl9j b21taXRfdGFpbF9ycG0gYXMgYXRvbWljX2NvbW1pdF90YWlsIGhlbHBlcgo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vbWVzb24vbWVzb25fY3J0Yy5jIGIvZHJpdmVycy9ncHUvZHJt L21lc29uL21lc29uX2NydGMuYwo+IGluZGV4IDc1ZDk3ZjFiMmU4Zi4uNGY1YzY3ZjcwYzRkIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZXNvbi9tZXNvbl9jcnRjLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vbWVzb24vbWVzb25fY3J0Yy5jCj4gQEAgLTQ2LDcgKzQ2LDYgQEAgc3Ry dWN0IG1lc29uX2NydGMgewo+ICAJc3RydWN0IGRybV9jcnRjIGJhc2U7Cj4gIAlzdHJ1Y3QgZHJt X3BlbmRpbmdfdmJsYW5rX2V2ZW50ICpldmVudDsKPiAgCXN0cnVjdCBtZXNvbl9kcm0gKnByaXY7 Cj4gLQlib29sIGVuYWJsZWQ7Cj4gIH07Cj4gICNkZWZpbmUgdG9fbWVzb25fY3J0Yyh4KSBjb250 YWluZXJfb2YoeCwgc3RydWN0IG1lc29uX2NydGMsIGJhc2UpCj4gIAo+IEBAIC04Miw3ICs4MSw4 IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX2NydGNfZnVuY3MgbWVzb25fY3J0Y19mdW5jcyA9 IHsKPiAgCj4gIH07Cj4gIAo+IC1zdGF0aWMgdm9pZCBtZXNvbl9jcnRjX2VuYWJsZShzdHJ1Y3Qg ZHJtX2NydGMgKmNydGMpCj4gK3N0YXRpYyB2b2lkIG1lc29uX2NydGNfYXRvbWljX2VuYWJsZShz dHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gKwkJCQkgICAgIHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAq b2xkX3N0YXRlKQo+ICB7Cj4gIAlzdHJ1Y3QgbWVzb25fY3J0YyAqbWVzb25fY3J0YyA9IHRvX21l c29uX2NydGMoY3J0Yyk7Cj4gIAlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGUgPSBj cnRjLT5zdGF0ZTsKPiBAQCAtMTA4LDIwICsxMDgsNiBAQCBzdGF0aWMgdm9pZCBtZXNvbl9jcnRj X2VuYWJsZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gIAo+ICAJZHJtX2NydGNfdmJsYW5rX29u KGNydGMpOwo+ICAKPiAtCW1lc29uX2NydGMtPmVuYWJsZWQgPSB0cnVlOwo+IC19Cj4gLQo+IC1z dGF0aWMgdm9pZCBtZXNvbl9jcnRjX2F0b21pY19lbmFibGUoc3RydWN0IGRybV9jcnRjICpjcnRj LAo+IC0JCQkJICAgICBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKm9sZF9zdGF0ZSkKPiAtewo+IC0J c3RydWN0IG1lc29uX2NydGMgKm1lc29uX2NydGMgPSB0b19tZXNvbl9jcnRjKGNydGMpOwo+IC0J c3RydWN0IG1lc29uX2RybSAqcHJpdiA9IG1lc29uX2NydGMtPnByaXY7Cj4gLQo+IC0JRFJNX0RF QlVHX0RSSVZFUigiXG4iKTsKPiAtCj4gLQlpZiAoIW1lc29uX2NydGMtPmVuYWJsZWQpCj4gLQkJ bWVzb25fY3J0Y19lbmFibGUoY3J0Yyk7Cj4gLQo+ICAJcHJpdi0+dml1Lm9zZDFfZW5hYmxlZCA9 IHRydWU7Cj4gIH0KPiAgCj4gQEAgLTE1Myw4ICsxMzksNiBAQCBzdGF0aWMgdm9pZCBtZXNvbl9j cnRjX2F0b21pY19kaXNhYmxlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCj4gIAkJY3J0Yy0+ c3RhdGUtPmV2ZW50ID0gTlVMTDsKPiAgCX0KPiAtCj4gLQltZXNvbl9jcnRjLT5lbmFibGVkID0g ZmFsc2U7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIG1lc29uX2NydGNfYXRvbWljX2JlZ2luKHN0 cnVjdCBkcm1fY3J0YyAqY3J0YywKPiBAQCAtMTYzLDkgKzE0Nyw2IEBAIHN0YXRpYyB2b2lkIG1l c29uX2NydGNfYXRvbWljX2JlZ2luKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCXN0cnVjdCBt ZXNvbl9jcnRjICptZXNvbl9jcnRjID0gdG9fbWVzb25fY3J0YyhjcnRjKTsKPiAgCXVuc2lnbmVk IGxvbmcgZmxhZ3M7Cj4gIAo+IC0JaWYgKGNydGMtPnN0YXRlLT5lbmFibGUgJiYgIW1lc29uX2Ny dGMtPmVuYWJsZWQpCj4gLQkJbWVzb25fY3J0Y19lbmFibGUoY3J0Yyk7Cj4gLQo+ICAJaWYgKGNy dGMtPnN0YXRlLT5ldmVudCkgewo+ICAJCVdBUk5fT04oZHJtX2NydGNfdmJsYW5rX2dldChjcnRj KSAhPSAwKTsKPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZXNvbi9tZXNvbl9k cnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9tZXNvbi9tZXNvbl9kcnYuYwo+IGluZGV4IDNlZTRkNGE0 ZWNiYS4uYTc0ZDg2MWRkY2ViIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZXNvbi9t ZXNvbl9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tZXNvbi9tZXNvbl9kcnYuYwo+IEBA IC03NSw2ICs3NSwxMSBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9tb2RlX2NvbmZpZ19mdW5j cyBtZXNvbl9tb2RlX2NvbmZpZ19mdW5jcyA9IHsKPiAgCS5mYl9jcmVhdGUgICAgICAgICAgID0g ZHJtX2dlbV9mYl9jcmVhdGUsCj4gIH07Cj4gIAo+ICsKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBk cm1fbW9kZV9jb25maWdfaGVscGVyX2Z1bmNzIG1lc29uX21vZGVfY29uZmlnX2hlbHBlcnMgPSB7 Cj4gKwkuYXRvbWljX2NvbW1pdF90YWlsID0gZHJtX2F0b21pY19oZWxwZXJfY29tbWl0X3RhaWxf cnBtLAo+ICt9Owo+ICsKPiAgc3RhdGljIGlycXJldHVybl90IG1lc29uX2lycShpbnQgaXJxLCB2 b2lkICphcmcpCj4gIHsKPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBhcmc7Cj4gQEAgLTI2 Niw2ICsyNzEsNyBAQCBzdGF0aWMgaW50IG1lc29uX2Rydl9iaW5kX21hc3RlcihzdHJ1Y3QgZGV2 aWNlICpkZXYsIGJvb2wgaGFzX2NvbXBvbmVudHMpCj4gIAlkcm0tPm1vZGVfY29uZmlnLm1heF93 aWR0aCA9IDM4NDA7Cj4gIAlkcm0tPm1vZGVfY29uZmlnLm1heF9oZWlnaHQgPSAyMTYwOwo+ICAJ ZHJtLT5tb2RlX2NvbmZpZy5mdW5jcyA9ICZtZXNvbl9tb2RlX2NvbmZpZ19mdW5jczsKPiArCWRy bS0+bW9kZV9jb25maWcuaGVscGVyX3ByaXZhdGUJPSAmbWVzb25fbW9kZV9jb25maWdfaGVscGVy czsKPiAgCj4gIAkvKiBIYXJkd2FyZSBJbml0aWFsaXphdGlvbiAqLwo+ICAKPiAtLSAKPiAyLjIw LjEKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3Jh dGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK