Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80522C43387 for ; Tue, 15 Jan 2019 15:26:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 523D7204FD for ; Tue, 15 Jan 2019 15:26:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547565993; bh=9Ko/X0iH0lpm1Tq/qqnL/eDhTDU8PX1IDr9qNNxUUrU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ywMSb2BR7CwxRyLelVHcQjTKfLVAvSzFHteDAQi5oakolKSbmV3CDzPsA2lRndhIB Eqig02w9mo1ZYuXv+woFPO75CMAuFbu0RP1ZQ6+u3SOGFWkx5ozaxeWOsdXJH6e3yB lLTSJ6OBm4AQQOUOz0E81KRxrqHfLphoyyVbxOns= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730705AbfAOP0c (ORCPT ); Tue, 15 Jan 2019 10:26:32 -0500 Received: from mail-yw1-f44.google.com ([209.85.161.44]:35469 "EHLO mail-yw1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728799AbfAOP0c (ORCPT ); Tue, 15 Jan 2019 10:26:32 -0500 Received: by mail-yw1-f44.google.com with SMTP id h32so1182466ywk.2 for ; Tue, 15 Jan 2019 07:26:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4aRe9nVa3QmzWgB1FcWcS3GF0XRhmruvalWSSeE4rwg=; b=FoBZT3K7USMzU9Wnbs7k6+/rr/yCnRme1yDe17trNUbumxsZ46UBQToRX3CpMZFgIm NMptKhlSsV2a8GgNvBroeHX21WNkk0KU+P+PEBf6hIyMv76tCc0fy7CsRJLJSmBrHG/Y muC6ic9+xzalD/oCCBPV7qzefV73r7/ZqOPycW4VqAkLbSttOuwtOt1lQLcNNw2/mtl9 /i8nJVvp04+x3zDDyJI0kY7g+5xa2yPx8wqEhrd23Crsa0Y5gca3TQKSXfW7efZqEctT 4TsO38jjJB8IyCgKlis1fiQPZeP5tmMfkmSsqBs7Xwuc48gx5a4aQw62XfJmYVy3HMYW qc8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=4aRe9nVa3QmzWgB1FcWcS3GF0XRhmruvalWSSeE4rwg=; b=V5LuJs3RBpXIgk9RdtuQSkh9OyFH58Cz/LZP98S/jmNaqcipRPDcvoKuInR3P2J74J C66xhtlbEue7mKlyyXENITQ5jQvBOc6YMzs+QAec3xihEueSKU5HejA1OkUXIGnjTdeC Y9nqpPGk6WIjraFdYSwAbwz9ztEvmQhGikWJHuU7szy9MXHkp3IYbQF17hzm/b7M2IFF IDKGRFcBLMJI2u+MpigAfDJuxwYwsqvnslYQdVBJUOqQDJSIb9g46vdho5X/3BfrqxVs +2ClcA1BIRz/qY1lmVraKaYrPGumED7lo27hBf/Yq/RsHcKIB8KlHLa0OvyXhTONTnYO YloQ== X-Gm-Message-State: AJcUukfBispD1wXA6Fbmynb6WHeg9uG6jQlyaAO6pPLiFLGXoUxW9jC7 iuCyVwDtFVa3eODkPX1P7RQ= X-Google-Smtp-Source: ALg8bN77ja4T4pzImyGEcywvuuj+8X/vFwC9hBHw1JJEUNXN+QKL5QCGZidMn7Bgz/Tzf6dNUCaaBw== X-Received: by 2002:a81:b54f:: with SMTP id c15mr3552182ywk.274.1547565991287; Tue, 15 Jan 2019 07:26:31 -0800 (PST) Received: from localhost ([2620:10d:c091:200::4:900e]) by smtp.gmail.com with ESMTPSA id z186sm2220095ywd.107.2019.01.15.07.26.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Jan 2019 07:26:29 -0800 (PST) Date: Tue, 15 Jan 2019 07:26:27 -0800 From: Tejun Heo To: Al Viro Cc: Zefan Li , Linus Torvalds , linux-fsdevel@vger.kernel.org, Andrey Vagin Subject: Re: [heads-up] buggered refcounting logics in cgroup1_mount() Message-ID: <20190115152627.GB168429@devbig004.ftw2.facebook.com> References: <20190111072309.GT2217@ZenIV.linux.org.uk> <20190111205451.GX2509588@devbig004.ftw2.facebook.com> <20190112053825.GU2217@ZenIV.linux.org.uk> <20190112215215.GV2217@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190112215215.GV2217@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hello, Al. On Sat, Jan 12, 2019 at 09:52:15PM +0000, Al Viro wrote: > > See vfs.git #fixes (the last two commits in there). It seems to > > work here, but I don't have the CRIU regression tests, etc., so > > I would really appreciate if that thing got a real beating. > > BTW, while kernfs_pin_sb() and struct kernfs_root ->supers definitely > ought to die, there's something else that might be killable with that > approach. percpu_ref_reinit() has no users left after that, and, > as David Howells has observed, PERCPU_REF_INIT_DEAD is also unused. > > Do we want to keep these two? Sorry about the delay. * The patches look good to me. That said, of the two patches, I think it'd be probably better to send only the first one to -stable. As there haven't been any bug reports against the mount behavior for some years now, I don't think there's a need to backport the bigger change. Any change carries some risk after all. * Please feel free to remove percpu_ref_reinit() and unused parts. It's easy enough to add it back later if necessary. * How do you wanna route the patches? Thanks. -- tejun