Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 111ABC43387 for ; Thu, 17 Jan 2019 01:07:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CBFC820651 for ; Thu, 17 Jan 2019 01:07:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="ks88KFz7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727376AbfAQBHg (ORCPT ); Wed, 16 Jan 2019 20:07:36 -0500 Received: from mail-qt1-f195.google.com ([209.85.160.195]:41045 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725872AbfAQBHg (ORCPT ); Wed, 16 Jan 2019 20:07:36 -0500 Received: by mail-qt1-f195.google.com with SMTP id l12so9535376qtf.8 for ; Wed, 16 Jan 2019 17:07:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=F+DSVfn17+Ty0WWZ9ZuB4c7gbQ/JSQB07fWm0FmSqKY=; b=ks88KFz7TUpjm5uH45Do2/DtyUqqUvDaqsUfplFZWOmIa0EQjC2n8Bz45QGNcaXaCZ wZtHnuWOPpxl/G4m8kFEfCK5J3pCZsD2jCUv3VOaZQICo2jWQRbe5Mqi5+9nhSZ7ePP2 YABPRXG/YCT7zwphlqAlo9LA0EK6u9+Zq6kM2r9R/3PJplGpozMtAc7PR88rO+3eADcW 9NmGkyN/TowSHQw+3H8lPhI5acca45TWmUWeOpb/gSwq5Gqinj4VW0lYG1nFvIe/JeSa Zpgnnf4Cl5KPJxt1/PBr072HEaoQS3FY+MO/1+qGSBKlmPanj+gD+NScM9HLPTnoUf6T uopg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=F+DSVfn17+Ty0WWZ9ZuB4c7gbQ/JSQB07fWm0FmSqKY=; b=mykYWuByErw1IyhFa5rSs7XGnj0G2z6B8syAQ3wyyDKolBdFPjIo43fYHGakd4vzuD NMLWL5NXytSAZUkheZ8nZHbzYg5z7yZKfSl5eawkXYzFbcKAYVE/B3R935icCDh1+N9o /5pf2KyUr0fbNEoBJAoDk1PrPGM2/JodkuWWznv495bTnwqzALZLENpf8SUDfPoBclsm 246ejM/ecbSimkUGLujdHqrKPsD0KOI6YtDDbr1Qi9840AcGqY/rWQw3m+AjKyD0CpP/ 91cCgbdAHUNwMyS3RScpmO9CE3YqWcb3h8zRT8TbZ4BpromirMbfDH/2NDsoattdNLSt cDEw== X-Gm-Message-State: AJcUukfIWfI8oCZu9u6X90G/9lU0UjuEbVLVSrJIHJAVnXABOZ1tkBIs XBCi2Ev6L2FJcE18KK+yTJhPKw== X-Google-Smtp-Source: ALg8bN6a3AVZqMKhVsdE4xNnQ1t0lqcpYyDZX2iW59xmspQAs/mOAs79cD+Bxot3o67gY/NFCuorKw== X-Received: by 2002:ac8:12cc:: with SMTP id b12mr9392714qtj.90.1547687255840; Wed, 16 Jan 2019 17:07:35 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id c49sm67167528qtc.94.2019.01.16.17.07.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Jan 2019 17:07:35 -0800 (PST) Date: Wed, 16 Jan 2019 17:07:32 -0800 From: Jakub Kicinski To: Stanislav Fomichev Cc: netdev@vger.kernel.org, davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net, quentin.monnet@netronome.com Subject: Re: [PATCH bpf-next v2 0/7] bpftool: support queue and stack Message-ID: <20190116170732.2ee321b1@cakuba.netronome.com> In-Reply-To: <20190116191005.164355-1-sdf@google.com> References: <20190116191005.164355-1-sdf@google.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 16 Jan 2019 11:09:58 -0800, Stanislav Fomichev wrote: > This patch series add support for queue/stack manipulations. > > It goes like this: > > #1 and #2 add support for queue/stack in existing 'update' and 'lookup' > commands by permitting empty keys. > #3 make sure we don't print empty keys for queue/stack. > #4 adds peek command, it's essentially an alias for 'lookup'. > #5 adds push/enqueue commands, an alias to 'update'. > #6 adds pop/dequeue commands that use bpf_map_lookup_and_delete_elem. > #7 adds bash completions > > v2: > * removed unneeded jsonw_null from patch #6 > * improved bash completions (and moved them into separate patch #7) Reviewed-by: Jakub Kicinski Thanks!