From: Tom Rini Date: Wed, 16 Jan 2019 12:10:53 -0500 Subject: [U-Boot] [U-Boot, 1/2] kbuild: add .DELETE_ON_ERROR special target In-Reply-To: <1547203347-19601-1-git-send-email-yamada.masahiro@socionext.com> References: <1547203347-19601-1-git-send-email-yamada.masahiro@socionext.com> Message-ID: <20190116171053.GZ27429@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de On Fri, Jan 11, 2019 at 07:42:26PM +0900, Masahiro Yamada wrote: > Linux commit 9c2af1c7377a8a6ef86e5cabf80978f3dbbb25c0 >=20 > If Make gets a fatal signal while a shell is executing, it may delete > the target file that the recipe was supposed to update. This is needed > to make sure that it is remade from scratch when Make is next run; if > Make is interrupted after the recipe has begun to write the target file, > it results in an incomplete file whose time stamp is newer than that > of the prerequisites files. Make automatically deletes the incomplete > file on interrupt unless the target is marked .PRECIOUS. >=20 > The situation is just the same as when the shell fails for some reasons. > Usually when a recipe line fails, if it has changed the target file at > all, the file is corrupted, or at least it is not completely updated. > Yet the file=E2=80=99s time stamp says that it is now up to date, so the = next > time Make runs, it will not try to update that file. >=20 > However, Make does not cater to delete the incomplete target file in > this case. We need to add .DELETE_ON_ERROR somewhere in the Makefile > to request it. >=20 > scripts/Kbuild.include seems a suitable place to add it because it is > included from almost all sub-makes. >=20 > Signed-off-by: Masahiro Yamada Applied to u-boot/master, thanks! --=20 Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: