From: Lyude Paul Subject: [PATCH 3/3] drm/dp_mst: Fix topology ref leak in drm_dp_mst_allocate_vcpi() Date: Wed, 16 Jan 2019 15:37:59 -0500 Message-ID: <20190116203759.31820-4-lyude@redhat.com> References: <20190116203759.31820-1-lyude@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id 88B666F206 for ; Wed, 16 Jan 2019 20:38:13 +0000 (UTC) In-Reply-To: <20190116203759.31820-1-lyude@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: David Airlie , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Maxime Ripard , Sean Paul List-Id: dri-devel@lists.freedesktop.org QW5vdGhlciBkcml2ZS1ieSBmaXguIElmIHNsb3RzIDwgMCwgb3IgZHJtX2RwX2luaXRfdmNwaSgp IGZhaWxzLCB3ZSdsbAplbmQgdXAgcmV0dXJuaW5nIGZyb20gdGhlIGZ1bmN0aW9uIHdpdGhvdXQg ZHJvcHBpbmcgdGhlIHRvcG9sb2d5IHJlZgp0aGF0IHdlIGdyYWJiZWQgYXQgdGhlIHZlcnkgc3Rh cnQuIFRoaXMgd291bGQgcmVzdWx0IGluIGFuIE1TVCBodWIKYW5kL29yIGl0J3MgcG9ydHMgc3Rh eWluZyBhcm91bmQgZXZlbiBhZnRlciB0aGUgTVNUIHRvcG9sb2d5IGhhcyBiZWVuCnJlbW92ZWQg ZnJvbSB0aGUgc3lzdGVtLgoKU28sIGZpeCB0aGlzIGJ5IG1ha2luZyBzdXJlIHRoYXQgd2UgYWx3 YXlzIGRyb3AgdGhlIHRvcG9sb2d5IHJlZiB0byBwb3J0CndoZW4gcmV0dXJuaW5nIGZyb20gdGhp cyBmdW5jdGlvbi4KCkFkZGl0aW9uYWxseTogaXQgbG9va3MgbGlrZSB0aGlzIGJ1ZyBleGlzdHMg cHJlLXRvcG9sb2d5ICYgbWFsbG9jIGtyZWZzLApzbyBsZXQncyBhbHNvIG1ha2Ugc3VyZSB0aGlz IGdldHMgYmFja3BvcnRlZCB0byBzdGFibGUuCgpTaWduZWQtb2ZmLWJ5OiBMeXVkZSBQYXVsIDxs eXVkZUByZWRoYXQuY29tPgpGaXhlczogYWQ3ZjhhMWY5Y2VkICgiZHJtL2hlbHBlcjogYWRkIERp c3BsYXlwb3J0IG11bHRpLXN0cmVhbSBoZWxwZXIgKHYwLjYpIikKQ2M6IERhdmlkIEFpcmxpZSA8 YWlybGllZEBsaW51eC5pZT4KQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4KQ2M6 IDxzdGFibGVAdmdlci5rZXJuZWwub3JnPiAjIHYzLjE3KwotLS0KIGRyaXZlcnMvZ3B1L2RybS9k cm1fZHBfbXN0X3RvcG9sb2d5LmMgfCAyNSArKysrKysrKysrKysrLS0tLS0tLS0tLS0tCiAxIGZp bGUgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2RybV9kcF9tc3RfdG9wb2xvZ3kuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fZHBfbXN0X3RvcG9sb2d5LmMKaW5kZXggZDk5NTYwYzVjNjkzLi40MDNmMDM1ZGM4Yjgg MTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHBfbXN0X3RvcG9sb2d5LmMKKysrIGIv ZHJpdmVycy9ncHUvZHJtL2RybV9kcF9tc3RfdG9wb2xvZ3kuYwpAQCAtMzE3NywyOCArMzE3Nywy OSBAQCBFWFBPUlRfU1lNQk9MKGRybV9kcF9hdG9taWNfcmVsZWFzZV92Y3BpX3Nsb3RzKTsKIGJv b2wgZHJtX2RwX21zdF9hbGxvY2F0ZV92Y3BpKHN0cnVjdCBkcm1fZHBfbXN0X3RvcG9sb2d5X21n ciAqbWdyLAogCQkJICAgICAgc3RydWN0IGRybV9kcF9tc3RfcG9ydCAqcG9ydCwgaW50IHBibiwg aW50IHNsb3RzKQogewotCWludCByZXQ7CisJaW50IHJjOworCWJvb2wgcmV0ID0gZmFsc2U7CiAK LQlwb3J0ID0gZHJtX2RwX21zdF90b3BvbG9neV9nZXRfcG9ydF92YWxpZGF0ZWQobWdyLCBwb3J0 KTsKLQlpZiAoIXBvcnQpCisJaWYgKHNsb3RzIDwgMCkKIAkJcmV0dXJuIGZhbHNlOwogCi0JaWYg KHNsb3RzIDwgMCkKKwlwb3J0ID0gZHJtX2RwX21zdF90b3BvbG9neV9nZXRfcG9ydF92YWxpZGF0 ZWQobWdyLCBwb3J0KTsKKwlpZiAoIXBvcnQpCiAJCXJldHVybiBmYWxzZTsKIAogCWlmIChwb3J0 LT52Y3BpLnZjcGkgPiAwKSB7CiAJCURSTV9ERUJVR19LTVMoInBheWxvYWQ6IHZjcGkgJWQgYWxy ZWFkeSBhbGxvY2F0ZWQgZm9yIHBibiAlZCAtIHJlcXVlc3RlZCBwYm4gJWRcbiIsCiAJCQkgICAg ICBwb3J0LT52Y3BpLnZjcGksIHBvcnQtPnZjcGkucGJuLCBwYm4pOwogCQlpZiAocGJuID09IHBv cnQtPnZjcGkucGJuKSB7Ci0JCQlkcm1fZHBfbXN0X3RvcG9sb2d5X3B1dF9wb3J0KHBvcnQpOwot CQkJcmV0dXJuIHRydWU7CisJCQlyZXQgPSB0cnVlOworCQkJZ290byBvdXQ7CiAJCX0KIAl9CiAK LQlyZXQgPSBkcm1fZHBfaW5pdF92Y3BpKG1nciwgJnBvcnQtPnZjcGksIHBibiwgc2xvdHMpOwot CWlmIChyZXQpIHsKKwlyYyA9IGRybV9kcF9pbml0X3ZjcGkobWdyLCAmcG9ydC0+dmNwaSwgcGJu LCBzbG90cyk7CisJaWYgKHJjKSB7CiAJCURSTV9ERUJVR19LTVMoImZhaWxlZCB0byBpbml0IHZj cGkgc2xvdHM9JWQgbWF4PTYzIHJldD0lZFxuIiwKLQkJCSAgICAgIERJVl9ST1VORF9VUChwYm4s IG1nci0+cGJuX2RpdiksIHJldCk7CisJCQkgICAgICBESVZfUk9VTkRfVVAocGJuLCBtZ3ItPnBi bl9kaXYpLCByYyk7CiAJCWdvdG8gb3V0OwogCX0KIAlEUk1fREVCVUdfS01TKCJpbml0aW5nIHZj cGkgZm9yIHBibj0lZCBzbG90cz0lZFxuIiwKQEAgLTMyMDYsMTAgKzMyMDcsMTAgQEAgYm9vbCBk cm1fZHBfbXN0X2FsbG9jYXRlX3ZjcGkoc3RydWN0IGRybV9kcF9tc3RfdG9wb2xvZ3lfbWdyICpt Z3IsCiAKIAkvKiBLZWVwIHBvcnQgYWxsb2NhdGVkIHVudGlsIGl0J3MgcGF5bG9hZCBoYXMgYmVl biByZW1vdmVkICovCiAJZHJtX2RwX21zdF9nZXRfcG9ydF9tYWxsb2MocG9ydCk7Ci0JZHJtX2Rw X21zdF90b3BvbG9neV9wdXRfcG9ydChwb3J0KTsKLQlyZXR1cm4gdHJ1ZTsKKwlyZXQgPSB0cnVl Owogb3V0OgotCXJldHVybiBmYWxzZTsKKwlkcm1fZHBfbXN0X3RvcG9sb2d5X3B1dF9wb3J0KHBv cnQpOworCXJldHVybiByZXQ7CiB9CiBFWFBPUlRfU1lNQk9MKGRybV9kcF9tc3RfYWxsb2NhdGVf dmNwaSk7CiAKLS0gCjIuMjAuMQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCg==