From: Christoph Hellwig Subject: Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap Date: Thu, 17 Jan 2019 01:02:43 -0800 Message-ID: <20190117090243.GA21651@infradead.org> References: <20190111180523.27862-1-afd@ti.com> <20190111180523.27862-14-afd@ti.com> <79eb70f6-00b0-2939-5ec9-65e196ab4987@ti.com> <99ca0b08-02bd-64fd-d43c-c330f0d11639@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <99ca0b08-02bd-64fd-d43c-c330f0d11639@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: "Andrew F. Davis" Cc: Laura Abbott , Liam Mark , Sumit Semwal , Greg Kroah-Hartman , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, dri-devel List-Id: dri-devel@lists.freedesktop.org On Wed, Jan 16, 2019 at 10:17:23AM -0600, Andrew F. Davis wrote: > I wouldn't go as far as to remove them just yet.. Liam seems pretty > adamant that they have valid uses. I'm just not sure performance is one > of them, maybe in the case of software locks between devices or > something where there needs to be a lot of back and forth interleaved > access on small amounts of data? We shouldn't add unused features to start with. If mainline users for them appear we can always add them back once we've reviewed the uses cases and agree that they are sane and have no better solution.