From: Stefan Agner Subject: [PATCH 4/5] ASoC: imx-sgtl5000: put of nodes if finding codec fails Date: Thu, 17 Jan 2019 10:06:39 +0100 Message-ID: <20190117090640.12972-4-stefan@agner.ch> References: <20190117090640.12972-1-stefan@agner.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.kmu-office.ch (mail.kmu-office.ch [178.209.48.109]) by alsa0.perex.cz (Postfix) with ESMTP id 0D1A2266B69 for ; Thu, 17 Jan 2019 10:06:52 +0100 (CET) In-Reply-To: <20190117090640.12972-1-stefan@agner.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.com, Stefan Agner , lgirdwood@gmail.com, broonie@kernel.org, fabio.estevam@nxp.com List-Id: alsa-devel@alsa-project.org Make sure to properly put the of node in case finding the codec fails. Fixes: 81e8e4926167 ("ASoC: fsl: add sgtl5000 clock support for imx-sgtl5000") Signed-off-by: Stefan Agner --- sound/soc/fsl/imx-sgtl5000.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/fsl/imx-sgtl5000.c b/sound/soc/fsl/imx-sgtl5000.c index e1e20499b2f1..45969e6dfad7 100644 --- a/sound/soc/fsl/imx-sgtl5000.c +++ b/sound/soc/fsl/imx-sgtl5000.c @@ -111,7 +111,8 @@ static int imx_sgtl5000_probe(struct platform_device *pdev) codec_dev = of_find_i2c_device_by_node(codec_np); if (!codec_dev) { dev_err(&pdev->dev, "failed to find codec platform device\n"); - return -EPROBE_DEFER; + ret = -EPROBE_DEFER; + goto fail; } data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL); -- 2.20.1