Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8907FC43387 for ; Thu, 17 Jan 2019 19:24:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58EBF20859 for ; Thu, 17 Jan 2019 19:24:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ab6u8AR5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728571AbfAQTYC (ORCPT ); Thu, 17 Jan 2019 14:24:02 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:38537 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728542AbfAQTYB (ORCPT ); Thu, 17 Jan 2019 14:24:01 -0500 Received: by mail-pg1-f195.google.com with SMTP id g189so4860107pgc.5 for ; Thu, 17 Jan 2019 11:24:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ln8un1JifUdIYYRzJ1qaBlvIw09pGybu1JjaIB2x73M=; b=ab6u8AR5ua+6KE5sziSmo5iJ0VTG4VvFoHX0BqaHLnMoE9XWiv9WwBlDaXnlGsUPMs AjTrGk2Adt0nHLUS4/c12pq31LOpZE4+9ugCdb94bKq3wVhHe+4Rotobm0i0JtDqUojT kOcjlLtbrFPcCWUjboZ3F7vWkIIrSnFFXgdroiTKwj2NKpdiC8DuREV4TTPZ6zuOL9WK k7OEJv5cbES6k9fTJ+c0uhy7R4XoHBc257c+TVb6/OLn4mYkH8QBLeMv/FbssOJDADd+ kVnmd8NFwvM/Id60EBCc9GoRpT8wBHmP3bGH926UyQKdUlcsirUC1hnfAmMJOzDWLk9g DfNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ln8un1JifUdIYYRzJ1qaBlvIw09pGybu1JjaIB2x73M=; b=DpTwoJL/+l4eTtBRaC/h+jqLdLO3ru77etiIvcf1+siLQUNTDZlr2KlFS+xhcNXo55 RnNMpwULQz0YKZ1o0DES7iVGMLSmOqQ4zkZ1SwtR1AZvvJlWlH6kznq0wMfAhqrW8Ren Wtc79t2MQhGv/njdUi4kaS6l32AroC/dUJ+kSEZRkPUb0vm6MSltz/XhLKAmOs7O/JzJ 2AfDANJvKmpBdd7aZKrcGhlEgiY8IHBXY8Juc+68XcD4WoqUCUZ7xOfyTu+73ZQgiC7I b2IX3vLMzooIGr7HHOjjlMzE6zOZzIegi4PR3RkIw7R3RhV7TSlv60NHp+KXBLUY4hvd 7GCA== X-Gm-Message-State: AJcUukd76yjdMKU4gGaiExdLXqqq89V7fV+/WC7OhtTYqyN5cMuJqecU NH4vXHH+hT6aznqEsfgd1pe7QQ== X-Google-Smtp-Source: ALg8bN51boBn9XTQnNB9pSYV1YRGRXN/ujG7sZsXYKeIm0UtZgM5qG+v9irbcv1dUovczEcHyqh7oQ== X-Received: by 2002:a63:6984:: with SMTP id e126mr14809562pgc.143.1547753040054; Thu, 17 Jan 2019 11:24:00 -0800 (PST) Received: from localhost ([2620:15c:2c4:201:f5a:7eca:440a:3ead]) by smtp.gmail.com with ESMTPSA id j70sm3376012pfc.43.2019.01.17.11.23.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Jan 2019 11:23:59 -0800 (PST) From: Eric Dumazet To: "David S . Miller" Cc: netdev , Soheil Hassas Yeganeh , Neal Cardwell , Yuchung Cheng , Eric Dumazet , Eric Dumazet Subject: [PATCH net-next 07/11] tcp: do not clear urg_data in tcp_create_openreq_child Date: Thu, 17 Jan 2019 11:23:38 -0800 Message-Id: <20190117192342.71126-8-edumazet@google.com> X-Mailer: git-send-email 2.20.1.321.g9e740568ce-goog In-Reply-To: <20190117192342.71126-1-edumazet@google.com> References: <20190117192342.71126-1-edumazet@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org All listeners have this field cleared already, since tcp_disconnect() clears it and newly created sockets have also a zero value here. So a clone will inherit a zero value here. Signed-off-by: Eric Dumazet --- net/ipv4/tcp_minisocks.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c index ca96e7da99b6e450a5e881e280ad84137a57409d..2747aa72b8e2b5c190c2c3e68a7dea04ee97dcac 100644 --- a/net/ipv4/tcp_minisocks.c +++ b/net/ipv4/tcp_minisocks.c @@ -501,8 +501,6 @@ struct sock *tcp_create_openreq_child(const struct sock *sk, newtp->rx_opt.dsack = 0; newtp->rx_opt.num_sacks = 0; - newtp->urg_data = 0; - if (sock_flag(newsk, SOCK_KEEPOPEN)) inet_csk_reset_keepalive_timer(newsk, keepalive_time_when(newtp)); -- 2.20.1.321.g9e740568ce-goog