Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7B50C43387 for ; Thu, 17 Jan 2019 19:56:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 938F120851 for ; Thu, 17 Jan 2019 19:56:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="pSCBh7ag" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729185AbfAQT4Q (ORCPT ); Thu, 17 Jan 2019 14:56:16 -0500 Received: from mail-vk1-f201.google.com ([209.85.221.201]:46335 "EHLO mail-vk1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728952AbfAQT4Q (ORCPT ); Thu, 17 Jan 2019 14:56:16 -0500 Received: by mail-vk1-f201.google.com with SMTP id p22so2534131vkd.13 for ; Thu, 17 Jan 2019 11:56:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=/FzbjiViEIGNdsRLDpkbnec2LItTE1CMPVo0ydM0IDs=; b=pSCBh7aggYFM1xomSXvaYRmBcdojhTPyT0ZnxCbnBjTmw3flufq8dOHi1/uN0BKd2i HpPNcFItLpCSZV60lniQ6jt0CHlgOkhhKX+rFyu/kIkhsAkd/iU7OlzrvtDZT4u9uSVW BojTUayh4oRfjbTUwNYKWJsWuqyai1dZH3XVSu0CQqt3iz1g26UpyZlu1JJF+bQ3O/sF MeI56eTYZViawtVz6K2qhz1VItyWQ8c0N9KnBoH5e0IXNtqFNtHYvrDvE+SlMtZ9y8no q7JuZrBERAC5FxjyhIl8A3CumhouwhEtOoPla8Wdie4HY5InClWHo+jDm3f0zjn1OVf3 b98Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=/FzbjiViEIGNdsRLDpkbnec2LItTE1CMPVo0ydM0IDs=; b=sWxxX/Ass5olD4v2RFcOhXmDRLxSmAXFWkopSdOWmFRdLBLhsx3oAiPiUf7FEFWfb+ Uz+EBV0G6CO6ZMgZfQY++cRNTkObEhSJdR084J3Gjcui3jMgwXb9xAgti9RcL/e16a5/ /od6hpisRelPHgwzHrlmeIOG3mmVDWTCvIA0eaD7Cx/CSEN4Mxo0Ebasmhv4iEd1RTxi rN9qra9SnbGy2CKN+PXovBsXcQafpdELt+P+48XpXggzp4rKr3lZxXF9ogjaY+UafmrS OpcGzHHqTXdSA7f/YuEP77KOR2lictyTcknl8MfmOLk9HwGPYkI5kgFvepkNKgOjghzW o+Hw== X-Gm-Message-State: AJcUukfsS0ZXhtGJpJzQxgxYTFjrEswxTPt1/0lk4SpaXySDHsu2C9BD RfH3T7MjWUa9bi/4trZKdjkalHcMaFQyvR2+Hn2hsBtRZL2SqpmtdjyOmi7Im2QDaEvABFEnfYS KvkoIQahCHHdn3lUuklcyGaxQDKGXQUSqWgqIU2Jtm+rqqTFeWmTCFg== X-Google-Smtp-Source: ALg8bN7AdiOW4IZV33bPXXgDbOZ4NKanzO6ih7KgGBE+XPs6yE+cL3C9rHQtHbkreAVdLGEruGvRgjk= X-Received: by 2002:a67:8208:: with SMTP id e8mr4002120vsd.20.1547754975328; Thu, 17 Jan 2019 11:56:15 -0800 (PST) Date: Thu, 17 Jan 2019 11:56:12 -0800 Message-Id: <20190117195612.157663-1-sdf@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.20.1.97.g81188d93c3-goog Subject: [PATCH bpf-next] selftests/bpf: don't hardcode iptables/nc path in test_tcpnotify_user From: Stanislav Fomichev To: netdev@vger.kernel.org Cc: davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net, Stanislav Fomichev Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org system() is calling shell which should find the appropriate full path via $PATH. On some systems, full path to iptables and/or nc might be different that we one we have hardcoded. Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/test_tcpnotify_user.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/bpf/test_tcpnotify_user.c b/tools/testing/selftests/bpf/test_tcpnotify_user.c index 4e4353711a86..86152d9ae95b 100644 --- a/tools/testing/selftests/bpf/test_tcpnotify_user.c +++ b/tools/testing/selftests/bpf/test_tcpnotify_user.c @@ -148,17 +148,17 @@ int main(int argc, char **argv) pthread_create(&tid, NULL, poller_thread, (void *)&pmu_fd); sprintf(test_script, - "/usr/sbin/iptables -A INPUT -p tcp --dport %d -j DROP", + "iptables -A INPUT -p tcp --dport %d -j DROP", TESTPORT); system(test_script); sprintf(test_script, - "/usr/bin/nc 127.0.0.1 %d < /etc/passwd > /dev/null 2>&1 ", + "nc 127.0.0.1 %d < /etc/passwd > /dev/null 2>&1 ", TESTPORT); system(test_script); sprintf(test_script, - "/usr/sbin/iptables -D INPUT -p tcp --dport %d -j DROP", + "iptables -D INPUT -p tcp --dport %d -j DROP", TESTPORT); system(test_script); -- 2.20.1.97.g81188d93c3-goog